From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SrVQV-00051j-NF
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 10:40:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SrVQP-0000Dk-Us
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 10:40:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20788)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SrVQP-0000D0-NX
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 10:40:25 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1342617545-9261-1-git-send-email-liwanp@linux.vnet.ibm.com>
	<1342617545-9261-5-git-send-email-liwanp@linux.vnet.ibm.com>
Date: Wed, 18 Jul 2012 16:39:38 +0200
In-Reply-To: <1342617545-9261-5-git-send-email-liwanp@linux.vnet.ibm.com>
	(Wanpeng Li's message of "Wed, 18 Jul 2012 21:19:04 +0800")
Message-ID: <87bojdw2tx.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET,
	RTC and i8254 through composition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Gavin Shan <shangw@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Ram Pai <pair@us.ibm.com>, Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <weil@mail.berlios.de>, Liu Ping Fan <kernelfans@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Avi Kivity <avi@redhat.com>

Wanpeng Li <liwanp@linux.vnet.ibm.com> writes:

> [CCing ML]
>  
>  From: Anthony Liguori <aliguori@us.ibm.com>
>
> The HPET usually sits on the LPC bus (which replaces ISA in modern systems).
> It's sometimes a dedicated chip but can certain co-exist in a Super IO chip.
> I think in terms of where it would live in this hypothetical device model,
> putting it in the PIIX is rational.

Could you explain briefly why you have to move struct definitions from
.c to .h?