All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Paul Walmsley <paul@pwsan.com>
Cc: Chase Maupin <Chase.Maupin@ti.com>,
	linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
	sakoman@gmail.com
Subject: Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices
Date: Thu, 15 Mar 2012 23:22:26 -0400	[thread overview]
Message-ID: <87bonxcjrh.fsf@laptop.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1203120435200.11332@utopia.booyaka.com> (Paul Walmsley's message of "Mon, 12 Mar 2012 04:58:00 -0600 (MDT)")

Hi Paul,

On Mon, Mar 12 2012, Paul Walmsley wrote:
> I don't think this is the right fix.  Steve Sakoman and I discussed this a 
> few months ago -- we did some debugging and Steve observed the timeouts on 
> multiple block writes (0x19):
> [...]
> So perhaps something like the following patch instead?  Unfortunately, I 
> don't have one of these crappy SD cards as far as I know, so I can't 
> really test it.
>
>
> - Paul
>
> From: Paul Walmsley <paul@pwsan.com>
> Date: Mon, 12 Mar 2012 04:46:29 -0600
> Subject: [PATCH] mmc: use really long write timeout to deal with crappy cards
>
> Several people have noticed that crappy SD cards take much longer to
> complete multiple block writes than the 300ms that Linux specifies.
> Try to work around this by using a three second write timeout instead.
>
> <insert Chase's patch description here>
>
> Not-yet-signed-off-by: Paul Walmsley <paul@pwsan.com>

Sounds like a good idea -- want to send a signed-off patch for this?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2012-03-16  3:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01 17:26 [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices Chase Maupin
2012-03-06 12:54 ` Maupin, Chase
2012-03-09  4:38 ` Chris Ball
2012-03-09 13:06   ` Maupin, Chase
2012-03-12 10:58   ` Paul Walmsley
2012-03-12 11:10     ` Paul Walmsley
2012-03-12 14:37     ` Maupin, Chase
2012-03-16  3:22     ` Chris Ball [this message]
2012-04-05 22:08       ` Tony Lindgren
2012-04-05 22:15         ` Chris Ball
2012-04-05 23:44           ` Paul Walmsley
2012-04-05 23:54             ` Chris Ball
2012-04-12  9:46               ` Tushar Behera
2012-04-12 17:56                 ` Paul Walmsley
2012-04-12 18:19                   ` Chris Ball
2012-04-14  9:38                     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bonxcjrh.fsf@laptop.org \
    --to=cjb@laptop.org \
    --cc=Chase.Maupin@ti.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.