From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753809Ab1H3XAo (ORCPT ); Tue, 30 Aug 2011 19:00:44 -0400 Received: from na3sys009aog109.obsmtp.com ([74.125.149.201]:47969 "EHLO na3sys009aog109.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753029Ab1H3XAn (ORCPT ); Tue, 30 Aug 2011 19:00:43 -0400 From: Kevin Hilman To: Abhilash K V Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tony@atomide.com, linux@arm.linux.org.uk, Vaibhav Hiremath Subject: Re: [PATCH 3/4] pm34xx: Warning FIX related to ambiguous else loop Organization: Texas Instruments, Inc. References: <1313754927-11992-1-git-send-email-abhilash.kv@ti.com> <1313754927-11992-2-git-send-email-abhilash.kv@ti.com> <1313754927-11992-3-git-send-email-abhilash.kv@ti.com> <1313754927-11992-4-git-send-email-abhilash.kv@ti.com> Date: Tue, 30 Aug 2011 16:00:39 -0700 In-Reply-To: <1313754927-11992-4-git-send-email-abhilash.kv@ti.com> (Abhilash K. V.'s message of "Fri, 19 Aug 2011 17:25:26 +0530") Message-ID: <87bov6ld2g.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Abhilash K V writes: > From: Vaibhav Hiremath > > Fixes below warning - > > arch/arm/mach-omap2/pm34xx.c:1041: warning: > suggest explicit braces to avoid ambiguous 'else This warning was introduced in [1/4], so I'd suggest just folding this fix into the original patch. Kevin > Signed-off-by: Vaibhav Hiremath > Signed-off-by: Abhilash K V > --- > arch/arm/mach-omap2/pm34xx.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c > index 12af5b9..ab3822b 100644 > --- a/arch/arm/mach-omap2/pm34xx.c > +++ b/arch/arm/mach-omap2/pm34xx.c > @@ -856,7 +856,7 @@ void omap_push_sram_idle(void) > else > _omap_sram_idle = omap_sram_push(omap34xx_cpu_suspend, > omap34xx_cpu_suspend_sz); > - if (omap_type() != OMAP2_DEVICE_TYPE_GP) > + if (omap_type() != OMAP2_DEVICE_TYPE_GP) { > if (cpu_is_omap3505() || cpu_is_omap3517()) > _omap_save_secure_sram = omap_sram_push( > omap3517_save_secure_ram_context, > @@ -865,6 +865,7 @@ void omap_push_sram_idle(void) > _omap_save_secure_sram = omap_sram_push( > save_secure_ram_context, > save_secure_ram_context_sz); > + } > } > > static void __init pm_errata_configure(void) From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Tue, 30 Aug 2011 16:00:39 -0700 Subject: [PATCH 3/4] pm34xx: Warning FIX related to ambiguous else loop In-Reply-To: <1313754927-11992-4-git-send-email-abhilash.kv@ti.com> (Abhilash K. V.'s message of "Fri, 19 Aug 2011 17:25:26 +0530") References: <1313754927-11992-1-git-send-email-abhilash.kv@ti.com> <1313754927-11992-2-git-send-email-abhilash.kv@ti.com> <1313754927-11992-3-git-send-email-abhilash.kv@ti.com> <1313754927-11992-4-git-send-email-abhilash.kv@ti.com> Message-ID: <87bov6ld2g.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Abhilash K V writes: > From: Vaibhav Hiremath > > Fixes below warning - > > arch/arm/mach-omap2/pm34xx.c:1041: warning: > suggest explicit braces to avoid ambiguous 'else This warning was introduced in [1/4], so I'd suggest just folding this fix into the original patch. Kevin > Signed-off-by: Vaibhav Hiremath > Signed-off-by: Abhilash K V > --- > arch/arm/mach-omap2/pm34xx.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c > index 12af5b9..ab3822b 100644 > --- a/arch/arm/mach-omap2/pm34xx.c > +++ b/arch/arm/mach-omap2/pm34xx.c > @@ -856,7 +856,7 @@ void omap_push_sram_idle(void) > else > _omap_sram_idle = omap_sram_push(omap34xx_cpu_suspend, > omap34xx_cpu_suspend_sz); > - if (omap_type() != OMAP2_DEVICE_TYPE_GP) > + if (omap_type() != OMAP2_DEVICE_TYPE_GP) { > if (cpu_is_omap3505() || cpu_is_omap3517()) > _omap_save_secure_sram = omap_sram_push( > omap3517_save_secure_ram_context, > @@ -865,6 +865,7 @@ void omap_push_sram_idle(void) > _omap_save_secure_sram = omap_sram_push( > save_secure_ram_context, > save_secure_ram_context_sz); > + } > } > > static void __init pm_errata_configure(void)