From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753165Ab1EQCta (ORCPT ); Mon, 16 May 2011 22:49:30 -0400 Received: from ozlabs.org ([203.10.76.45]:41420 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752203Ab1EQCt0 (ORCPT ); Mon, 16 May 2011 22:49:26 -0400 From: Rusty Russell To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Carsten Otte , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Shirley Ma , lguest@lists.ozlabs.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Krishna Kumar , Tom Lendacky , steved@us.ibm.com, habanero@linux.vnet.ibm.com Subject: Re: [PATCH 14/18] virtio: add api for delayed callbacks In-Reply-To: <20110515124818.GD24932@redhat.com> References: <64d47c628b3fdc0ac156aed4be182933d8bcc0db.1304541919.git.mst@redhat.com> <871v08h0vm.fsf@rustcorp.com.au> <20110515124818.GD24932@redhat.com> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) Date: Mon, 16 May 2011 16:43:21 +0930 Message-ID: <87boz3dsoe.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 15 May 2011 15:48:18 +0300, "Michael S. Tsirkin" wrote: > On Mon, May 09, 2011 at 03:27:33PM +0930, Rusty Russell wrote: > > On Wed, 4 May 2011 23:52:33 +0300, "Michael S. Tsirkin" wrote: > > > Add an API that tells the other side that callbacks > > > should be delayed until a lot of work has been done. > > > Implement using the new used_event feature. > > > > Since you're going to add a capacity query anyway, why not add the > > threshold argument here? > > I thought that if we keep the API kind of generic > there might be more of a chance that future transports > will be able to implement it. For example, with an > old host we can't commit to a specific index. No, it's always a hint anyway: you can be notified before the threshold is reached. But best make it explicit I think. Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 14/18] virtio: add api for delayed callbacks Date: Mon, 16 May 2011 16:43:21 +0930 Message-ID: <87boz3dsoe.fsf@rustcorp.com.au> References: <64d47c628b3fdc0ac156aed4be182933d8bcc0db.1304541919.git.mst@redhat.com> <871v08h0vm.fsf@rustcorp.com.au> <20110515124818.GD24932@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Krishna Kumar , Carsten Otte , lguest-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Shirley Ma , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, habanero-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Heiko Carstens , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, steved-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, Christian Borntraeger , Tom Lendacky , Martin Schwidefsky , linux390-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20110515124818.GD24932-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lguest-bounces+glkvl-lguest=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: lguest-bounces+glkvl-lguest=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: netdev.vger.kernel.org On Sun, 15 May 2011 15:48:18 +0300, "Michael S. Tsirkin" wrote: > On Mon, May 09, 2011 at 03:27:33PM +0930, Rusty Russell wrote: > > On Wed, 4 May 2011 23:52:33 +0300, "Michael S. Tsirkin" wrote: > > > Add an API that tells the other side that callbacks > > > should be delayed until a lot of work has been done. > > > Implement using the new used_event feature. > > > > Since you're going to add a capacity query anyway, why not add the > > threshold argument here? > > I thought that if we keep the API kind of generic > there might be more of a chance that future transports > will be able to implement it. For example, with an > old host we can't commit to a specific index. No, it's always a hint anyway: you can be notified before the threshold is reached. But best make it explicit I think. Cheers, Rusty.