From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758936AbcJ1Kjm (ORCPT ); Fri, 28 Oct 2016 06:39:42 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32988 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbcJ1Kjl (ORCPT ); Fri, 28 Oct 2016 06:39:41 -0400 Subject: Re: [PATCH] drm/mediatek: fix null pointer dereference To: CK Hu References: <20161026140904.26798-1-matthias.bgg@gmail.com> <1477643686.17640.3.camel@mtksdaap41> Cc: p.zabel@pengutronix.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org From: Matthias Brugger Message-ID: <87c18360-467c-267b-1400-48d985ecdc8a@gmail.com> Date: Fri, 28 Oct 2016 12:39:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477643686.17640.3.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/2016 10:34 AM, CK Hu wrote: > Hi, Matthias: > > Even though OVL HW would not be enabled before component_add() in > current design, your patch would be safe for any situation. Maybe the FW I use left an interrupt pending before loading the kernel and this leads to the case where we enter the handler before all data structures are set up. > > Acked-by CK Hu Thanks! Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH] drm/mediatek: fix null pointer dereference Date: Fri, 28 Oct 2016 12:39:37 +0200 Message-ID: <87c18360-467c-267b-1400-48d985ecdc8a@gmail.com> References: <20161026140904.26798-1-matthias.bgg@gmail.com> <1477643686.17640.3.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1477643686.17640.3.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: CK Hu Cc: airlied-cv59FeDIM0c@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On 10/28/2016 10:34 AM, CK Hu wrote: > Hi, Matthias: > > Even though OVL HW would not be enabled before component_add() in > current design, your patch would be safe for any situation. Maybe the FW I use left an interrupt pending before loading the kernel and this leads to the case where we enter the handler before all data structures are set up. > > Acked-by CK Hu Thanks! Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Fri, 28 Oct 2016 12:39:37 +0200 Subject: [PATCH] drm/mediatek: fix null pointer dereference In-Reply-To: <1477643686.17640.3.camel@mtksdaap41> References: <20161026140904.26798-1-matthias.bgg@gmail.com> <1477643686.17640.3.camel@mtksdaap41> Message-ID: <87c18360-467c-267b-1400-48d985ecdc8a@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/28/2016 10:34 AM, CK Hu wrote: > Hi, Matthias: > > Even though OVL HW would not be enabled before component_add() in > current design, your patch would be safe for any situation. Maybe the FW I use left an interrupt pending before loading the kernel and this leads to the case where we enter the handler before all data structures are set up. > > Acked-by CK Hu Thanks! Matthias