All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: Aw: Re: Re: Re: [ANN] U-Boot v2020.07-rc1 released
Date: Fri, 1 May 2020 20:08:08 +0200	[thread overview]
Message-ID: <87c1ba46-8bb7-dff2-046c-394d1aad05ac@denx.de> (raw)
In-Reply-To: <trinity-27d5f2fe-b699-4672-a88a-2dc8f4567ea4-1588355332928@3c-app-gmx-bs43>

On 5/1/20 7:48 PM, Frank Wunderlich wrote:
>>>> Gesendet: Freitag, 01. Mai 2020 um 17:39 Uhr
>>>> Von: "Marek Vasut" <marex@denx.de>
>>>> Build failed, please fix:
>>>> https://gitlab.denx.de/u-boot/custodians/u-boot-usb/pipelines/3054
> 
> could you try if all tests passing after this Patch?
> 
> regards Frank
> 
> commit 9c4a3633e92dbcd51aa60ff14693adc900e3c816
> Author: Frank Wunderlich <frank-w@public-files.de>
> Date:   Fri May 1 19:32:12 2020 +0200
> 
>     fix build-error for xilinx-board caused by xhci-Patches
> 
>     Fixes: "usb: dwc3: use the phy bulk API to get phys"
> 
> diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c
> index 9fcfa39d4b..563db1a426 100644
> --- a/drivers/usb/host/xhci-dwc3.c
> +++ b/drivers/usb/host/xhci-dwc3.c
> @@ -19,8 +19,7 @@
>  #include <linux/usb/otg.h>
> 
>  struct xhci_dwc3_platdata {
> -       struct phy *usb_phys;
> -       int num_phys;
> +       struct phy_bulk *usb_phys;
>  };
> 
>  void dwc3_set_mode(struct dwc3 *dwc3_reg, u32 mode)
> @@ -125,7 +124,7 @@ static int xhci_dwc3_probe(struct udevice *dev)
>         hcor = (struct xhci_hcor *)((uintptr_t)hccr +
>                         HC_LENGTH(xhci_readl(&(hccr)->cr_capbase)));
> 
> -       ret = dwc3_setup_phy(dev, &plat->usb_phys, &plat->num_phys);
> +       ret = dwc3_setup_phy(dev, plat->usb_phys);
>         if (ret && (ret != -ENOTSUPP))
>                 return ret;
> 
> @@ -168,7 +167,7 @@ static int xhci_dwc3_remove(struct udevice *dev)
>  {
>         struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
> 
> -       dwc3_shutdown_phy(dev, plat->usb_phys, plat->num_phys);
> +       dwc3_shutdown_phy(dev, plat->usb_phys);
> 
>         return xhci_deregister(dev);
>  }

It's a build failure, build it for versal_virt and see if the error is
gone. Is it ?

  reply	other threads:[~2020-05-01 18:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 12:49 [ANN] U-Boot v2020.07-rc1 released Tom Rini
2020-04-29 13:24 ` Frank Wunderlich
2020-04-30 22:18   ` Tom Rini
2020-05-01  9:18     ` Marek Vasut
2020-05-01 13:49       ` Aw: " Frank Wunderlich
2020-05-01 15:14         ` Marek Vasut
2020-05-01 15:39           ` Marek Vasut
2020-05-01 15:46             ` Aw: " Frank Wunderlich
2020-05-01 15:50               ` Marek Vasut
2020-05-01 17:48                 ` Aw: " Frank Wunderlich
2020-05-01 18:08                   ` Marek Vasut [this message]
2020-05-01 18:12                     ` Aw: " Frank Wunderlich
2020-05-01 18:20                       ` Marek Vasut
2020-05-01 15:53             ` Anatolij Gustschin
2020-05-01 15:56               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87c1ba46-8bb7-dff2-046c-394d1aad05ac@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.