From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22E39C433FE for ; Thu, 13 Oct 2022 15:54:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AF6610E29B; Thu, 13 Oct 2022 15:54:13 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABFDC10E29B; Thu, 13 Oct 2022 15:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665676443; x=1697212443; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=CM9Fco5EJGl2ou0b70nvrp8JViXa3h4Vj0v8XS3ctPc=; b=bt7+KVj3ruBv7BfE/MD7ftdzhuTv8auvuHsJKSqbyb7UcELjGLPIBSVu KGMRgOH8b6ORBqAOEEuJ9eT1/Z/XCks1sa3oufGhsmaNjtph2alt3ldcr izXj51vV3CFmpgDR2VpVqN2jDskZgvYF+eVMPAZWHIV2IC7pUflYNGPkG i2QY+FdRHzCpfg46Q9ZVhvfc6smge1cdJIfPIzBUyeX3C6YenH6A5qK7B iSyFBlgf5BgECH0LYVJCavActCqjyM2noqS566zk5BGKEYUCC+12tuj+i TQ0Yr36AJZFMfKSsh3eeBN65H3sYWrwB9dSKmy024TvDIWS1KSAOMI1Wq Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="288396611" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="288396611" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 08:54:02 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="956219232" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="956219232" Received: from sudhars1-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.216.120]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 08:54:01 -0700 Date: Thu, 13 Oct 2022 08:54:00 -0700 Message-ID: <87czavsorr.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Andi Shyti Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting In-Reply-To: References: <20220927055020.3499420-1-badal.nilawar@intel.com> <20220927055020.3499420-4-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Badal Nilawar Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 03 Oct 2022 14:05:14 -0700, Andi Shyti wrote: > > Hi Badal, > > [...] > > > hwm_get_preregistration_info(struct drm_i915_private *i915) > > { > > struct i915_hwmon *hwmon = i915->hwmon; > > + struct intel_uncore *uncore = &i915->uncore; > > + intel_wakeref_t wakeref; > > + u32 val_sku_unit; > > > > - if (IS_DG1(i915) || IS_DG2(i915)) > > + if (IS_DG1(i915) || IS_DG2(i915)) { > > hwmon->rg.gt_perf_status = GEN12_RPSTAT1; > > - else > > + hwmon->rg.pkg_power_sku_unit = PCU_PACKAGE_POWER_SKU_UNIT; > > + hwmon->rg.pkg_power_sku = PCU_PACKAGE_POWER_SKU; > > + hwmon->rg.pkg_rapl_limit = PCU_PACKAGE_RAPL_LIMIT; > > + } else { > > hwmon->rg.gt_perf_status = INVALID_MMIO_REG; > > + hwmon->rg.pkg_power_sku_unit = INVALID_MMIO_REG; > > + hwmon->rg.pkg_power_sku = INVALID_MMIO_REG; > > + hwmon->rg.pkg_rapl_limit = INVALID_MMIO_REG; > > + } > > + > > + with_intel_runtime_pm(uncore->rpm, wakeref) { > > + /* > > + * The contents of register hwmon->rg.pkg_power_sku_unit do not change, > > + * so read it once and store the shift values. > > + */ > > + if (i915_mmio_reg_valid(hwmon->rg.pkg_power_sku_unit)) { > > + val_sku_unit = intel_uncore_read(uncore, > > + hwmon->rg.pkg_power_sku_unit); > > + } else { > > + val_sku_unit = 0; > > + } > > please remove the brackets here and, just a small nitpick: > > move val_sky_unit inside the "with_intel_runtime_pm()" and > initialize it to '0', you will save the else statement. Hi Andi, fixed in v9 of the series. > > Other than that: > > Reviewed-by: Andi Shyti Thanks. -- Ashutosh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E948C4332F for ; Thu, 13 Oct 2022 15:54:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8519510E2A6; Thu, 13 Oct 2022 15:54:09 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABFDC10E29B; Thu, 13 Oct 2022 15:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665676443; x=1697212443; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=CM9Fco5EJGl2ou0b70nvrp8JViXa3h4Vj0v8XS3ctPc=; b=bt7+KVj3ruBv7BfE/MD7ftdzhuTv8auvuHsJKSqbyb7UcELjGLPIBSVu KGMRgOH8b6ORBqAOEEuJ9eT1/Z/XCks1sa3oufGhsmaNjtph2alt3ldcr izXj51vV3CFmpgDR2VpVqN2jDskZgvYF+eVMPAZWHIV2IC7pUflYNGPkG i2QY+FdRHzCpfg46Q9ZVhvfc6smge1cdJIfPIzBUyeX3C6YenH6A5qK7B iSyFBlgf5BgECH0LYVJCavActCqjyM2noqS566zk5BGKEYUCC+12tuj+i TQ0Yr36AJZFMfKSsh3eeBN65H3sYWrwB9dSKmy024TvDIWS1KSAOMI1Wq Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="288396611" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="288396611" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 08:54:02 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="956219232" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="956219232" Received: from sudhars1-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.216.120]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 08:54:01 -0700 Date: Thu, 13 Oct 2022 08:54:00 -0700 Message-ID: <87czavsorr.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Andi Shyti In-Reply-To: References: <20220927055020.3499420-1-badal.nilawar@intel.com> <20220927055020.3499420-4-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 03 Oct 2022 14:05:14 -0700, Andi Shyti wrote: > > Hi Badal, > > [...] > > > hwm_get_preregistration_info(struct drm_i915_private *i915) > > { > > struct i915_hwmon *hwmon = i915->hwmon; > > + struct intel_uncore *uncore = &i915->uncore; > > + intel_wakeref_t wakeref; > > + u32 val_sku_unit; > > > > - if (IS_DG1(i915) || IS_DG2(i915)) > > + if (IS_DG1(i915) || IS_DG2(i915)) { > > hwmon->rg.gt_perf_status = GEN12_RPSTAT1; > > - else > > + hwmon->rg.pkg_power_sku_unit = PCU_PACKAGE_POWER_SKU_UNIT; > > + hwmon->rg.pkg_power_sku = PCU_PACKAGE_POWER_SKU; > > + hwmon->rg.pkg_rapl_limit = PCU_PACKAGE_RAPL_LIMIT; > > + } else { > > hwmon->rg.gt_perf_status = INVALID_MMIO_REG; > > + hwmon->rg.pkg_power_sku_unit = INVALID_MMIO_REG; > > + hwmon->rg.pkg_power_sku = INVALID_MMIO_REG; > > + hwmon->rg.pkg_rapl_limit = INVALID_MMIO_REG; > > + } > > + > > + with_intel_runtime_pm(uncore->rpm, wakeref) { > > + /* > > + * The contents of register hwmon->rg.pkg_power_sku_unit do not change, > > + * so read it once and store the shift values. > > + */ > > + if (i915_mmio_reg_valid(hwmon->rg.pkg_power_sku_unit)) { > > + val_sku_unit = intel_uncore_read(uncore, > > + hwmon->rg.pkg_power_sku_unit); > > + } else { > > + val_sku_unit = 0; > > + } > > please remove the brackets here and, just a small nitpick: > > move val_sky_unit inside the "with_intel_runtime_pm()" and > initialize it to '0', you will save the else statement. Hi Andi, fixed in v9 of the series. > > Other than that: > > Reviewed-by: Andi Shyti Thanks. -- Ashutosh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5852CC43217 for ; Thu, 13 Oct 2022 15:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbiJMPyZ (ORCPT ); Thu, 13 Oct 2022 11:54:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbiJMPyY (ORCPT ); Thu, 13 Oct 2022 11:54:24 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4956837F8F for ; Thu, 13 Oct 2022 08:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665676464; x=1697212464; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=CM9Fco5EJGl2ou0b70nvrp8JViXa3h4Vj0v8XS3ctPc=; b=USjRwUso32ctXFqCmAt0XyM86VifqGX0niHMhTp7rkexZYs5FZGZVLfA 4BoxjZ2pDKJo4ugwPSnMgJ4W9tM4Ocse7fc/S7dzQDVVUZ7lh+Azaq66y pxCfJ/GJeukgaINyGww47hDCRVc9ERfVsXRGYtuMysrL54oTsuwY1z9Lq k82KlNylgx7OSz+WZja78p9O6UYgPM02jX9+j5LbdsggckSfikx1kDLyM tFRU0CGLi9CbYwEfTkCD+9ockyNQpIyY7+9BetLqPiL8HZKN/10AsK9My MKMNRvtwBlmrj1Uh7s61aXqrmPlxQxKR8o1BuA1W7XBgQfKx3j3at86cP w==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="367132557" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="367132557" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 08:54:01 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="956219232" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="956219232" Received: from sudhars1-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.216.120]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 08:54:01 -0700 Date: Thu, 13 Oct 2022 08:54:00 -0700 Message-ID: <87czavsorr.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Andi Shyti Cc: Badal Nilawar , linux-hwmon@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting In-Reply-To: References: <20220927055020.3499420-1-badal.nilawar@intel.com> <20220927055020.3499420-4-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Mon, 03 Oct 2022 14:05:14 -0700, Andi Shyti wrote: > > Hi Badal, > > [...] > > > hwm_get_preregistration_info(struct drm_i915_private *i915) > > { > > struct i915_hwmon *hwmon = i915->hwmon; > > + struct intel_uncore *uncore = &i915->uncore; > > + intel_wakeref_t wakeref; > > + u32 val_sku_unit; > > > > - if (IS_DG1(i915) || IS_DG2(i915)) > > + if (IS_DG1(i915) || IS_DG2(i915)) { > > hwmon->rg.gt_perf_status = GEN12_RPSTAT1; > > - else > > + hwmon->rg.pkg_power_sku_unit = PCU_PACKAGE_POWER_SKU_UNIT; > > + hwmon->rg.pkg_power_sku = PCU_PACKAGE_POWER_SKU; > > + hwmon->rg.pkg_rapl_limit = PCU_PACKAGE_RAPL_LIMIT; > > + } else { > > hwmon->rg.gt_perf_status = INVALID_MMIO_REG; > > + hwmon->rg.pkg_power_sku_unit = INVALID_MMIO_REG; > > + hwmon->rg.pkg_power_sku = INVALID_MMIO_REG; > > + hwmon->rg.pkg_rapl_limit = INVALID_MMIO_REG; > > + } > > + > > + with_intel_runtime_pm(uncore->rpm, wakeref) { > > + /* > > + * The contents of register hwmon->rg.pkg_power_sku_unit do not change, > > + * so read it once and store the shift values. > > + */ > > + if (i915_mmio_reg_valid(hwmon->rg.pkg_power_sku_unit)) { > > + val_sku_unit = intel_uncore_read(uncore, > > + hwmon->rg.pkg_power_sku_unit); > > + } else { > > + val_sku_unit = 0; > > + } > > please remove the brackets here and, just a small nitpick: > > move val_sky_unit inside the "with_intel_runtime_pm()" and > initialize it to '0', you will save the else statement. Hi Andi, fixed in v9 of the series. > > Other than that: > > Reviewed-by: Andi Shyti Thanks. -- Ashutosh