From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A99DC433F5 for ; Thu, 6 Oct 2022 07:41:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230328AbiJFHlA (ORCPT ); Thu, 6 Oct 2022 03:41:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbiJFHkz (ORCPT ); Thu, 6 Oct 2022 03:40:55 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4957E8E471 for ; Thu, 6 Oct 2022 00:40:53 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id bu30so1310752wrb.8 for ; Thu, 06 Oct 2022 00:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=czZIXcSril+0S5W4kqc0onDmBGjrVJmOKnFUKeX4tsk=; b=6qjVyGLzJP2d40EpuWNyVT7l6T1hqaLdgmVpPaEvxGoI3eNCRgjZbGBoV/FQXGFiob p1/snStTlv9rq/9KQBEnbttDzx9aV9UFcCtCpTruw0x3LnutL5LIoByYqspkjd4myhFG o66132ZmNOgdoO+IlS/KPAboWUZ4rxmqEi5tZR2IqESw7F5zea9zC2XndyD0QwNfiMW+ /nwbOLPLYFu+/Cky/cDEFK7gRRN0k+BrwlpQEh4ZaKLwj5dIr4NcKkO8p5HwaacjzsA6 gZ0TzxilJw76mVoMKbn+T6w4zrLCe+y6EPNId2yu4f5oz1jz2r47ME95GEpCEBO05Q/r AVKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=czZIXcSril+0S5W4kqc0onDmBGjrVJmOKnFUKeX4tsk=; b=xbO9JcenXRBW1E/LRHcRnghXImSxfe1Z3td82WcZLzFgl8eZOBTViJ0FbBhlry3i/6 zqXFb+gbTrwyPe1NeNsDzAnAtLNT82Xx2HbZq+1sV/2lWYwfsyzUfyif51WJA9HwuWvA dJVwZbK28GaWcqV6opZtZ40lJ0DhPi1KGwP+taoD7hM7OywYAHBtWjJDRRBuE4NBwo77 +sOXIVMLmxU0JtvRv525opUB4Xp4wIXxYABGxKlL874aocnG7nx/EhPWcOMLfvW8lGDw KIdvczljiDOF6B9qqTzJ4OimOrKiHOclvymMUT/3GAdCsY96cx8OFsnpSL/Mn0hACGAJ Uzsg== X-Gm-Message-State: ACrzQf3c3uUTa0FIQH17dWykLowHfOmG+0nsYyTNkJF+Z4KMNTLpW5ZW ddA15EtsDeJf07fJNHe+RFRFJg== X-Google-Smtp-Source: AMsMyM6xxcX+Jw879ZvGrzE2zvbkaNBbDJ39qRVbXxY0XUtG9zHNqjzwrFb8JpJ5s9D9VO54lzi4fg== X-Received: by 2002:a5d:404b:0:b0:22e:331e:1cba with SMTP id w11-20020a5d404b000000b0022e331e1cbamr2019320wrp.488.1665042051756; Thu, 06 Oct 2022 00:40:51 -0700 (PDT) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c190600b003a601a1c2f7sm4346819wmq.19.2022.10.06.00.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 00:40:51 -0700 (PDT) From: Mattijs Korpershoek To: Alexandre Mergnat , Lee Jones , Mark Brown , Matthias Brugger , Rob Herring , Liam Girdwood , Krzysztof Kozlowski , Dmitry Torokhov , Chen Zhong Cc: linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent , Alexandre Mergnat Subject: Re: [PATCH v2 5/5] Input: mtk-pmic-keys: add MT6357 support In-Reply-To: <20221005-mt6357-support-v2-5-f17ba2d2d0a9@baylibre.com> References: <20221005-mt6357-support-v2-0-f17ba2d2d0a9@baylibre.com> <20221005-mt6357-support-v2-5-f17ba2d2d0a9@baylibre.com> Date: Thu, 06 Oct 2022 09:40:50 +0200 Message-ID: <87czb5o0vx.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 05, 2022 at 16:57, Alexandre Mergnat wrote: > From: Fabien Parent > > Add PMIC Keys support on MT6357 SoC. > > Signed-off-by: Fabien Parent > Signed-off-by: Alexandre Mergnat Reviewed-by: Mattijs Korpershoek > --- > drivers/input/keyboard/mtk-pmic-keys.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c > index 9b34da0ec260..2a63e0718eb6 100644 > --- a/drivers/input/keyboard/mtk-pmic-keys.c > +++ b/drivers/input/keyboard/mtk-pmic-keys.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -90,6 +91,19 @@ static const struct mtk_pmic_regs mt6331_regs = { > .rst_lprst_mask = MTK_PMIC_MT6331_RST_DU_MASK, > }; > > +static const struct mtk_pmic_regs mt6357_regs = { > + .keys_regs[MTK_PMIC_PWRKEY_INDEX] = > + MTK_PMIC_KEYS_REGS(MT6357_TOPSTATUS, > + 0x2, MT6357_PSC_TOP_INT_CON0, 0x5, > + MTK_PMIC_PWRKEY_RST), > + .keys_regs[MTK_PMIC_HOMEKEY_INDEX] = > + MTK_PMIC_KEYS_REGS(MT6357_TOPSTATUS, > + 0x8, MT6357_PSC_TOP_INT_CON0, 0xa, > + MTK_PMIC_HOMEKEY_INDEX), > + .pmic_rst_reg = MT6357_TOP_RST_MISC, > + .rst_lprst_mask = MTK_PMIC_RST_DU_MASK, > +}; > + > static const struct mtk_pmic_regs mt6358_regs = { > .keys_regs[MTK_PMIC_PWRKEY_INDEX] = > MTK_PMIC_KEYS_REGS(MT6358_TOPSTATUS, > @@ -276,6 +290,9 @@ static const struct of_device_id of_mtk_pmic_keys_match_tbl[] = { > }, { > .compatible = "mediatek,mt6331-keys", > .data = &mt6331_regs, > + }, { > + .compatible = "mediatek,mt6357-keys", > + .data = &mt6357_regs, > }, { > .compatible = "mediatek,mt6358-keys", > .data = &mt6358_regs, > > -- > b4 0.10.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 746B5C433FE for ; Thu, 6 Oct 2022 07:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rZ/MDjH3pdLicUWM8RgCUEegM4xnE29idS3z8HqhP3Q=; b=spfkFIxuLIDU9I j5PynQ2RDI6AwJmeShOIoMX8z3y+D5IhCnjq8YuLBvMsoDWdTHhpz8AjE6kW9jIZgqrzgoxWHyh9c AcvBvF6BTgrd75yXglfAIAjahNDIlV7UTlj0zVN2m1+I5GboGkGb+Hq17t+0eM5WqBUyQsdbhJy94 Q9AszRJhEpb7XRYR0S/2SzpbaEW3B5Am+41KPQTI4SATDDNSPmF5/5cdi6O+DY5QZ+sHX5sSzlgJX 6a20NU31NuxmwZxTtwPgCz+BsDzDRnACDuz1vuoZ4C9wzHJIyiu05+zGlELi9Z722tCeiMgz5D5ol M9k7WlDHL9c8iLk+Qgyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogLV5-000SJS-5B; Thu, 06 Oct 2022 07:40:59 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogLV0-000SGp-A1 for linux-arm-kernel@lists.infradead.org; Thu, 06 Oct 2022 07:40:57 +0000 Received: by mail-wr1-x433.google.com with SMTP id u10so1337238wrq.2 for ; Thu, 06 Oct 2022 00:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=czZIXcSril+0S5W4kqc0onDmBGjrVJmOKnFUKeX4tsk=; b=6qjVyGLzJP2d40EpuWNyVT7l6T1hqaLdgmVpPaEvxGoI3eNCRgjZbGBoV/FQXGFiob p1/snStTlv9rq/9KQBEnbttDzx9aV9UFcCtCpTruw0x3LnutL5LIoByYqspkjd4myhFG o66132ZmNOgdoO+IlS/KPAboWUZ4rxmqEi5tZR2IqESw7F5zea9zC2XndyD0QwNfiMW+ /nwbOLPLYFu+/Cky/cDEFK7gRRN0k+BrwlpQEh4ZaKLwj5dIr4NcKkO8p5HwaacjzsA6 gZ0TzxilJw76mVoMKbn+T6w4zrLCe+y6EPNId2yu4f5oz1jz2r47ME95GEpCEBO05Q/r AVKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=czZIXcSril+0S5W4kqc0onDmBGjrVJmOKnFUKeX4tsk=; b=mAkvd2bjrOaYcmrzU8AdzcaVyf5nthnlsV5lAJbDyTHukaOfTnGJSEqUXn+xDJPsQH Ps4GdEOFt8ae0kdLLrqNZclXBsCZaWZk/Vfq0q5dkzsZ528phDpxfxx8T660fVZPTNAo Hs6syE4I6bgZpSHMX/baHDx+6FxakUZ7dtBLJNYYCnOUf8EZtQ3Q3Xo7xjQkF0+EvTJS DHCAOskjz6A9EPN1xbSjJnXXQNSyfXPgpEWmvoCAFtH5Ipl8/Kgx4f1hTedukE15BBgH Mw/YUBdIkqAexeBCA2RpMxn0x8SOQWfnxI8aRxFXGVvS3tiuDRdvJCTgaqfgDYetIgtY neXw== X-Gm-Message-State: ACrzQf2vCRekts60i4AP+3f2SyX/wDoXth//NZVTY9xEvETRAaBqaTLz m8/EpThPyFadnGaI85PMKFYbYg== X-Google-Smtp-Source: AMsMyM6xxcX+Jw879ZvGrzE2zvbkaNBbDJ39qRVbXxY0XUtG9zHNqjzwrFb8JpJ5s9D9VO54lzi4fg== X-Received: by 2002:a5d:404b:0:b0:22e:331e:1cba with SMTP id w11-20020a5d404b000000b0022e331e1cbamr2019320wrp.488.1665042051756; Thu, 06 Oct 2022 00:40:51 -0700 (PDT) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c190600b003a601a1c2f7sm4346819wmq.19.2022.10.06.00.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 00:40:51 -0700 (PDT) From: Mattijs Korpershoek To: Alexandre Mergnat , Lee Jones , Mark Brown , Matthias Brugger , Rob Herring , Liam Girdwood , Krzysztof Kozlowski , Dmitry Torokhov , Chen Zhong Cc: linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent , Alexandre Mergnat Subject: Re: [PATCH v2 5/5] Input: mtk-pmic-keys: add MT6357 support In-Reply-To: <20221005-mt6357-support-v2-5-f17ba2d2d0a9@baylibre.com> References: <20221005-mt6357-support-v2-0-f17ba2d2d0a9@baylibre.com> <20221005-mt6357-support-v2-5-f17ba2d2d0a9@baylibre.com> Date: Thu, 06 Oct 2022 09:40:50 +0200 Message-ID: <87czb5o0vx.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221006_004054_559375_06722F84 X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 05, 2022 at 16:57, Alexandre Mergnat wrote: > From: Fabien Parent > > Add PMIC Keys support on MT6357 SoC. > > Signed-off-by: Fabien Parent > Signed-off-by: Alexandre Mergnat Reviewed-by: Mattijs Korpershoek > --- > drivers/input/keyboard/mtk-pmic-keys.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c > index 9b34da0ec260..2a63e0718eb6 100644 > --- a/drivers/input/keyboard/mtk-pmic-keys.c > +++ b/drivers/input/keyboard/mtk-pmic-keys.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -90,6 +91,19 @@ static const struct mtk_pmic_regs mt6331_regs = { > .rst_lprst_mask = MTK_PMIC_MT6331_RST_DU_MASK, > }; > > +static const struct mtk_pmic_regs mt6357_regs = { > + .keys_regs[MTK_PMIC_PWRKEY_INDEX] = > + MTK_PMIC_KEYS_REGS(MT6357_TOPSTATUS, > + 0x2, MT6357_PSC_TOP_INT_CON0, 0x5, > + MTK_PMIC_PWRKEY_RST), > + .keys_regs[MTK_PMIC_HOMEKEY_INDEX] = > + MTK_PMIC_KEYS_REGS(MT6357_TOPSTATUS, > + 0x8, MT6357_PSC_TOP_INT_CON0, 0xa, > + MTK_PMIC_HOMEKEY_INDEX), > + .pmic_rst_reg = MT6357_TOP_RST_MISC, > + .rst_lprst_mask = MTK_PMIC_RST_DU_MASK, > +}; > + > static const struct mtk_pmic_regs mt6358_regs = { > .keys_regs[MTK_PMIC_PWRKEY_INDEX] = > MTK_PMIC_KEYS_REGS(MT6358_TOPSTATUS, > @@ -276,6 +290,9 @@ static const struct of_device_id of_mtk_pmic_keys_match_tbl[] = { > }, { > .compatible = "mediatek,mt6331-keys", > .data = &mt6331_regs, > + }, { > + .compatible = "mediatek,mt6357-keys", > + .data = &mt6357_regs, > }, { > .compatible = "mediatek,mt6358-keys", > .data = &mt6358_regs, > > -- > b4 0.10.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel