From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79765C433F5 for ; Wed, 27 Apr 2022 20:50:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE9E210E501; Wed, 27 Apr 2022 20:50:20 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFEEB10E501 for ; Wed, 27 Apr 2022 20:50:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651092619; x=1682628619; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=NZrbxGh3ldcVEXIaLgVJNol6vNIh/8wJ2xQWYOSbDpo=; b=GGI7p7FiRWJWvyLT+xXaTsYJVpkSrqjbE4rZlcNdXQqWGXSoQN+vrLeI m0dFzg8sGtLDsMBzDyHh5kDUxjwYB8ccvRDXCu9ncg1Mm+65Hlwh9IdNX nxBb1uxUKNAO1TKjla5dT4VSb9iRfdXwPqZ6Kl1zFXYkTgEstteJ+OXZW hXbCikiyinyKljsDwGwd+WgKtBP7JQu51qu2OjhUZjrKeeYmIMQM8rU3q ropGtlVWjDM5FOyBgweZhzefkswTU5Xfz/K+dtkfEJUXpFgEY8LvEcuWO KqusYHQaeCOhxC/OSUM8KFSKDervA5Q9hmZJ67E5liN1Bsyin98E37evi g==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="245985187" X-IronPort-AV: E=Sophos;i="5.90,294,1643702400"; d="scan'208";a="245985187" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 13:50:18 -0700 X-IronPort-AV: E=Sophos;i="5.90,294,1643702400"; d="scan'208";a="681084182" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.232.118]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 13:50:18 -0700 Date: Wed, 27 Apr 2022 13:50:18 -0700 Message-ID: <87czh25jzp.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Andi Shyti In-Reply-To: References: <9ed5af1177ad08c7c2d9c5d9b32ab0154dbd950f.1650435571.git.ashutosh.dixit@intel.com> <87o80n61ft.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 27 Apr 2022 04:45:03 -0700, Andi Shyti wrote: > > Hi Ashutosh, Hi Andi, > > > > -static struct kobj_type kobj_gt_type = { > > > > - .release = kobj_gt_release, > > > > +static struct kobj_type kobj_gtn_type = { > > > > > > what does it mean GTN? Or is it GTn? Please use just GT, gtn is > > > confusing. > > > > > > Same for all the rest of the gtn's you have used below. > > > > I didn't like gtn either. But a sysfs_gt kobject is already part of 'struct > > drm_i915_private' so I thought I'll put sysfs_gtn (for gt/gtN) in 'struct > > intel_gt'. Otherwise browsing the code etc. gets confusing. > > we can even use 'gt_n' if the 'n' is really necessary. I decided to just go with sysfs_gt in v2 as you had suggested. The total number of instances of sysfs_gt are very few so it didn't seem too bad to have the same member name in the two struct's. Thanks. -- Ashutosh