From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B0ADC433EF for ; Fri, 1 Apr 2022 08:09:39 +0000 (UTC) Received: from localhost ([::1]:56350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naCLh-0006EV-VN for qemu-devel@archiver.kernel.org; Fri, 01 Apr 2022 04:09:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naCGB-00032z-AC for qemu-devel@nongnu.org; Fri, 01 Apr 2022 04:03:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naCG9-0004mF-PQ for qemu-devel@nongnu.org; Fri, 01 Apr 2022 04:03:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648800233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+DdDfAfgWtQI8b5DrBgtKwDGM/TBPeedvyLrxvsODg0=; b=b9c+EesLtfP/fKDZN4stdIGLft7ECYr83Edaopf8clVeqMHlZH67tbQRNYQEY+AD/rSqS2 fT9r08EQ4b43KmORGS5QjKl30f4QM3EE/D8fwfYVzxPJReEe+Jph068wI9hNBhVtYHCkjQ IMJAdpIS3GEovqO/2qSNaSfC5Pe4U0I= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-604-fmigbUvsMN2zxb1eqbHABg-1; Fri, 01 Apr 2022 04:03:52 -0400 X-MC-Unique: fmigbUvsMN2zxb1eqbHABg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E22EE280523E for ; Fri, 1 Apr 2022 08:03:51 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 647915E1A5F; Fri, 1 Apr 2022 08:03:51 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3CAAB21E691D; Fri, 1 Apr 2022 10:03:47 +0200 (CEST) From: Markus Armbruster To: Victor Toso Subject: Re: [PATCH v1 5/9] qapi: fix example of query-vnc command References: <20220331190633.121077-1-victortoso@redhat.com> <20220331190633.121077-6-victortoso@redhat.com> Date: Fri, 01 Apr 2022 10:03:47 +0200 In-Reply-To: <20220331190633.121077-6-victortoso@redhat.com> (Victor Toso's message of "Thu, 31 Mar 2022 21:06:29 +0200") Message-ID: <87czi1b57g.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Victor Toso writes: > The return value is missing the mandatory member @websocket. Fix it. > > Signed-off-by: Victor Toso > --- > qapi/ui.json | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qapi/ui.json b/qapi/ui.json > index c039b8b3cb..13a8bb82aa 100644 > --- a/qapi/ui.json > +++ b/qapi/ui.json > @@ -658,6 +658,7 @@ > # "host":"127.0.0.1", > # "service":"50401", > # "family":"ipv4" > +# "websocket":false, > # } > # ] > # } Reviewed-by: Markus Armbruster