All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 0/7] drm/i915: include reductions
@ 2021-12-09 13:50 Jani Nikula
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include Jani Nikula
                   ` (8 more replies)
  0 siblings, 9 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 13:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Remove some useless includes as well as ones that can be removed with
trivial changes.

Jani Nikula (7):
  drm/i915/reset: remove useless intel_display_types.h include
  drm/i915/active: remove useless i915_utils.h include
  drm/i915/psr: avoid intel_frontbuffer.h include with declaration
  drm/i915/fbc: avoid intel_frontbuffer.h include with declaration
  drm/i915/fb: reduce include dependencies
  drm/i915/pxp: un-inline intel_pxp_is_enabled()
  drm/i915/pxp: remove useless includes

 drivers/gpu/drm/i915/display/intel_fbc.h         |  3 +--
 drivers/gpu/drm/i915/display/intel_frontbuffer.h |  2 +-
 drivers/gpu/drm/i915/display/intel_psr.h         | 11 ++++++-----
 drivers/gpu/drm/i915/gt/intel_reset.c            |  1 -
 drivers/gpu/drm/i915/i915_active_types.h         |  2 --
 drivers/gpu/drm/i915/pxp/intel_pxp.c             |  5 +++++
 drivers/gpu/drm/i915/pxp/intel_pxp.h             | 14 ++++++++------
 drivers/gpu/drm/i915/pxp/intel_pxp_types.h       |  2 --
 8 files changed, 21 insertions(+), 19 deletions(-)

-- 
2.30.2


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
@ 2021-12-09 13:50 ` Jani Nikula
  2021-12-09 17:29   ` Ville Syrjälä
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 2/7] drm/i915/active: remove useless i915_utils.h include Jani Nikula
                   ` (7 subsequent siblings)
  8 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 13:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Not needed.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_reset.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
index 63199f0550e6..b8ac454f2d96 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -6,7 +6,6 @@
 #include <linux/sched/mm.h>
 #include <linux/stop_machine.h>
 
-#include "display/intel_display_types.h"
 #include "display/intel_overlay.h"
 
 #include "gem/i915_gem_context.h"
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 2/7] drm/i915/active: remove useless i915_utils.h include
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include Jani Nikula
@ 2021-12-09 13:50 ` Jani Nikula
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 3/7] drm/i915/psr: avoid intel_frontbuffer.h include with declaration Jani Nikula
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 13:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Not needed.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_active_types.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_active_types.h b/drivers/gpu/drm/i915/i915_active_types.h
index c149f348a972..b02a78ac87db 100644
--- a/drivers/gpu/drm/i915/i915_active_types.h
+++ b/drivers/gpu/drm/i915/i915_active_types.h
@@ -15,8 +15,6 @@
 #include <linux/rcupdate.h>
 #include <linux/workqueue.h>
 
-#include "i915_utils.h"
-
 struct i915_active_fence {
 	struct dma_fence __rcu *fence;
 	struct dma_fence_cb cb;
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 3/7] drm/i915/psr: avoid intel_frontbuffer.h include with declaration
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include Jani Nikula
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 2/7] drm/i915/active: remove useless i915_utils.h include Jani Nikula
@ 2021-12-09 13:50 ` Jani Nikula
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 4/7] drm/i915/fbc: " Jani Nikula
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 13:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Reduce include dependencies using forward declarations.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/i915/display/intel_psr.h
index 3d9c0e13c329..f6526d9ccfdc 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.h
+++ b/drivers/gpu/drm/i915/display/intel_psr.h
@@ -6,18 +6,19 @@
 #ifndef __INTEL_PSR_H__
 #define __INTEL_PSR_H__
 
-#include "intel_frontbuffer.h"
+#include <linux/types.h>
 
+enum fb_op_origin;
 struct drm_connector;
 struct drm_connector_state;
 struct drm_i915_private;
+struct intel_atomic_state;
+struct intel_crtc;
 struct intel_crtc_state;
 struct intel_dp;
-struct intel_crtc;
-struct intel_atomic_state;
-struct intel_plane_state;
-struct intel_plane;
 struct intel_encoder;
+struct intel_plane;
+struct intel_plane_state;
 
 void intel_psr_init_dpcd(struct intel_dp *intel_dp);
 void intel_psr_pre_plane_update(struct intel_atomic_state *state,
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 4/7] drm/i915/fbc: avoid intel_frontbuffer.h include with declaration
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
                   ` (2 preceding siblings ...)
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 3/7] drm/i915/psr: avoid intel_frontbuffer.h include with declaration Jani Nikula
@ 2021-12-09 13:50 ` Jani Nikula
  2021-12-09 13:51 ` [Intel-gfx] [PATCH 5/7] drm/i915/fb: reduce include dependencies Jani Nikula
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 13:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Reduce include dependencies using forward declarations.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbc.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbc.h b/drivers/gpu/drm/i915/display/intel_fbc.h
index b8d9cda85cfc..07ad0411fcc3 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.h
+++ b/drivers/gpu/drm/i915/display/intel_fbc.h
@@ -8,8 +8,7 @@
 
 #include <linux/types.h>
 
-#include "intel_frontbuffer.h"
-
+enum fb_op_origin;
 struct drm_i915_private;
 struct intel_atomic_state;
 struct intel_crtc;
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 5/7] drm/i915/fb: reduce include dependencies
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
                   ` (3 preceding siblings ...)
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 4/7] drm/i915/fbc: " Jani Nikula
@ 2021-12-09 13:51 ` Jani Nikula
  2021-12-09 13:51 ` [Intel-gfx] [PATCH 6/7] drm/i915/pxp: un-inline intel_pxp_is_enabled() Jani Nikula
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 13:51 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

We actually need i915_active_types.h, not i915_active.h.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_frontbuffer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.h b/drivers/gpu/drm/i915/display/intel_frontbuffer.h
index a88441edc8f9..ff0c37b079aa 100644
--- a/drivers/gpu/drm/i915/display/intel_frontbuffer.h
+++ b/drivers/gpu/drm/i915/display/intel_frontbuffer.h
@@ -28,7 +28,7 @@
 #include <linux/kref.h>
 
 #include "gem/i915_gem_object_types.h"
-#include "i915_active.h"
+#include "i915_active_types.h"
 
 struct drm_i915_private;
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 6/7] drm/i915/pxp: un-inline intel_pxp_is_enabled()
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
                   ` (4 preceding siblings ...)
  2021-12-09 13:51 ` [Intel-gfx] [PATCH 5/7] drm/i915/fb: reduce include dependencies Jani Nikula
@ 2021-12-09 13:51 ` Jani Nikula
  2021-12-09 13:51 ` [Intel-gfx] [PATCH 7/7] drm/i915/pxp: remove useless includes Jani Nikula
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 13:51 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

In the interest of reducing include dependencies, un-inline
intel_pxp_is_enabled().

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/pxp/intel_pxp.c |  5 +++++
 drivers/gpu/drm/i915/pxp/intel_pxp.h | 14 ++++++++------
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c
index e2314ad9546d..15311eaed848 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp.c
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c
@@ -44,6 +44,11 @@ struct intel_gt *pxp_to_gt(const struct intel_pxp *pxp)
 	return container_of(pxp, struct intel_gt, pxp);
 }
 
+bool intel_pxp_is_enabled(const struct intel_pxp *pxp)
+{
+	return pxp->ce;
+}
+
 bool intel_pxp_is_active(const struct intel_pxp *pxp)
 {
 	return pxp->arb_is_valid;
diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.h b/drivers/gpu/drm/i915/pxp/intel_pxp.h
index aa262258d4d4..f9999ca8a6f1 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp.h
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp.h
@@ -6,17 +6,14 @@
 #ifndef __INTEL_PXP_H__
 #define __INTEL_PXP_H__
 
-#include "intel_pxp_types.h"
+#include <linux/types.h>
 
+struct intel_pxp;
 struct drm_i915_gem_object;
 
-static inline bool intel_pxp_is_enabled(const struct intel_pxp *pxp)
-{
-	return pxp->ce;
-}
-
 #ifdef CONFIG_DRM_I915_PXP
 struct intel_gt *pxp_to_gt(const struct intel_pxp *pxp);
+bool intel_pxp_is_enabled(const struct intel_pxp *pxp);
 bool intel_pxp_is_active(const struct intel_pxp *pxp);
 
 void intel_pxp_init(struct intel_pxp *pxp);
@@ -48,6 +45,11 @@ static inline int intel_pxp_start(struct intel_pxp *pxp)
 	return -ENODEV;
 }
 
+static inline bool intel_pxp_is_enabled(const struct intel_pxp *pxp)
+{
+	return false;
+}
+
 static inline bool intel_pxp_is_active(const struct intel_pxp *pxp)
 {
 	return false;
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 7/7] drm/i915/pxp: remove useless includes
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
                   ` (5 preceding siblings ...)
  2021-12-09 13:51 ` [Intel-gfx] [PATCH 6/7] drm/i915/pxp: un-inline intel_pxp_is_enabled() Jani Nikula
@ 2021-12-09 13:51 ` Jani Nikula
  2021-12-09 17:32 ` [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Ville Syrjälä
  2021-12-10  2:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
  8 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 13:51 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Not needed.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_types.h b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
index 73ef7d1754e1..7ce5f37ee12e 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h
@@ -7,9 +7,7 @@
 #define __INTEL_PXP_TYPES_H__
 
 #include <linux/completion.h>
-#include <linux/list.h>
 #include <linux/mutex.h>
-#include <linux/spinlock.h>
 #include <linux/types.h>
 #include <linux/workqueue.h>
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include
  2021-12-09 13:50 ` [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include Jani Nikula
@ 2021-12-09 17:29   ` Ville Syrjälä
  2021-12-09 19:17     ` Jani Nikula
  0 siblings, 1 reply; 13+ messages in thread
From: Ville Syrjälä @ 2021-12-09 17:29 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Thu, Dec 09, 2021 at 03:50:56PM +0200, Jani Nikula wrote:
> Not needed.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_reset.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
> index 63199f0550e6..b8ac454f2d96 100644
> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> @@ -6,7 +6,6 @@
>  #include <linux/sched/mm.h>
>  #include <linux/stop_machine.h>
>  
> -#include "display/intel_display_types.h"

intel_display_{prepare,finish}_reset() are in intel_display.h
so I'm thinking that is what we want to include here. I guess
atm it gets included via some more circuitous route?

>  #include "display/intel_overlay.h"
>  
>  #include "gem/i915_gem_context.h"
> -- 
> 2.30.2

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH 0/7] drm/i915: include reductions
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
                   ` (6 preceding siblings ...)
  2021-12-09 13:51 ` [Intel-gfx] [PATCH 7/7] drm/i915/pxp: remove useless includes Jani Nikula
@ 2021-12-09 17:32 ` Ville Syrjälä
  2021-12-10  2:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
  8 siblings, 0 replies; 13+ messages in thread
From: Ville Syrjälä @ 2021-12-09 17:32 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Thu, Dec 09, 2021 at 03:50:55PM +0200, Jani Nikula wrote:
> Remove some useless includes as well as ones that can be removed with
> trivial changes.
> 
> Jani Nikula (7):
>   drm/i915/reset: remove useless intel_display_types.h include
>   drm/i915/active: remove useless i915_utils.h include
>   drm/i915/psr: avoid intel_frontbuffer.h include with declaration
>   drm/i915/fbc: avoid intel_frontbuffer.h include with declaration
>   drm/i915/fb: reduce include dependencies
>   drm/i915/pxp: un-inline intel_pxp_is_enabled()
>   drm/i915/pxp: remove useless includes

Apart from the slight display reset stuff oddness this all
looks good.

Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
>  drivers/gpu/drm/i915/display/intel_fbc.h         |  3 +--
>  drivers/gpu/drm/i915/display/intel_frontbuffer.h |  2 +-
>  drivers/gpu/drm/i915/display/intel_psr.h         | 11 ++++++-----
>  drivers/gpu/drm/i915/gt/intel_reset.c            |  1 -
>  drivers/gpu/drm/i915/i915_active_types.h         |  2 --
>  drivers/gpu/drm/i915/pxp/intel_pxp.c             |  5 +++++
>  drivers/gpu/drm/i915/pxp/intel_pxp.h             | 14 ++++++++------
>  drivers/gpu/drm/i915/pxp/intel_pxp_types.h       |  2 --
>  8 files changed, 21 insertions(+), 19 deletions(-)
> 
> -- 
> 2.30.2

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include
  2021-12-09 17:29   ` Ville Syrjälä
@ 2021-12-09 19:17     ` Jani Nikula
  0 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-09 19:17 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

On Thu, 09 Dec 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Dec 09, 2021 at 03:50:56PM +0200, Jani Nikula wrote:
>> Not needed.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/gt/intel_reset.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
>> index 63199f0550e6..b8ac454f2d96 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
>> @@ -6,7 +6,6 @@
>>  #include <linux/sched/mm.h>
>>  #include <linux/stop_machine.h>
>>  
>> -#include "display/intel_display_types.h"
>
> intel_display_{prepare,finish}_reset() are in intel_display.h
> so I'm thinking that is what we want to include here. I guess
> atm it gets included via some more circuitous route?

Mmmh, all roads lead to i915_drv.h...

We should trim the includes in i915_drv.h a *lot* too. Make it purely
about defining struct drm_i915_private, not about including the world.

It's just that especially the gem/gt headers include just about
everything.

BR,
Jani.


>
>>  #include "display/intel_overlay.h"
>>  
>>  #include "gem/i915_gem_context.h"
>> -- 
>> 2.30.2

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: include reductions
  2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
                   ` (7 preceding siblings ...)
  2021-12-09 17:32 ` [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Ville Syrjälä
@ 2021-12-10  2:15 ` Patchwork
  2021-12-10 13:03   ` Jani Nikula
  8 siblings, 1 reply; 13+ messages in thread
From: Patchwork @ 2021-12-10  2:15 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: include reductions
URL   : https://patchwork.freedesktop.org/series/97789/
State : failure

== Summary ==

CALL    scripts/checksyscalls.sh
  CALL    scripts/atomic/check-atomics.sh
  DESCEND objtool
  CHK     include/generated/compile.h
  CC [M]  drivers/gpu/drm/i915/gem/i915_gem_create.o
In file included from drivers/gpu/drm/i915/gem/i915_gem_create.c:9:
./drivers/gpu/drm/i915/pxp/intel_pxp.h: In function ‘intel_pxp_start’:
./drivers/gpu/drm/i915/pxp/intel_pxp.h:45:10: error: ‘ENODEV’ undeclared (first use in this function)
  return -ENODEV;
          ^~~~~~
./drivers/gpu/drm/i915/pxp/intel_pxp.h:45:10: note: each undeclared identifier is reported only once for each function it appears in
./drivers/gpu/drm/i915/pxp/intel_pxp.h: In function ‘intel_pxp_key_check’:
./drivers/gpu/drm/i915/pxp/intel_pxp.h:62:10: error: ‘ENODEV’ undeclared (first use in this function)
  return -ENODEV;
          ^~~~~~
scripts/Makefile.build:287: recipe for target 'drivers/gpu/drm/i915/gem/i915_gem_create.o' failed
make[4]: *** [drivers/gpu/drm/i915/gem/i915_gem_create.o] Error 1
scripts/Makefile.build:549: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:549: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:549: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1846: recipe for target 'drivers' failed
make: *** [drivers] Error 2



^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [Intel-gfx]  ✗ Fi.CI.BUILD: failure for drm/i915: include reductions
  2021-12-10  2:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
@ 2021-12-10 13:03   ` Jani Nikula
  0 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2021-12-10 13:03 UTC (permalink / raw)
  To: Patchwork; +Cc: intel-gfx

On Fri, 10 Dec 2021, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915: include reductions
> URL   : https://patchwork.freedesktop.org/series/97789/
> State : failure
>
> == Summary ==
>
> CALL    scripts/checksyscalls.sh
>   CALL    scripts/atomic/check-atomics.sh
>   DESCEND objtool
>   CHK     include/generated/compile.h
>   CC [M]  drivers/gpu/drm/i915/gem/i915_gem_create.o
> In file included from drivers/gpu/drm/i915/gem/i915_gem_create.c:9:
> ./drivers/gpu/drm/i915/pxp/intel_pxp.h: In function ‘intel_pxp_start’:
> ./drivers/gpu/drm/i915/pxp/intel_pxp.h:45:10: error: ‘ENODEV’ undeclared (first use in this function)
>   return -ENODEV;
>           ^~~~~~
> ./drivers/gpu/drm/i915/pxp/intel_pxp.h:45:10: note: each undeclared identifier is reported only once for each function it appears in
> ./drivers/gpu/drm/i915/pxp/intel_pxp.h: In function ‘intel_pxp_key_check’:
> ./drivers/gpu/drm/i915/pxp/intel_pxp.h:62:10: error: ‘ENODEV’ undeclared (first use in this function)
>   return -ENODEV;
>           ^~~~~~
> scripts/Makefile.build:287: recipe for target 'drivers/gpu/drm/i915/gem/i915_gem_create.o' failed
> make[4]: *** [drivers/gpu/drm/i915/gem/i915_gem_create.o] Error 1
> scripts/Makefile.build:549: recipe for target 'drivers/gpu/drm/i915' failed
> make[3]: *** [drivers/gpu/drm/i915] Error 2
> scripts/Makefile.build:549: recipe for target 'drivers/gpu/drm' failed
> make[2]: *** [drivers/gpu/drm] Error 2
> scripts/Makefile.build:549: recipe for target 'drivers/gpu' failed
> make[1]: *** [drivers/gpu] Error 2
> Makefile:1846: recipe for target 'drivers' failed
> make: *** [drivers] Error 2

I guess this means we have CONFIG_DRM_I915_PXP=n in CI.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-12-10 13:03 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 13:50 [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Jani Nikula
2021-12-09 13:50 ` [Intel-gfx] [PATCH 1/7] drm/i915/reset: remove useless intel_display_types.h include Jani Nikula
2021-12-09 17:29   ` Ville Syrjälä
2021-12-09 19:17     ` Jani Nikula
2021-12-09 13:50 ` [Intel-gfx] [PATCH 2/7] drm/i915/active: remove useless i915_utils.h include Jani Nikula
2021-12-09 13:50 ` [Intel-gfx] [PATCH 3/7] drm/i915/psr: avoid intel_frontbuffer.h include with declaration Jani Nikula
2021-12-09 13:50 ` [Intel-gfx] [PATCH 4/7] drm/i915/fbc: " Jani Nikula
2021-12-09 13:51 ` [Intel-gfx] [PATCH 5/7] drm/i915/fb: reduce include dependencies Jani Nikula
2021-12-09 13:51 ` [Intel-gfx] [PATCH 6/7] drm/i915/pxp: un-inline intel_pxp_is_enabled() Jani Nikula
2021-12-09 13:51 ` [Intel-gfx] [PATCH 7/7] drm/i915/pxp: remove useless includes Jani Nikula
2021-12-09 17:32 ` [Intel-gfx] [PATCH 0/7] drm/i915: include reductions Ville Syrjälä
2021-12-10  2:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2021-12-10 13:03   ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.