From: Felipe Balbi <balbi@kernel.org>
To: Shubhrajyoti Datta <shubhraj@xilinx.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Michal Simek <michals@xilinx.com>, git <git@xilinx.com>
Subject: Re: [PATCH] usb: gadget: udc-xilinx: Add clock support
Date: Fri, 17 Sep 2021 17:27:36 +0300 [thread overview]
Message-ID: <87czp79szw.fsf@kernel.org> (raw)
In-Reply-To: <MN2PR02MB66409E4F304BE48BBB76A2D0AADD9@MN2PR02MB6640.namprd02.prod.outlook.com>
Hi,
Shubhrajyoti Datta <shubhraj@xilinx.com> writes:
>> -----Original Message-----
>> From: Felipe Balbi <balbi@kernel.org>
>> Sent: Wednesday, August 18, 2021 3:24 PM
>> To: Shubhrajyoti Datta <shubhraj@xilinx.com>
>> Cc: linux-usb@vger.kernel.org; gregkh@linuxfoundation.org; Michal Simek
>> <michals@xilinx.com>; git <git@xilinx.com>
>> Subject: Re: [PATCH] usb: gadget: udc-xilinx: Add clock support
>>
>>
>> Hi,
>>
>> Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> writes:
>> > Currently the driver depends on the bootloader to enable the clocks.
>> > Add support for clocking. The patch enables the clock at probe and
>> > disables them at remove.
>> >
>> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>> > ---
>> > drivers/usb/gadget/udc/udc-xilinx.c | 24 ++++++++++++++++++++++++
>> > 1 file changed, 24 insertions(+)
>> >
>> > diff --git a/drivers/usb/gadget/udc/udc-xilinx.c
>> > b/drivers/usb/gadget/udc/udc-xilinx.c
>> > index fb4ffedd6f0d..30070a488c87 100644
>> > --- a/drivers/usb/gadget/udc/udc-xilinx.c
>> > +++ b/drivers/usb/gadget/udc/udc-xilinx.c
>> > @@ -11,6 +11,7 @@
>> > * USB peripheral controller (at91_udc.c).
>> > */
>> >
>> > +#include <linux/clk.h>
>> > #include <linux/delay.h>
>> > #include <linux/device.h>
>> > #include <linux/dma-mapping.h>
>> > @@ -171,6 +172,7 @@ struct xusb_ep {
>> > * @addr: the usb device base address
>> > * @lock: instance of spinlock
>> > * @dma_enabled: flag indicating whether the dma is included in the
>> > system
>> > + * @clk: pointer to struct clk
>> > * @read_fn: function pointer to read device registers
>> > * @write_fn: function pointer to write to device registers
>> > */
>> > @@ -188,6 +190,7 @@ struct xusb_udc {
>> > void __iomem *addr;
>> > spinlock_t lock;
>> > bool dma_enabled;
>> > + struct clk *clk;
>> >
>> > unsigned int (*read_fn)(void __iomem *);
>> > void (*write_fn)(void __iomem *, u32, u32); @@ -2092,6 +2095,26 @@
>> > static int xudc_probe(struct platform_device *pdev)
>> > udc->gadget.ep0 = &udc->ep[XUSB_EP_NUMBER_ZERO].ep_usb;
>> > udc->gadget.name = driver_name;
>> >
>> > + udc->clk = devm_clk_get(&pdev->dev, "s_axi_aclk");
>> > + if (IS_ERR(udc->clk)) {
>> > + if (PTR_ERR(udc->clk) != -ENOENT) {
>> > + ret = PTR_ERR(udc->clk);
>> > + goto fail;
>> > + }
>> > +
>> > + /*
>> > + * Clock framework support is optional, continue on,
>> > + * anyways if we don't find a matching clock
>> > + */
>> > + udc->clk = NULL;
>>
>> should it be, though? Might be a good idea to add fixed-clock instances to the
>> boards still depending on clock framework. Maybe that can be done over time,
>> but worth considering anyhow.
>
> But for backward compatibility , I think it will be good to have the
> support instead of forcing the fixed-clock node.
you gotta explain that a little better. Care to do so?
--
balbi
next prev parent reply other threads:[~2021-09-17 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 9:47 [PATCH] usb: gadget: udc-xilinx: Add clock support Shubhrajyoti Datta
2021-08-18 9:50 ` Shubhrajyoti Datta
2021-08-18 9:54 ` Felipe Balbi
2021-09-17 9:44 ` Shubhrajyoti Datta
2021-09-17 14:27 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-03 6:28 shubhrajyoti.datta
2018-04-09 7:40 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czp79szw.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=shubhraj@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.