Re: [PATCH v2 0/2] s390x: improve subchannel error handling (vfio)

[Cornelia Huck <cohuck@redhat.com>]

On Wed, Aug 04 2021, Matthew Rosato <mjrosato@linux.ibm.com> wrote:

> On 8/4/21 8:30 PM, Jared Rossi wrote:
>> I've exercised the error paths and it appears to all work correctly.
>> 
>> On 7/19/21 11:09 AM, Jared Rossi wrote:
>>> I will take a look and see if I can exercise the error paths.
>>>
>>> Regards,
>>>
>>> Jared Rossi
>
> Thanks Jared!  So, with that I'd suggest a
>
> Tested-by: Jared Rossi <jrossi@linux.ibm.com>

I took the liberty to include that.

>
> and as I said earlier the code LGTM -- so for the series:
>
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>

Thanks to you both!

>
>>>
>>> On 7/19/21 10:16 AM, Matthew Rosato wrote:
>>>> On 7/5/21 12:39 PM, Cornelia Huck wrote:
>>>>> This is a followup on the first version (which I had sent out in May,
>>>>> and which kind of fell through the cracks.) While the first patch
>>>>> is mostly unchanged, I added a second patch to address some possible
>>>>> problems with the generated unit exceptions; non-vfio subchannels
>>>>> are not affected by this.
>>>>>
>>>>> As before, this works on the good path, and I have not managed to
>>>>> actually get my system to exercise the error path :(
>>>>
>>>> Sorry for the silence, was out of office for a bit and Eric is 
>>>> unavailable -- Anyway the code LGTM and matches what I see in the 
>>>> POPs, I'd be willing to ACK but I'd feel better if we could exercise 
>>>> the error paths before merging.
>>>>
>>>> @Jared/@Mike, you've both had eyes on this area of code recently, 
>>>> would one of you be willing to take a crack at a tested-by (non-zero 
>>>> CCs on HSCH/CSCH + also drive the sch_gen_unit_exception path)?
>>>>
>>>>>
>>>>> v1->v2:
>>>>> - add comments regarding -ENODEV/-EACCES handling
>>>>> - add second patch
>>>>>
>>>>> Cornelia Huck (2):
>>>>>    vfio-ccw: forward halt/clear errors
>>>>>    css: fix actl handling for unit exceptions
>>>>>
>>>>>   hw/s390x/css.c         | 38 ++++++++++++++++++++++++++++++++++----
>>>>>   hw/vfio/ccw.c          |  4 ++--
>>>>>   include/hw/s390x/css.h |  3 ++-
>>>>>   3 files changed, 38 insertions(+), 7 deletions(-)
>>>>>
>>>>

Queued to s390-next.