From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: imammedo@redhat.com, alex.williamson@redhat.com,
eblake@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] qapi/qom: use correct field name when getting/setting alias properties
Date: Tue, 20 Jul 2021 17:54:33 +0200 [thread overview]
Message-ID: <87czrddlqe.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210719104033.185109-1-pbonzini@redhat.com> (Paolo Bonzini's message of "Mon, 19 Jul 2021 12:40:31 +0200")
Running out of time for today, so I'm sending what I have, with real
review to follow.
First, let me describe what's wrong in my own words, because that's how
I understand stuff.
Reproducer (hidden behind the link to the bug tracker):
$ qemu-system-x86_64 \
-blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE.fd","node-name":"pflash0-storage","auto-read-only":true,"discard":"unmap"}' \
-blockdev '{"node-name":"pflash0-format","read-only":true,"driver":"raw","file":"pflash0-storage"}' \
-machine pc,pflash0=pflash0-format
The -machine gets (keyval-)parsed into a QDict, which is then processed
by object_set_properties_from_qdict() with the (keyval) QObject input
visitor. Makes sense.
object_set_properties_from_qdict() performs a virtual struct visit
guided by the QDict's keys. It calls object_property_set() for each
key.
For "pflash0", this calls object_property_set(obj, "pflash0", v, &err).
Since "pflash0" is a QOM alias property, this in turn calls
object_property_set(prop->target_obj, "drive0", v, &err), where prop is
the alias property, and prop->target_obj is the "cfi.pflash01" device.
Since "drive" is a drive property, this calls set_drive(), which calls
visit_type_str(v, "drive", &str, errp). Fails, because the QDict
wrapped in visitor @v does not have a "drive" member, it has a "pflash0"
member.
Next, the solution. I get the idea of a wrapper visitor which gives you
"pflash0" when you ask for "drive", but oh boy do I wish we could fix
the bug with a lot less code.
next prev parent reply other threads:[~2021-07-20 15:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 10:40 [PATCH 0/2] qapi/qom: use correct field name when getting/setting alias properties Paolo Bonzini
2021-07-19 10:40 ` [PATCH 1/2] qapi: introduce forwarding visitor Paolo Bonzini
2021-07-20 0:54 ` Eric Blake
2021-07-22 14:02 ` Markus Armbruster
2021-07-22 15:08 ` Paolo Bonzini
2021-07-22 15:34 ` Markus Armbruster
2021-07-23 9:49 ` Paolo Bonzini
2021-07-19 10:40 ` [PATCH 2/2] qom: use correct field name when getting/setting alias properties Paolo Bonzini
2021-07-19 11:51 ` Philippe Mathieu-Daudé
2021-07-20 1:00 ` Eric Blake
2021-07-21 9:51 ` Paolo Bonzini
2021-07-21 14:43 ` Markus Armbruster
2021-07-20 15:54 ` Markus Armbruster [this message]
2021-07-21 11:50 ` [PATCH 0/2] qapi/qom: " Paolo Bonzini
2021-07-22 13:25 ` Markus Armbruster
2021-07-22 13:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czrddlqe.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.