From: Marc Zyngier <maz@kernel.org>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
Andrew Scull <ascull@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Christoffer Dall <christoffer.dall@arm.com>,
Howard Zhang <Howard.Zhang@arm.com>, Jia He <justin.he@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Quentin Perret <qperret@google.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
"kernel-team@android.com" <kernel-team@android.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising GICv2-on-v3 compatibility
Date: Mon, 15 Mar 2021 14:36:33 +0000 [thread overview]
Message-ID: <87czw0fpqm.wl-maz@kernel.org> (raw)
In-Reply-To: <d38d4dc684f94221bdf5ca35b8f66cfc@huawei.com>
On Mon, 15 Mar 2021 12:55:42 +0000,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Marc Zyngier [mailto:maz@kernel.org]
> > Sent: 05 March 2021 18:53
> > To: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Alexandru Elisei <alexandru.elisei@arm.com>; Andre Przywara
> > <andre.przywara@arm.com>; Andrew Scull <ascull@google.com>; Catalin
> > Marinas <catalin.marinas@arm.com>; Christoffer Dall
> > <christoffer.dall@arm.com>; Howard Zhang <Howard.Zhang@arm.com>; Jia
> > He <justin.he@arm.com>; Mark Rutland <mark.rutland@arm.com>; Quentin
> > Perret <qperret@google.com>; Shameerali Kolothum Thodi
> > <shameerali.kolothum.thodi@huawei.com>; Suzuki K Poulose
> > <suzuki.poulose@arm.com>; Will Deacon <will@kernel.org>; James Morse
> > <james.morse@arm.com>; Julien Thierry <julien.thierry.kdev@gmail.com>;
> > kernel-team@android.com; linux-arm-kernel@lists.infradead.org;
> > kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org
> > Subject: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising
> > GICv2-on-v3 compatibility
> >
> > It looks like we have broken firmware out there that wrongly advertises
> > a GICv2 compatibility interface, despite the CPUs not being able to deal
> > with it.
> >
> > To work around this, check that the CPU initialising KVM is actually able
> > to switch to MMIO instead of system registers, and use that as a
> > precondition to enable GICv2 compatibility in KVM.
> >
> > Note that the detection happens on a single CPU. If the firmware is
> > lying *and* that the CPUs are asymetric, all hope is lost anyway.
> >
> > Reported-by: Shameerali Kolothum Thodi
> > <shameerali.kolothum.thodi@huawei.com>
> > Tested-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> Is it possible to add stable tag for this? Looks like we do have
> systems out there and reports issues.
It is already merged. Which kernel versions do you need that for? In
any case, please submit the backports, and I'll review them.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: "kernel-team@android.com" <kernel-team@android.com>,
Jia He <justin.he@arm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Howard Zhang <Howard.Zhang@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising GICv2-on-v3 compatibility
Date: Mon, 15 Mar 2021 14:36:33 +0000 [thread overview]
Message-ID: <87czw0fpqm.wl-maz@kernel.org> (raw)
In-Reply-To: <d38d4dc684f94221bdf5ca35b8f66cfc@huawei.com>
On Mon, 15 Mar 2021 12:55:42 +0000,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Marc Zyngier [mailto:maz@kernel.org]
> > Sent: 05 March 2021 18:53
> > To: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Alexandru Elisei <alexandru.elisei@arm.com>; Andre Przywara
> > <andre.przywara@arm.com>; Andrew Scull <ascull@google.com>; Catalin
> > Marinas <catalin.marinas@arm.com>; Christoffer Dall
> > <christoffer.dall@arm.com>; Howard Zhang <Howard.Zhang@arm.com>; Jia
> > He <justin.he@arm.com>; Mark Rutland <mark.rutland@arm.com>; Quentin
> > Perret <qperret@google.com>; Shameerali Kolothum Thodi
> > <shameerali.kolothum.thodi@huawei.com>; Suzuki K Poulose
> > <suzuki.poulose@arm.com>; Will Deacon <will@kernel.org>; James Morse
> > <james.morse@arm.com>; Julien Thierry <julien.thierry.kdev@gmail.com>;
> > kernel-team@android.com; linux-arm-kernel@lists.infradead.org;
> > kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org
> > Subject: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising
> > GICv2-on-v3 compatibility
> >
> > It looks like we have broken firmware out there that wrongly advertises
> > a GICv2 compatibility interface, despite the CPUs not being able to deal
> > with it.
> >
> > To work around this, check that the CPU initialising KVM is actually able
> > to switch to MMIO instead of system registers, and use that as a
> > precondition to enable GICv2 compatibility in KVM.
> >
> > Note that the detection happens on a single CPU. If the firmware is
> > lying *and* that the CPUs are asymetric, all hope is lost anyway.
> >
> > Reported-by: Shameerali Kolothum Thodi
> > <shameerali.kolothum.thodi@huawei.com>
> > Tested-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> Is it possible to add stable tag for this? Looks like we do have
> systems out there and reports issues.
It is already merged. Which kernel versions do you need that for? In
any case, please submit the backports, and I'll review them.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
Andrew Scull <ascull@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Christoffer Dall <christoffer.dall@arm.com>,
Howard Zhang <Howard.Zhang@arm.com>, Jia He <justin.he@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Quentin Perret <qperret@google.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
"kernel-team@android.com" <kernel-team@android.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising GICv2-on-v3 compatibility
Date: Mon, 15 Mar 2021 14:36:33 +0000 [thread overview]
Message-ID: <87czw0fpqm.wl-maz@kernel.org> (raw)
In-Reply-To: <d38d4dc684f94221bdf5ca35b8f66cfc@huawei.com>
On Mon, 15 Mar 2021 12:55:42 +0000,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Marc Zyngier [mailto:maz@kernel.org]
> > Sent: 05 March 2021 18:53
> > To: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Alexandru Elisei <alexandru.elisei@arm.com>; Andre Przywara
> > <andre.przywara@arm.com>; Andrew Scull <ascull@google.com>; Catalin
> > Marinas <catalin.marinas@arm.com>; Christoffer Dall
> > <christoffer.dall@arm.com>; Howard Zhang <Howard.Zhang@arm.com>; Jia
> > He <justin.he@arm.com>; Mark Rutland <mark.rutland@arm.com>; Quentin
> > Perret <qperret@google.com>; Shameerali Kolothum Thodi
> > <shameerali.kolothum.thodi@huawei.com>; Suzuki K Poulose
> > <suzuki.poulose@arm.com>; Will Deacon <will@kernel.org>; James Morse
> > <james.morse@arm.com>; Julien Thierry <julien.thierry.kdev@gmail.com>;
> > kernel-team@android.com; linux-arm-kernel@lists.infradead.org;
> > kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org
> > Subject: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising
> > GICv2-on-v3 compatibility
> >
> > It looks like we have broken firmware out there that wrongly advertises
> > a GICv2 compatibility interface, despite the CPUs not being able to deal
> > with it.
> >
> > To work around this, check that the CPU initialising KVM is actually able
> > to switch to MMIO instead of system registers, and use that as a
> > precondition to enable GICv2 compatibility in KVM.
> >
> > Note that the detection happens on a single CPU. If the firmware is
> > lying *and* that the CPUs are asymetric, all hope is lost anyway.
> >
> > Reported-by: Shameerali Kolothum Thodi
> > <shameerali.kolothum.thodi@huawei.com>
> > Tested-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> Is it possible to add stable tag for this? Looks like we do have
> systems out there and reports issues.
It is already merged. Which kernel versions do you need that for? In
any case, please submit the backports, and I'll review them.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-15 14:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 16:49 [GIT PULL] KVM/arm64 fixes for 5.12, take #1 Marc Zyngier
2021-03-05 16:49 ` Marc Zyngier
2021-03-05 16:49 ` Marc Zyngier
2021-03-05 17:27 ` Paolo Bonzini
2021-03-05 17:27 ` Paolo Bonzini
2021-03-05 17:27 ` Paolo Bonzini
2021-03-05 18:47 ` Marc Zyngier
2021-03-05 18:47 ` Marc Zyngier
2021-03-05 18:47 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 0/8] " Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 1/8] KVM: arm64: nvhe: Save the SPE context early Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 2/8] KVM: arm64: Avoid corrupting vCPU context register in guest exit Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 3/8] KVM: arm64: Fix nVHE hyp panic host context restore Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 4/8] KVM: arm64: Turn kvm_arm_support_pmu_v3() into a static key Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 5/8] KVM: arm64: Don't access PMSELR_EL0/PMUSERENR_EL0 when no PMU is available Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 6/8] KVM: arm64: Rename __vgic_v3_get_ich_vtr_el2() to __vgic_v3_get_gic_config() Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising GICv2-on-v3 compatibility Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-15 12:55 ` Shameerali Kolothum Thodi
2021-03-15 12:55 ` Shameerali Kolothum Thodi
2021-03-15 12:55 ` Shameerali Kolothum Thodi
2021-03-15 14:36 ` Marc Zyngier [this message]
2021-03-15 14:36 ` Marc Zyngier
2021-03-15 14:36 ` Marc Zyngier
2021-03-05 18:52 ` [PATCH 8/8] KVM: arm64: Fix range alignment when walking page tables Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-05 18:52 ` Marc Zyngier
2021-03-06 9:50 ` [PATCH 0/8] KVM/arm64 fixes for 5.12, take #1 Paolo Bonzini
2021-03-06 9:50 ` Paolo Bonzini
2021-03-06 9:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czw0fpqm.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Howard.Zhang@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=ascull@google.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=justin.he@arm.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pbonzini@redhat.com \
--cc=qperret@google.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.