From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA970C433DB for ; Mon, 15 Mar 2021 14:38:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE8D96502B for ; Mon, 15 Mar 2021 14:38:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237288AbhCOOg4 (ORCPT ); Mon, 15 Mar 2021 10:36:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:32822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236423AbhCOOgk (ORCPT ); Mon, 15 Mar 2021 10:36:40 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3788465012; Mon, 15 Mar 2021 14:36:39 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lLoKg-001hZH-Dt; Mon, 15 Mar 2021 14:36:36 +0000 Date: Mon, 15 Mar 2021 14:36:33 +0000 Message-ID: <87czw0fpqm.wl-maz@kernel.org> From: Marc Zyngier To: Shameerali Kolothum Thodi Cc: Paolo Bonzini , Alexandru Elisei , Andre Przywara , Andrew Scull , Catalin Marinas , Christoffer Dall , Howard Zhang , Jia He , Mark Rutland , Quentin Perret , Suzuki K Poulose , Will Deacon , James Morse , Julien Thierry , "kernel-team@android.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" Subject: Re: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising GICv2-on-v3 compatibility In-Reply-To: References: <87eegtzbch.wl-maz@kernel.org> <20210305185254.3730990-1-maz@kernel.org> <20210305185254.3730990-8-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: shameerali.kolothum.thodi@huawei.com, pbonzini@redhat.com, alexandru.elisei@arm.com, andre.przywara@arm.com, ascull@google.com, catalin.marinas@arm.com, christoffer.dall@arm.com, Howard.Zhang@arm.com, justin.he@arm.com, mark.rutland@arm.com, qperret@google.com, suzuki.poulose@arm.com, will@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 15 Mar 2021 12:55:42 +0000, Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Marc Zyngier [mailto:maz@kernel.org] > > Sent: 05 March 2021 18:53 > > To: Paolo Bonzini > > Cc: Alexandru Elisei ; Andre Przywara > > ; Andrew Scull ; Catalin > > Marinas ; Christoffer Dall > > ; Howard Zhang ; Jia > > He ; Mark Rutland ; Quentin > > Perret ; Shameerali Kolothum Thodi > > ; Suzuki K Poulose > > ; Will Deacon ; James Morse > > ; Julien Thierry ; > > kernel-team@android.com; linux-arm-kernel@lists.infradead.org; > > kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org > > Subject: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising > > GICv2-on-v3 compatibility > > > > It looks like we have broken firmware out there that wrongly advertises > > a GICv2 compatibility interface, despite the CPUs not being able to deal > > with it. > > > > To work around this, check that the CPU initialising KVM is actually able > > to switch to MMIO instead of system registers, and use that as a > > precondition to enable GICv2 compatibility in KVM. > > > > Note that the detection happens on a single CPU. If the firmware is > > lying *and* that the CPUs are asymetric, all hope is lost anyway. > > > > Reported-by: Shameerali Kolothum Thodi > > > > Tested-by: Shameer Kolothum > > Signed-off-by: Marc Zyngier > > Is it possible to add stable tag for this? Looks like we do have > systems out there and reports issues. It is already merged. Which kernel versions do you need that for? In any case, please submit the backports, and I'll review them. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20400C433DB for ; Mon, 15 Mar 2021 14:36:45 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C045364F69 for ; Mon, 15 Mar 2021 14:36:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C045364F69 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 778D94B527; Mon, 15 Mar 2021 10:36:44 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UhJbA0gUrKbW; Mon, 15 Mar 2021 10:36:43 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3A4F64B707; Mon, 15 Mar 2021 10:36:43 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F2D634B4E3 for ; Mon, 15 Mar 2021 10:36:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7BJ2KjJOCsSq for ; Mon, 15 Mar 2021 10:36:40 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 27A994B5D2 for ; Mon, 15 Mar 2021 10:36:40 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3788465012; Mon, 15 Mar 2021 14:36:39 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lLoKg-001hZH-Dt; Mon, 15 Mar 2021 14:36:36 +0000 Date: Mon, 15 Mar 2021 14:36:33 +0000 Message-ID: <87czw0fpqm.wl-maz@kernel.org> From: Marc Zyngier To: Shameerali Kolothum Thodi Subject: Re: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising GICv2-on-v3 compatibility In-Reply-To: References: <87eegtzbch.wl-maz@kernel.org> <20210305185254.3730990-1-maz@kernel.org> <20210305185254.3730990-8-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: shameerali.kolothum.thodi@huawei.com, pbonzini@redhat.com, alexandru.elisei@arm.com, andre.przywara@arm.com, ascull@google.com, catalin.marinas@arm.com, christoffer.dall@arm.com, Howard.Zhang@arm.com, justin.he@arm.com, mark.rutland@arm.com, qperret@google.com, suzuki.poulose@arm.com, will@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: "kernel-team@android.com" , Jia He , "kvm@vger.kernel.org" , Will Deacon , Catalin Marinas , Howard Zhang , Andre Przywara , Paolo Bonzini , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, 15 Mar 2021 12:55:42 +0000, Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Marc Zyngier [mailto:maz@kernel.org] > > Sent: 05 March 2021 18:53 > > To: Paolo Bonzini > > Cc: Alexandru Elisei ; Andre Przywara > > ; Andrew Scull ; Catalin > > Marinas ; Christoffer Dall > > ; Howard Zhang ; Jia > > He ; Mark Rutland ; Quentin > > Perret ; Shameerali Kolothum Thodi > > ; Suzuki K Poulose > > ; Will Deacon ; James Morse > > ; Julien Thierry ; > > kernel-team@android.com; linux-arm-kernel@lists.infradead.org; > > kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org > > Subject: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising > > GICv2-on-v3 compatibility > > > > It looks like we have broken firmware out there that wrongly advertises > > a GICv2 compatibility interface, despite the CPUs not being able to deal > > with it. > > > > To work around this, check that the CPU initialising KVM is actually able > > to switch to MMIO instead of system registers, and use that as a > > precondition to enable GICv2 compatibility in KVM. > > > > Note that the detection happens on a single CPU. If the firmware is > > lying *and* that the CPUs are asymetric, all hope is lost anyway. > > > > Reported-by: Shameerali Kolothum Thodi > > > > Tested-by: Shameer Kolothum > > Signed-off-by: Marc Zyngier > > Is it possible to add stable tag for this? Looks like we do have > systems out there and reports issues. It is already merged. Which kernel versions do you need that for? In any case, please submit the backports, and I'll review them. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DF6C433DB for ; Mon, 15 Mar 2021 14:48:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA77464EE5 for ; Mon, 15 Mar 2021 14:48:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA77464EE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UR1bORXTUbiTqYFkffk3a9jYifVgp5a+0aRxUDwlwRw=; b=hS2th4AKtV1GYowcc0i6D5s8F ht/K7VsBjVMou6k/fE3A5hjIkldnkyPE3C22NlmK/En7YexH7rsRg6bXNU1FYLFrrGK8qz5aSEZE5 H9DINqmuUBFWiiwE6dUIbmtkFsv+4bIxrX3Pb0AkGGK718uJs1xWEAgkjAbAnOQ1VII60bfoXaxlV YLiKLtQiMLlq/yQdkt0uKVQE6FeWrRyQVhWqy2qFAIMGtA8uCoh8Li3AfxifkeD1hDwXxOLOVw0wQ 5GNFwqd68V1f4/y7YZWzZDTOCaoZFeLNuN81Hh7ncQdMfPCvMFaA9SvmwwycE9sjfJ/S7EsGKspTo 03lFVEh3Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLoU8-00G9tf-OC; Mon, 15 Mar 2021 14:46:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLoKm-00G5yN-Jn for linux-arm-kernel@lists.infradead.org; Mon, 15 Mar 2021 14:36:44 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3788465012; Mon, 15 Mar 2021 14:36:39 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lLoKg-001hZH-Dt; Mon, 15 Mar 2021 14:36:36 +0000 Date: Mon, 15 Mar 2021 14:36:33 +0000 Message-ID: <87czw0fpqm.wl-maz@kernel.org> From: Marc Zyngier To: Shameerali Kolothum Thodi Cc: Paolo Bonzini , Alexandru Elisei , Andre Przywara , Andrew Scull , Catalin Marinas , Christoffer Dall , Howard Zhang , Jia He , Mark Rutland , Quentin Perret , Suzuki K Poulose , Will Deacon , James Morse , Julien Thierry , "kernel-team@android.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" Subject: Re: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising GICv2-on-v3 compatibility In-Reply-To: References: <87eegtzbch.wl-maz@kernel.org> <20210305185254.3730990-1-maz@kernel.org> <20210305185254.3730990-8-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: shameerali.kolothum.thodi@huawei.com, pbonzini@redhat.com, alexandru.elisei@arm.com, andre.przywara@arm.com, ascull@google.com, catalin.marinas@arm.com, christoffer.dall@arm.com, Howard.Zhang@arm.com, justin.he@arm.com, mark.rutland@arm.com, qperret@google.com, suzuki.poulose@arm.com, will@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_143641_183084_E700C12D X-CRM114-Status: GOOD ( 24.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 15 Mar 2021 12:55:42 +0000, Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Marc Zyngier [mailto:maz@kernel.org] > > Sent: 05 March 2021 18:53 > > To: Paolo Bonzini > > Cc: Alexandru Elisei ; Andre Przywara > > ; Andrew Scull ; Catalin > > Marinas ; Christoffer Dall > > ; Howard Zhang ; Jia > > He ; Mark Rutland ; Quentin > > Perret ; Shameerali Kolothum Thodi > > ; Suzuki K Poulose > > ; Will Deacon ; James Morse > > ; Julien Thierry ; > > kernel-team@android.com; linux-arm-kernel@lists.infradead.org; > > kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org > > Subject: [PATCH 7/8] KVM: arm64: Workaround firmware wrongly advertising > > GICv2-on-v3 compatibility > > > > It looks like we have broken firmware out there that wrongly advertises > > a GICv2 compatibility interface, despite the CPUs not being able to deal > > with it. > > > > To work around this, check that the CPU initialising KVM is actually able > > to switch to MMIO instead of system registers, and use that as a > > precondition to enable GICv2 compatibility in KVM. > > > > Note that the detection happens on a single CPU. If the firmware is > > lying *and* that the CPUs are asymetric, all hope is lost anyway. > > > > Reported-by: Shameerali Kolothum Thodi > > > > Tested-by: Shameer Kolothum > > Signed-off-by: Marc Zyngier > > Is it possible to add stable tag for this? Looks like we do have > systems out there and reports issues. It is already merged. Which kernel versions do you need that for? In any case, please submit the backports, and I'll review them. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel