All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/plg-utils: escape \ in generated legal-info
Date: Sun, 07 Feb 2021 13:18:02 +0100	[thread overview]
Message-ID: <87czxcysud.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210207112831.GK2384@scaer> (Yann E. MORIN's message of "Sun, 7 Feb 2021 12:28:31 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2021-02-07 10:35 +0100, Peter Korsgaard spake thusly:
 >> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
 >> I still wonder if it wouldn't be better to not have the backslashes in
 >> the variable and do whatever escaping is needed inside the CVE logic,

 > I think quite the opposite, in fact: we want the CPE_ID value to be
 > exactly what is in the NVD database without any mangling on our side.

 > The rules to encode the CPE stuff are non-trivial at least to me),
 > requiring some escaping/de-escaping in the various formats, and with
 > different rules for the attributes and their representation

 > All is defined in NISTIR 7695 [0], in the following chapters:
 >     5.3.2 - Restrictions on attribute-value strings
 >     6.2.1 - Syntax for Formatted String Binding

 > [0] https://doi.org/10.6028/NIST.IR.7695

Ok.

 >> but OK - We need a quick fix and this solves it.
 >> 
 >> Perhaps we should add a gitlab test to verify that we generate valid
 >> json, E.G. by piping it to jq (or similar).

 > Yeah, I'm working on it... But we can't do that in gitlab, because the
 > output of show-info depends on the selected packages, so it would have
 > to be done in the autobuilders.

But that then requires jq on the autobuilder. Can't we just do a 'make
allyespackageconfig' in gitlab?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2021-02-07 12:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06  8:51 [Buildroot] [PATCH] package/plg-utils: escape \ in generated legal-info Yann E. MORIN
2021-02-07  9:35 ` Peter Korsgaard
2021-02-07 11:28   ` Yann E. MORIN
2021-02-07 12:18     ` Peter Korsgaard [this message]
2021-02-07 13:17       ` Yann E. MORIN
2021-02-07 13:33       ` Yann E. MORIN
2021-02-07 14:21         ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czxcysud.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.