From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51E5AC84503 for ; Mon, 16 Nov 2020 12:38:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA42520855 for ; Mon, 16 Nov 2020 12:38:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="g2fsVRYW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729575AbgKPMSP (ORCPT ); Mon, 16 Nov 2020 07:18:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729498AbgKPMSO (ORCPT ); Mon, 16 Nov 2020 07:18:14 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E23C8C0613CF for ; Mon, 16 Nov 2020 04:18:13 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id h2so23551254wmm.0 for ; Mon, 16 Nov 2020 04:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=yW4WlOePZHathOl6u0xCp0KPZxooAIfjqYVblGZkMr0=; b=g2fsVRYWrR9L3djER+wkAkQA5aTRCWh1HZn5yEe4GXjpPSgArdMco0+PXPdg9Upq4P G5y2o5pZ6QRkxwJXP/1v9CVCycAgGuUjtIhpj3C4X6t+xOml4CUiy1ZWRatQB/enY6B0 7gdU+qrtWq1nwF5HakdBz3HDuYQoKAaoTEPNI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=yW4WlOePZHathOl6u0xCp0KPZxooAIfjqYVblGZkMr0=; b=jZZdHlCsBiNhNw7D7AxXisW8jC6yuPc/eLv0ONNNjGIthKRMQuZpuuHMrHQ78hVRl5 AUwWMjIfc6oaYG7xiFdM/5tE2eOou2oQQKpfexBdh+e5vwJ3KW/U6Zr3BlMWMmZ4YkvK r2qeWJPFXJ1KeAf1OSxcFSRlgpztbdmt65QBBjjIiNxoGsDW62237L8cvQK7BTHTprAX aECa4yC8MyYdDknCqteoA0UvlWaekl8tRXF5mutaYvZ7AAFgam5t2JcRcpyBcIMWZbPd 7h7Vn30NsAR2y0Mo6/KdF66bMyMy76uat5spjsvDO+p66W88cUVDY34k4Hy4YLv7RLmQ Casw== X-Gm-Message-State: AOAM530Z/bAZYPbuJTmUCvaIGRP+3m1lePDGaoFxt8AhzIwtYg9fCx5s 371oxleuY+YgC0RSNnRg1M3Awg== X-Google-Smtp-Source: ABdhPJzMhrCC4nxbbbMPElhBZTomSITDg73gwU2ccRtd3sDgEmEe9HJJpVW0QJagbRpeJWWMMLCyMA== X-Received: by 2002:a1c:750b:: with SMTP id o11mr12497572wmc.32.1605529092567; Mon, 16 Nov 2020 04:18:12 -0800 (PST) Received: from cloudflare.com ([2a02:a310:c262:aa00:b35e:8938:2c2a:ba8b]) by smtp.gmail.com with ESMTPSA id v19sm23551077wrf.40.2020.11.16.04.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 04:18:11 -0800 (PST) References: User-agent: mu4e 1.1.0; emacs 26.3 From: Jakub Sitnicki To: Santucci Pierpaolo Cc: shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andrii@kernel.org, john.fastabend@gmail.com, kpsingh@chromium.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2] selftest/bpf: fix IPV6FR handling in flow dissector In-reply-to: Date: Mon, 16 Nov 2020 13:18:10 +0100 Message-ID: <87d00dwl4t.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Nov 16, 2020 at 11:30 AM CET, Santucci Pierpaolo wrote: > From second fragment on, IPV6FR program must stop the dissection of IPV6 > fragmented packet. This is the same approach used for IPV4 fragmentation. > This fixes the flow keys calculation for the upper-layer protocols. > Note that according to RFC8200, the first fragment packet must include > the upper-layer header. > > Signed-off-by: Santucci Pierpaolo > --- > v2: extend the commit message, as suggested by John Fastabend > > > tools/testing/selftests/bpf/progs/bpf_flow.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/bpf/progs/bpf_flow.c b/tools/testing/selftests/bpf/progs/bpf_flow.c > index 5a65f6b51377..95a5a0778ed7 100644 > --- a/tools/testing/selftests/bpf/progs/bpf_flow.c > +++ b/tools/testing/selftests/bpf/progs/bpf_flow.c > @@ -368,6 +368,8 @@ PROG(IPV6FR)(struct __sk_buff *skb) > */ > if (!(keys->flags & BPF_FLOW_DISSECTOR_F_PARSE_1ST_FRAG)) > return export_flow_keys(keys, BPF_OK); > + } else { > + return export_flow_keys(keys, BPF_OK); > } > > return parse_ipv6_proto(skb, fragh->nexthdr); Reviewed-by: Jakub Sitnicki