From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D92FAC3F2D1 for ; Mon, 2 Mar 2020 00:30:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55B0D2468D for ; Mon, 2 Mar 2020 00:30:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rytuoqb4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55B0D2468D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A895B169F; Mon, 2 Mar 2020 01:29:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A895B169F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583109036; bh=+y9RNJHMicXC2WxnCXMB6+xU4rdWzboMzJk4KT2aCpM=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rytuoqb4FkxoM9PQMZOT5UCLYaTFBafT2wRrcaSCH1Og/3GNEiA0oNL/GW/J5ONJ+ tN1x6jmbYFLFB1btdBd0WaFuQq+UGHTO+jziKJbz1f1z8rMpuhAyChn1DAHBh6RkUL nz6/R0MaN+1RdpoZS7upi16mD0p3AlmOcE2FHSdc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 13A7CF80245; Mon, 2 Mar 2020 01:29:46 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5E0E7F8025F; Mon, 2 Mar 2020 01:29:41 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 8A03BF80131 for ; Mon, 2 Mar 2020 01:29:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8A03BF80131 Date: 02 Mar 2020 09:29:30 +0900 X-IronPort-AV: E=Sophos;i="5.70,505,1574089200"; d="scan'208";a="40448275" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 02 Mar 2020 09:29:30 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 767BF41331B7; Mon, 2 Mar 2020 09:29:30 +0900 (JST) Message-ID: <87d09vha51.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Kai Vehmanen Subject: Re: [PATCH] ASoC: soc-pcm: Revert "call snd_soc_component_open/close() once" In-Reply-To: References: <20200219182650.1416-1-kai.vehmanen@linux.intel.com> <87blput7hh.wl-kuninori.morimoto.gx@renesas.com> <87mu9cspyf.wl-kuninori.morimoto.gx@renesas.com> <87mu978pob.wl-kuninori.morimoto.gx@renesas.com> <87ftey88wk.wl-kuninori.morimoto.gx@renesas.com> <874kvb7d38.wl-kuninori.morimoto.gx@renesas.com> <871rqf6xas.wl-kuninori.morimoto.gx@renesas.com> <87zhd35eko.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: alsa-devel@alsa-project.org, broonie@kernel.org, ranjani.sridharan@linux.intel.com, digetx@gmail.com, pierre-louis.bossart@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Kai Thank you for your feedback > int snd_soc_component_open(struct snd_soc_component *component, > =BB =BB =BB struct snd_pcm_substream *substream) (snip) > int snd_soc_component_prepare(struct snd_soc_component *component, > =BB =BB =BB struct snd_pcm_substream *substream) > { > =BB if (component->driver->prepare) > =BB =BB return component->driver->prepare(component, substrea= m); > =BB return 0; > } I guess you are thinking more big scale tracking/solution (?). Indeed it is needed, but my indicated one is not for it. It is just for "we want to use soc_pcm_close() as soc_pcm_open() error hand= ling". > > int soc_pcm_open(...) > > { > > static u8 id; > >=20 > > /* update ID */ > > id++; > > if (id =3D=3D 0) > > id++; >=20 > ... this really isn't solid. If you have a complex scenario and something= =20 > goes wrong, debugging the ids is going to be painful if they are assigned= =20 > this way. Maybe the naming of "ID" makes you confused ? It is just "mark" for this "soc_pcm_open()". If error happen during open, "error handling soc_pcm_close()" cares only th= is mark. It is just for avoiding mismatch close. Your big scale tracking (open/prepare/...) is maybe next step / more advanc= ed problem. My got feeling is that it is similar to SND_SOC_DPCM_STATE_xxx ? Thank you for your help !! Best regards --- Kuninori Morimoto