All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/jitterentropy-library: fix build failure due to missing -fPIC
Date: Fri, 25 Oct 2019 21:23:18 +0200	[thread overview]
Message-ID: <87d0ekiq8p.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <2f610d45-59a6-da96-b32e-ed1ff8c2dfbd@mind.be> (Arnout Vandecappelle's message of "Fri, 25 Oct 2019 20:52:53 +0200")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> >  Hm, but maybe there are indeed good reasons to override the CFLAGS, because the
 >> > fstack-protector-all requires support from the toolchain. On the other hand, we
 >> > probably *do* want to keep the -O0 and -fwrapv flags...
 >> 
 >> The fstack-protector-* options should be handled by BR2_SSP_* and
 >> hardcoded in the package. 

 >  If with "hardcoded in the package" you mean "set by the package's .mk file",
 > then I disagree, since it is passed by the toolchain wrapper.

Sorry, there was a NOT missing, E.G. NOT hardcoded in .mk.

 >> Why would we want to use -O0?

 >  The package description is "Hardware RNG based on CPU timing jitter." I expect
 > that compiler optimisations mess with CPU timing jitter.

Ah yes, possibly.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2019-10-25 19:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 11:06 [Buildroot] [PATCH] package/jitterentropy-library: fix build failure due to missing -fPIC Giulio Benetti
2019-10-23 21:56 ` Arnout Vandecappelle
2019-10-24  0:02   ` Matthew Weber
2019-10-24  2:28     ` Matthew Weber
2019-10-24 12:03       ` Matthew Weber
2019-10-25  8:17         ` Matthew Weber
2019-10-25 16:19   ` Peter Korsgaard
2019-10-25 18:52     ` Arnout Vandecappelle
2019-10-25 19:23       ` Peter Korsgaard [this message]
2019-10-25 19:57         ` Arnout Vandecappelle
2019-10-25 23:17           ` Markus Mayer
2019-10-26  0:01             ` Markus Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0ekiq8p.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.