From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C322C432C2 for ; Tue, 24 Sep 2019 05:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E37422064A for ; Tue, 24 Sep 2019 05:30:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="i3ZY2OYd"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="i3ZY2OYd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438559AbfIXFaZ (ORCPT ); Tue, 24 Sep 2019 01:30:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36682 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438519AbfIXFaY (ORCPT ); Tue, 24 Sep 2019 01:30:24 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CA98C602F0; Tue, 24 Sep 2019 05:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569303023; bh=SKpoTL5qdqpCZE8jfMpeNULCFOVTf1yiWa2F+YGyiUY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=i3ZY2OYdN2lGQe+y7MbsWqxJOYxpD0Ec7VitiyHqBIquXU/qK2wNGgUI6nAbehWVB NT80mtpExC9mph25W5QYL5vF+AJoUCoTtraD+lWUtAgkHPWrV9rjMhnlG2gfZsBzbu d+0509hQHGcuv3BAtAcFNk56bfcb9XVsHJDcs4yw= Received: from x230.qca.qualcomm.com (37-136-106-186.rev.dnainternet.fi [37.136.106.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 416EE60240; Tue, 24 Sep 2019 05:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569303023; bh=SKpoTL5qdqpCZE8jfMpeNULCFOVTf1yiWa2F+YGyiUY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=i3ZY2OYdN2lGQe+y7MbsWqxJOYxpD0Ec7VitiyHqBIquXU/qK2wNGgUI6nAbehWVB NT80mtpExC9mph25W5QYL5vF+AJoUCoTtraD+lWUtAgkHPWrV9rjMhnlG2gfZsBzbu d+0509hQHGcuv3BAtAcFNk56bfcb9XVsHJDcs4yw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 416EE60240 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Tomislav =?utf-8?Q?Po=C5=BEega?= Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH 5/5] ath10k: pull_svc_rdy code-style fix References: <1569268165-1639-1-git-send-email-pozega.tomislav@gmail.com> <1569268165-1639-5-git-send-email-pozega.tomislav@gmail.com> Date: Tue, 24 Sep 2019 08:30:19 +0300 In-Reply-To: <1569268165-1639-5-git-send-email-pozega.tomislav@gmail.com> ("Tomislav \=\?utf-8\?Q\?Po\=C5\=BEega\=22's\?\= message of "Mon, 23 Sep 2019 21:49:25 +0200") Message-ID: <87d0fq5kic.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tomislav Po=C5=BEega writes: > Drop unneeded lines by moving skb data in both main and 10x WMI > pull service ready event operations. > > Signed-off-by: Tomislav Po=C5=BEega > --- > drivers/net/wireless/ath/ath10k/wmi.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless= /ath/ath10k/wmi.c > index 59d2d2a..8ab178c 100644 > --- a/drivers/net/wireless/ath/ath10k/wmi.c > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > @@ -5345,13 +5345,12 @@ static int ath10k_wmi_alloc_host_mem(struct ath10= k *ar, u32 req_id, > ath10k_wmi_main_op_pull_svc_rdy_ev(struct ath10k *ar, struct sk_buff *sk= b, > struct wmi_svc_rdy_ev_arg *arg) > { > - struct wmi_service_ready_event *ev; > + struct wmi_service_ready_event *ev =3D (void *)skb->data; > size_t i, n; >=20=20 > if (skb->len < sizeof(*ev)) > return -EPROTO; >=20=20 > - ev =3D (void *)skb->data; Actually I prefer the original style, so that we first check the data in skb is valid and only then assign the data to ev. --=20 Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCdP5-0005tn-Vx for ath10k@lists.infradead.org; Tue, 24 Sep 2019 05:30:25 +0000 From: Kalle Valo Subject: Re: [PATCH 5/5] ath10k: pull_svc_rdy code-style fix References: <1569268165-1639-1-git-send-email-pozega.tomislav@gmail.com> <1569268165-1639-5-git-send-email-pozega.tomislav@gmail.com> Date: Tue, 24 Sep 2019 08:30:19 +0300 In-Reply-To: <1569268165-1639-5-git-send-email-pozega.tomislav@gmail.com> ("Tomislav \=\?utf-8\?Q\?Po\=C5\=BEega\=22's\?\= message of "Mon, 23 Sep 2019 21:49:25 +0200") Message-ID: <87d0fq5kic.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Tomislav =?utf-8?Q?Po=C5=BEega?= Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org VG9taXNsYXYgUG/FvmVnYSA8cG96ZWdhLnRvbWlzbGF2QGdtYWlsLmNvbT4gd3JpdGVzOgoKPiBE cm9wIHVubmVlZGVkIGxpbmVzIGJ5IG1vdmluZyBza2IgZGF0YSBpbiBib3RoIG1haW4gYW5kIDEw eCBXTUkKPiBwdWxsIHNlcnZpY2UgcmVhZHkgZXZlbnQgb3BlcmF0aW9ucy4KPgo+IFNpZ25lZC1v ZmYtYnk6IFRvbWlzbGF2IFBvxb5lZ2EgPHBvemVnYS50b21pc2xhdkBnbWFpbC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvd21pLmMgfCAgICA2ICsrLS0tLQo+ ICAxIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL3dtaS5jIGIvZHJpdmVy cy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway93bWkuYwo+IGluZGV4IDU5ZDJkMmEuLjhhYjE3OGMg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway93bWkuYwo+ICsr KyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvd21pLmMKPiBAQCAtNTM0NSwxMyAr NTM0NSwxMiBAQCBzdGF0aWMgaW50IGF0aDEwa193bWlfYWxsb2NfaG9zdF9tZW0oc3RydWN0IGF0 aDEwayAqYXIsIHUzMiByZXFfaWQsCj4gIGF0aDEwa193bWlfbWFpbl9vcF9wdWxsX3N2Y19yZHlf ZXYoc3RydWN0IGF0aDEwayAqYXIsIHN0cnVjdCBza19idWZmICpza2IsCj4gIAkJCQkgICBzdHJ1 Y3Qgd21pX3N2Y19yZHlfZXZfYXJnICphcmcpCj4gIHsKPiAtCXN0cnVjdCB3bWlfc2VydmljZV9y ZWFkeV9ldmVudCAqZXY7Cj4gKwlzdHJ1Y3Qgd21pX3NlcnZpY2VfcmVhZHlfZXZlbnQgKmV2ID0g KHZvaWQgKilza2ItPmRhdGE7Cj4gIAlzaXplX3QgaSwgbjsKPiAgCj4gIAlpZiAoc2tiLT5sZW4g PCBzaXplb2YoKmV2KSkKPiAgCQlyZXR1cm4gLUVQUk9UTzsKPiAgCj4gLQlldiA9ICh2b2lkICop c2tiLT5kYXRhOwoKQWN0dWFsbHkgSSBwcmVmZXIgdGhlIG9yaWdpbmFsIHN0eWxlLCBzbyB0aGF0 IHdlIGZpcnN0IGNoZWNrIHRoZSBkYXRhIGluCnNrYiBpcyB2YWxpZCBhbmQgb25seSB0aGVuIGFz c2lnbiB0aGUgZGF0YSB0byBldi4KCi0tIApLYWxsZSBWYWxvCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0Bs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vYXRoMTBrCg==