From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH v4 11/12] thermal: armada: Give meaningful names to the thermal zones Date: Mon, 18 Dec 2017 17:12:46 +0100 Message-ID: <87d13chv5t.fsf@free-electrons.com> References: <20171218143643.7714-1-miquel.raynal@free-electrons.com> <20171218143643.7714-12-miquel.raynal@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171218143643.7714-12-miquel.raynal@free-electrons.com> (Miquel Raynal's message of "Mon, 18 Dec 2017 15:36:42 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Mark Rutland , Andrew Lunn , Baruch Siach , Jason Cooper , Nadav Haklai , linux-pm@vger.kernel.org, Catalin Marinas , Antoine Tenart , Will Deacon , David Sniatkiwicz , Eduardo Valentin , devicetree@vger.kernel.org, Rob Herring , Zhang Rui , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgTWlxdWVsLAogCiBPbiBsdW4uLCBkw6ljLiAxOCAyMDE3LCBNaXF1ZWwgUmF5bmFsIDxtaXF1 ZWwucmF5bmFsQGZyZWUtZWxlY3Ryb25zLmNvbT4gd3JvdGU6Cgo+IEFmdGVyIHJlZ2lzdHJhdGlv biB0byB0aGUgdGhlcm1hbCBjb3JlLCBzeXNmcyB3aWxsIG1ha2Ugb25lIGVudHJ5Cj4gcGVyIGlu c3RhbmNlIG9mIHRoZSBkcml2ZXIgaW4gL3N5cy9jbGFzcy90aGVybWFsX3pvbmVYIGFuZAo+IC9z eXMvY2xhc3MvaHdtb24vaHdtb25YLCBYIGJlaW5nIHRoZSBpbmRleCBvZiB0aGUgaW5zdGFuY2Us IGFsbCBvZiB0aGVtCj4gaGF2aW5nIHRoZSB0eXBlL25hbWUgImFybWFkYV90aGVybWFsIi4KPgo+ IFVudGlsIG5vdyB0aGVyZSB3YXMgb25seSBvbmUgdGhlcm1hbCB6b25lIHBlciBTb0MgYnV0IFNv Q3MgbGlrZSBBcm1hZGEKPiBBN0sgYW5kIEFybWFkYSBBOEsgaGF2ZSByZXNwZWN0aXZlbHkgdHdv IGFuZCB0aHJlZSB0aGVybWFsIHpvbmVzIChvbmUKPiBwZXIgQVAgYW5kIG9uZSBwZXIgQ1ApIGFu ZCB0aGlzIG51bWJlciBpcyBzdWJqZWN0IHRvIGdyb3cgaW4gdGhlIGZ1dHVyZS4KPgo+IFVzZSBk ZXZfbmFtZSgpIGluc3RlYWQgb2YgdGhlICJhcm1hZGFfdGhlcm1hbCIgc3RyaW5nIHRvIGdldCBh Cj4gbWVhbmluZ2Z1bCBuYW1lIGFuZCBiZSBhYmxlIHRvIGlkZW50aWZ5IHRoZSB0aGVybWFsIHpv bmVzIGZyb20KPiB1c2Vyc3BhY2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBNaXF1ZWwgUmF5bmFsIDxt aXF1ZWwucmF5bmFsQGZyZWUtZWxlY3Ryb25zLmNvbT4KClJldmlld2VkLWJ5OiBHcmVnb3J5IENM RU1FTlQgPGdyZWdvcnkuY2xlbWVudEBmcmVlLWVsZWN0cm9ucy5jb20+CgpHcmVnb3J5CgoKPiAt LS0KPiAgZHJpdmVycy90aGVybWFsL2FybWFkYV90aGVybWFsLmMgfCA0ICsrLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL3RoZXJtYWwvYXJtYWRhX3RoZXJtYWwuYyBiL2RyaXZlcnMvdGhlcm1hbC9hcm1h ZGFfdGhlcm1hbC5jCj4gaW5kZXggNGE1MTY0ZGRmZmU3Li40MmVmODBiM2I1ZjggMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy90aGVybWFsL2FybWFkYV90aGVybWFsLmMKPiArKysgYi9kcml2ZXJzL3Ro ZXJtYWwvYXJtYWRhX3RoZXJtYWwuYwo+IEBAIC00MDMsOCArNDAzLDggQEAgc3RhdGljIGludCBh cm1hZGFfdGhlcm1hbF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAKPiAg CXByaXYtPmRhdGEtPmluaXRfc2Vuc29yKHBkZXYsIHByaXYpOwo+ICAKPiAtCXRoZXJtYWwgPSB0 aGVybWFsX3pvbmVfZGV2aWNlX3JlZ2lzdGVyKCJhcm1hZGFfdGhlcm1hbCIsIDAsIDAsCj4gLQkJ CQkJICAgICAgIHByaXYsICZvcHMsIE5VTEwsIDAsIDApOwo+ICsJdGhlcm1hbCA9IHRoZXJtYWxf em9uZV9kZXZpY2VfcmVnaXN0ZXIoZGV2X25hbWUoJnBkZXYtPmRldiksIDAsIDAsIHByaXYsCj4g KwkJCQkJICAgICAgICZvcHMsIE5VTEwsIDAsIDApOwo+ICAJaWYgKElTX0VSUih0aGVybWFsKSkg ewo+ICAJCWRldl9lcnIoJnBkZXYtPmRldiwKPiAgCQkJIkZhaWxlZCB0byByZWdpc3RlciB0aGVy bWFsIHpvbmUgZGV2aWNlXG4iKTsKPiAtLSAKPiAyLjExLjAKPgoKLS0gCkdyZWdvcnkgQ2xlbWVu dCwgRnJlZSBFbGVjdHJvbnMKS2VybmVsLCBkcml2ZXJzLCByZWFsLXRpbWUgYW5kIGVtYmVkZGVk IExpbnV4CmRldmVsb3BtZW50LCBjb25zdWx0aW5nLCB0cmFpbmluZyBhbmQgc3VwcG9ydC4KaHR0 cDovL2ZyZWUtZWxlY3Ryb25zLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Mon, 18 Dec 2017 17:12:46 +0100 Subject: [PATCH v4 11/12] thermal: armada: Give meaningful names to the thermal zones In-Reply-To: <20171218143643.7714-12-miquel.raynal@free-electrons.com> (Miquel Raynal's message of "Mon, 18 Dec 2017 15:36:42 +0100") References: <20171218143643.7714-1-miquel.raynal@free-electrons.com> <20171218143643.7714-12-miquel.raynal@free-electrons.com> Message-ID: <87d13chv5t.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Miquel, On lun., d?c. 18 2017, Miquel Raynal wrote: > After registration to the thermal core, sysfs will make one entry > per instance of the driver in /sys/class/thermal_zoneX and > /sys/class/hwmon/hwmonX, X being the index of the instance, all of them > having the type/name "armada_thermal". > > Until now there was only one thermal zone per SoC but SoCs like Armada > A7K and Armada A8K have respectively two and three thermal zones (one > per AP and one per CP) and this number is subject to grow in the future. > > Use dev_name() instead of the "armada_thermal" string to get a > meaningful name and be able to identify the thermal zones from > userspace. > > Signed-off-by: Miquel Raynal Reviewed-by: Gregory CLEMENT Gregory > --- > drivers/thermal/armada_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c > index 4a5164ddffe7..42ef80b3b5f8 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -403,8 +403,8 @@ static int armada_thermal_probe(struct platform_device *pdev) > > priv->data->init_sensor(pdev, priv); > > - thermal = thermal_zone_device_register("armada_thermal", 0, 0, > - priv, &ops, NULL, 0, 0); > + thermal = thermal_zone_device_register(dev_name(&pdev->dev), 0, 0, priv, > + &ops, NULL, 0, 0); > if (IS_ERR(thermal)) { > dev_err(&pdev->dev, > "Failed to register thermal zone device\n"); > -- > 2.11.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com