From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934357AbdCVLtO (ORCPT ); Wed, 22 Mar 2017 07:49:14 -0400 Received: from ozlabs.org ([103.22.144.67]:60289 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758814AbdCVLtF (ORCPT ); Wed, 22 Mar 2017 07:49:05 -0400 From: Michael Ellerman To: Bamvor Zhang Jian Cc: Andy Lutomirski , "Zhangjian \(Bamvor\)" , Shuah Khan , Linux API , "linux-kernel\@vger.kernel.org" , Kevin Hilman , Mark Brown Subject: Re: [PATCH v2 6/6] selftests: enable O and KBUILD_OUTPUT In-Reply-To: References: <20161129115552.8148-1-bamvor.zhangjian@huawei.com> <20161129115552.8148-7-bamvor.zhangjian@huawei.com> <87fui7owls.fsf@concordia.ellerman.id.au> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 22 Mar 2017 22:38:43 +1100 Message-ID: <87d1d9czi4.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bamvor Zhang Jian writes: > On 21 March 2017 at 16:35, Michael Ellerman wrote: >> I see at least 18 Makefile's in tools/testing/selftests that use >> $(OUTPUT)/, which would all need to be updated at least to use $(OUTPUT) >> (no trailing slash), and then some other changes to not propagate OUTPUT >> when the user didn't specify it. But hopefully someone will prove me >> wrong. > I also look at this issue. Originally, I use OUTPUT without slash in my > patch. People argue that it is not very clear. So, I add slash in curent > version. That was me, you can say so. I wasn't thinking at the time of OUTPUT being empty, but with hindsight obviously I should have. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH v2 6/6] selftests: enable O and KBUILD_OUTPUT Date: Wed, 22 Mar 2017 22:38:43 +1100 Message-ID: <87d1d9czi4.fsf@concordia.ellerman.id.au> References: <20161129115552.8148-1-bamvor.zhangjian@huawei.com> <20161129115552.8148-7-bamvor.zhangjian@huawei.com> <87fui7owls.fsf@concordia.ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bamvor Zhang Jian Cc: Andy Lutomirski , "Zhangjian (Bamvor)" , Shuah Khan , Linux API , "linux-kernel@vger.kernel.org" , Kevin Hilman , Mark Brown List-Id: linux-api@vger.kernel.org Bamvor Zhang Jian writes: > On 21 March 2017 at 16:35, Michael Ellerman wrote: >> I see at least 18 Makefile's in tools/testing/selftests that use >> $(OUTPUT)/, which would all need to be updated at least to use $(OUTPUT) >> (no trailing slash), and then some other changes to not propagate OUTPUT >> when the user didn't specify it. But hopefully someone will prove me >> wrong. > I also look at this issue. Originally, I use OUTPUT without slash in my > patch. People argue that it is not very clear. So, I add slash in curent > version. That was me, you can say so. I wasn't thinking at the time of OUTPUT being empty, but with hindsight obviously I should have. cheers