From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663AbdCCGif (ORCPT ); Fri, 3 Mar 2017 01:38:35 -0500 Received: from ozlabs.org ([103.22.144.67]:57351 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdCCGia (ORCPT ); Fri, 3 Mar 2017 01:38:30 -0500 From: Michael Ellerman To: Shuah Khan , shuah@kernel.org, bamvor.zhangjian@huawei.com, mingo@kernel.org Cc: Shuah Khan , tglx@linutronix.de, hpa@zytor.com, luto@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: lib.mk Fix individual test builds In-Reply-To: <20170301224623.16973-1-shuahkh@osg.samsung.com> References: <20170301224623.16973-1-shuahkh@osg.samsung.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 03 Mar 2017 16:00:58 +1100 Message-ID: <87d1dzhs39.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shuah Khan writes: > In commit a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT"), added > support to generate compile targets in a user specified directory. OUTPUT > variable controls the location which is undefined when tests are built in > the test directory or with "make -C tools/testing/selftests/x86". > > make -C tools/testing/selftests/x86/ > make: Entering directory '/lkml/linux_4.11/tools/testing/selftests/x86' > Makefile:44: warning: overriding recipe for target 'clean' > ../lib.mk:51: warning: ignoring old recipe for target 'clean' > gcc -m64 -o /single_step_syscall_64 -O2 -g -std=gnu99 -pthread -Wall single_step_syscall.c -lrt -ldl > /usr/bin/ld: cannot open output file /single_step_syscall_64: Permission denied > collect2: error: ld returned 1 exit status > Makefile:50: recipe for target '/single_step_syscall_64' failed > make: *** [/single_step_syscall_64] Error 1 > make: Leaving directory '/lkml/linux_4.11/tools/testing/selftests/x86' > > Same failure with "cd tools/testing/selftests/x86/;make" run. > > Fix this with a change to lib.mk to define OUTPUT to be the pwd when > MAKELEVEL is 0. This covers both cases mentioned above. > > Reported-by: Ingo Molnar > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/lib.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index ce96d80..775c589 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -2,6 +2,10 @@ > # Makefile can operate with or without the kbuild infrastructure. > CC := $(CROSS_COMPILE)gcc > > +ifeq (0,$(MAKELEVEL)) > +OUTPUT := $(shell pwd) > +endif I preferred my version which just used =? rather than checking MAKELEVEL, but I don't mind that much. Acked-by: Michael Ellerman cheers