Re: [PATCH 8/9] ASoC: simple-card: code sync: rename num_link to num

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 8/9] ASoC: simple-card: code sync: rename num_link to num
Date: Fri, 26 Aug 2016 02:51:51 +0000	[thread overview]
Message-ID: <87d1kws10r.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <201608251635.kJNOT64O%fengguang.wu@intel.com>

Hi Mark

This is my fault.
I will post v2 patch.

> [auto build test ERROR on asoc/for-next]
> [also build test ERROR on next-20160824]
> [cannot apply to v4.8-rc3]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
> 
> url:    https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/ASoC-simple-card-tidyup-and-synchronize-patches/20160825-100058
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> config: i386-randconfig-x011-201634 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> Note: the linux-review/Kuninori-Morimoto/ASoC-simple-card-tidyup-and-synchronize-patches/20160825-100058 HEAD 36fb10f61ffb92eb287328e22cad00a486495747 builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>    sound/soc/generic/simple-card.c: In function 'asoc_simple_card_probe':
> >> sound/soc/generic/simple-card.c:398:40: error: 'num_links' undeclared (first use in this function)
>        sizeof(*priv) + sizeof(*dai_link) * num_links,
>                                            ^~~~~~~~~
>    sound/soc/generic/simple-card.c:398:40: note: each undeclared identifier is reported only once for each function it appears in
> 
> vim +/num_links +398 sound/soc/generic/simple-card.c
> 
> 6805a759b Kuninori Morimoto   2016-08-25  392  		num = of_get_child_count(np);
> 2080437d3 Xiubo Li            2014-09-03  393  	else
> 6805a759b Kuninori Morimoto   2016-08-25  394  		num = 1;
> f2390880e Kuninori Morimoto   2012-04-08  395  
> 0dd4fc3c2 Xiubo Li            2014-09-10  396  	/* Allocate the private data and the DAI link array */
> cf7dc23cb Jean-Francois Moine 2014-03-20  397  	priv = devm_kzalloc(dev,
> 6a91a17bd Jean-Francois Moine 2014-03-20 @398  			sizeof(*priv) + sizeof(*dai_link) * num_links,
> cf7dc23cb Jean-Francois Moine 2014-03-20  399  			GFP_KERNEL);
> ca65b492c Jean-Francois Moine 2014-01-15  400  	if (!priv)
> ca919fe4b Xiubo Li            2014-01-14  401  		return -ENOMEM;
> 
> :::::: The code at line 398 was first introduced by commit
> :::::: 6a91a17bd7b92b2d2aa9ece85457f52a62fd7708 ASoC: simple-card: Handle many DAI links
> 
> :::::: TO: Jean-Francois Moine <moinejf@free.fr>
> :::::: CC: Mark Brown <broonie@linaro.org>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> [2 .config.gz <application/octet-stream (base64)>]
> 

Best regards
---
Kuninori Morimoto