All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "SUNRPC: xs_sock_mark_closed() does not need to trigger socket autoclose"
@ 2016-08-03 23:33 NeilBrown
  2016-08-04  0:01 ` Trond Myklebust
  0 siblings, 1 reply; 7+ messages in thread
From: NeilBrown @ 2016-08-03 23:33 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: Linux NFS Mailing list

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]


This reverts commit 4b0ab51db32eba0f48b7618254742f143364a28d.

This change causes 'rpc.nfsd' to hang for long time if rpcbind is not
available.
If
   --no-nfs-version 2 --no-nfs-version 3
is given, the delay is about 6.5 minutes.  When trying to register
all versions, the delay is over half an hour.
Before this commit, and after reverting it, nfsd fails (when v3 is
requested) or succeeds (when only v4 is requested) immediately.

Signed-off-by: NeilBrown <neilb@suse.com>
---
 net/sunrpc/xprtsock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 111767ab124a..2a938055e95b 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -795,6 +795,7 @@ static void xs_sock_mark_closed(struct rpc_xprt *xprt)
 	xs_sock_reset_connection_flags(xprt);
 	/* Mark transport as closed and wake up all pending tasks */
 	xprt_disconnect_done(xprt);
+	xprt_force_disconnect(xprt);
 }
 
 /**
-- 
2.9.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-11-21  3:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03 23:33 [PATCH] Revert "SUNRPC: xs_sock_mark_closed() does not need to trigger socket autoclose" NeilBrown
2016-08-04  0:01 ` Trond Myklebust
2016-08-04  2:35   ` NeilBrown
2016-08-10  2:05   ` NeilBrown
2016-11-18  4:48     ` NeilBrown
2016-11-18 14:31     ` Trond Myklebust
2016-11-21  3:24       ` NeilBrown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.