From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relmlor2.renesas.com ([210.160.252.172]:40478 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751480AbcF3ADg (ORCPT ); Wed, 29 Jun 2016 20:03:36 -0400 Message-ID: <87d1mzblcn.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Mark Brown CC: Linux-ALSA , Liam Girdwood , Simon , Subject: Re: [PATCH 05/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_tdm() In-Reply-To: <20160629181159.GH6247@sirena.org.uk> References: <87fusysjam.wl%kuninori.morimoto.gx@renesas.com> <878tyqsj48.wl%kuninori.morimoto.gx@renesas.com> <20160629181159.GH6247@sirena.org.uk> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Thu, 30 Jun 2016 00:03:30 +0000 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Mark > > +int asoc_simple_card_parse_tdm(struct device_node *port_np, > > + struct asoc_simple_dai *simple_dai) > > +{ > > + return snd_soc_of_parse_tdm_slot(port_np, > > + &simple_dai->tx_slot_mask, > > + &simple_dai->rx_slot_mask, > > + &simple_dai->slots, > > + &simple_dai->slot_width); > > +} > > +EXPORT_SYMBOL_GPL(asoc_simple_card_parse_tdm); > > This is (obviously) a very thin wrapper around the existing interface. > If that makes sense then perhaps we should just update the existing > interface? Indeed it is very thin. I will just remove it in v3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 05/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_tdm() Date: Thu, 30 Jun 2016 00:03:30 +0000 Message-ID: <87d1mzblcn.wl%kuninori.morimoto.gx@renesas.com> References: <87fusysjam.wl%kuninori.morimoto.gx@renesas.com> <878tyqsj48.wl%kuninori.morimoto.gx@renesas.com> <20160629181159.GH6247@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Return-path: In-Reply-To: <20160629181159.GH6247@sirena.org.uk> Sender: linux-renesas-soc-owner@vger.kernel.org To: Mark Brown Cc: Linux-ALSA , Liam Girdwood , Simon , linux-renesas-soc@vger.kernel.org List-Id: alsa-devel@alsa-project.org Hi Mark > > +int asoc_simple_card_parse_tdm(struct device_node *port_np, > > + struct asoc_simple_dai *simple_dai) > > +{ > > + return snd_soc_of_parse_tdm_slot(port_np, > > + &simple_dai->tx_slot_mask, > > + &simple_dai->rx_slot_mask, > > + &simple_dai->slots, > > + &simple_dai->slot_width); > > +} > > +EXPORT_SYMBOL_GPL(asoc_simple_card_parse_tdm); > > This is (obviously) a very thin wrapper around the existing interface. > If that makes sense then perhaps we should just update the existing > interface? Indeed it is very thin. I will just remove it in v3