From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46846)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aSnuA-0005nX-J0
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:39:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aSnu6-0000yI-Lq
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 10:39:10 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <20160111173036.24764.59878.stgit@bahia.huguette.org>
	<569D22F6.5070104@msgid.tls.msk.ru>
	<20160118192843.55ef9d93@bahia.huguette.org>
	<20160208151147.GC31586@stefanha-x1.localdomain>
Date: Mon, 08 Feb 2016 16:39:03 +0100
In-Reply-To: <20160208151147.GC31586@stefanha-x1.localdomain> (Stefan
	Hajnoczi's message of "Mon, 8 Feb 2016 15:11:47 +0000")
Message-ID: <87d1s7w6so.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org, Greg Kurz <gkurz@linux.vnet.ibm.com>

Stefan Hajnoczi <stefanha@gmail.com> writes:

> On Mon, Jan 18, 2016 at 07:28:43PM +0100, Greg Kurz wrote:
>> On Mon, 18 Jan 2016 20:37:58 +0300
>> Michael Tokarev <mjt@tls.msk.ru> wrote:
>> 
>> > 11.01.2016 20:30, Greg Kurz wrote:
>> > 
>> > > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64""
>> > > +virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64  
>> > ...
>> > 
>> > I'm not sure what's the value of this.  It's fine either way, no?
>> 
>> The only value is to drop unneeded stuff... and maybe some consistency
>> with the traces that don't have these trailing empty strings.
>> 
>> > Do we have a rule for trailing empty strings in coding style? :)
>> > 
>> 
>> Nor we have against parenthesitis, which brings a lot more unneeded
>> characters into the code :P
>
> Regarding the history of the quoting limitation, see commit
> cf85cf8e972f3ad79f203be4edb7968d6e052293 ("trace: Format strings must
> begin/end with double quotes").  It was a limitation of the old
> tracetool.sh script.
>
> The modern tracetool.py script handles format strings fine when they do
> not end with double-quotes.

Suggest to work that into the commit message.

> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing
>
> Stefan