From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbbJWQfA (ORCPT ); Fri, 23 Oct 2015 12:35:00 -0400 Received: from gabe.freedesktop.org ([131.252.210.177]:39757 "EHLO gabe.freedesktop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbbJWQe7 (ORCPT ); Fri, 23 Oct 2015 12:34:59 -0400 From: Eric Anholt To: Ilia Mirkin Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/6] drm/vc4: Fix some failure to track __iomem decorations on pointers. In-Reply-To: References: <1445596356-28202-1-git-send-email-eric@anholt.net> <1445596356-28202-5-git-send-email-eric@anholt.net> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 23 Oct 2015 17:34:52 +0100 Message-ID: <87d1w57dcj.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Ilia Mirkin writes: > On Oct 23, 2015 6:32 AM, "Eric Anholt" wrote: >> >> Caught by the kbuild test robot. >> >> Signed-off-by: Eric Anholt >> --- >> drivers/gpu/drm/vc4/vc4_crtc.c | 3 ++- >> drivers/gpu/drm/vc4/vc4_hvs.c | 8 ++++---- >> 2 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c > b/drivers/gpu/drm/vc4/vc4_crtc.c >> index a3a77dd..32c0348 100644 >> --- a/drivers/gpu/drm/vc4/vc4_crtc.c >> +++ b/drivers/gpu/drm/vc4/vc4_crtc.c >> @@ -401,7 +401,8 @@ static void vc4_crtc_atomic_flush(struct drm_crtc > *crtc, >> dlist_next++; >> >> HVS_WRITE(SCALER_DISPLISTX(vc4_crtc->channel), >> - (u32 *)vc4_crtc->dlist - (u32 > *)vc4->hvs->dlist); >> + (u32 __iomem *)vc4_crtc->dlist - >> + (u32 __iomem *)vc4->hvs->dlist); >> >> /* Make the next display list start after ours. */ >> vc4_crtc->dlist_size -= (dlist_next - vc4_crtc->dlist); >> diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c >> index ab1673f..4d81d43 100644 >> --- a/drivers/gpu/drm/vc4/vc4_hvs.c >> +++ b/drivers/gpu/drm/vc4/vc4_hvs.c >> @@ -75,10 +75,10 @@ void vc4_hvs_dump_state(struct drm_device *dev) >> for (i = 0; i < 64; i += 4) { >> DRM_INFO("0x%08x (%s): 0x%08x 0x%08x 0x%08x 0x%08x\n", >> i * 4, i < HVS_BOOTLOADER_DLIST_END ? "B" : "D", >> - ((uint32_t *)vc4->hvs->dlist)[i + 0], >> - ((uint32_t *)vc4->hvs->dlist)[i + 1], >> - ((uint32_t *)vc4->hvs->dlist)[i + 2], >> - ((uint32_t *)vc4->hvs->dlist)[i + 3]); >> + readl((u32 __iomem *)vc4->hvs->dlist + 0), >> + readl((u32 __iomem *)vc4->hvs->dlist + 1), >> + readl((u32 __iomem *)vc4->hvs->dlist + 2), >> + readl((u32 __iomem *)vc4->hvs->dlist + 3)); > > Looks like you lost the +i here, no? Indeed. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWKmGsAAoJELXWKTbR/J7o+VkQAI2+gZi5fgmdxQcd3MJr4tS3 D1Ux2yAsN3F4s+ZbQEJTuNj/U6jicosbgGtpJJbYxOPkvks4BpZS2ITtcKGN5dOz Z/K8zoaOE+QJmF2F3WvD3su8mQm3qUpE9fdiewedKF79GVHNZSBjMpIu4TEaPe8U spySSLBP7VjOBuOpiTRphuP3TpmFLMrYPKKk5w3XYYSKfm5cV+TWhJa9clj8SwGb 7wbl8vTo1BuzCXWaPVHddYcWX0ErIqdpEl/zWTYhTbZ0/1EUUKD+Ik50/+6Uoheg phDxQH3pOJswqE1nwkhCmlzkqGKcUYj80YpW/cs3cuFKSALUxmTwb94ZFNUtOXAv y/VhVUGJHF7GyK3z5StDBOsL0LtBjpjG6TILo3Y19mBWdl3pXpGVCwIAEAyZ86f8 IpLrHVBMpx5pkgkOcZ/CIGLxrZ/3ar3tWIrVxMNkoK7PpzVDs1TTVlIczR8N6J81 enyhw19Bez09KcgY62Jtxe5h4s/Zq8qMOcp1kxwL9GBhMUWS7bwo7rSpgzcRGo0K PSCaMrZt1K+aEGqqnifewI8Cnp/mfppLh3jReLPcG5rQJhaR1rogFU3+yjedyYYk obIVjYnkNyoFTdIDv20Jisj012sJIh01qkADeYbUYFsAiJoNf9QG1ud2BfRGhNdd Q9VQgsAcJY1HBiagLo9K =59RN -----END PGP SIGNATURE----- --=-=-=--