From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH 2/4] dts: add devicetree bindings for pxa27x clocks Date: Fri, 04 Jul 2014 21:38:30 +0200 Message-ID: <87d2dkoqx5.fsf@free.fr> References: <1404066744-13416-1-git-send-email-robert.jarzmik@free.fr> <1404066744-13416-3-git-send-email-robert.jarzmik@free.fr> <20140703220328.11380.22037@quantum> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20140703220328.11380.22037@quantum> (Mike Turquette's message of "Thu, 03 Jul 2014 15:03:28 -0700") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mike Turquette Cc: Haojian Zhuang , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eric Miao , "linux-arm-kernel@lists.infradead.org" , Mark Rutland List-Id: devicetree@vger.kernel.org Mike Turquette writes: > Quoting Haojian Zhuang (2014-07-02 23:14:33) >> Maybe defining these clocks in pxa27x clock driver is better. > > Agreed. After a long time trying to figure out the best DT binding for > clocks it seems that defining the per-clock data in DTS is not the best > way. The qcom msm and samsung exynos clock bindings and DTS data are > good examples. Ah, I see. Would have been a great comment in the former RFC patch serie, sic ... Maybe a comment in the clock device-tree documentation would prevent others to do the same error ? Well, it will take me some time to transform the dts data into code, especially if I want to have some genericity to handle all PXA variants. I'll work on it in the next days/week. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Fri, 04 Jul 2014 21:38:30 +0200 Subject: [PATCH 2/4] dts: add devicetree bindings for pxa27x clocks In-Reply-To: <20140703220328.11380.22037@quantum> (Mike Turquette's message of "Thu, 03 Jul 2014 15:03:28 -0700") References: <1404066744-13416-1-git-send-email-robert.jarzmik@free.fr> <1404066744-13416-3-git-send-email-robert.jarzmik@free.fr> <20140703220328.11380.22037@quantum> Message-ID: <87d2dkoqx5.fsf@free.fr> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Mike Turquette writes: > Quoting Haojian Zhuang (2014-07-02 23:14:33) >> Maybe defining these clocks in pxa27x clock driver is better. > > Agreed. After a long time trying to figure out the best DT binding for > clocks it seems that defining the per-clock data in DTS is not the best > way. The qcom msm and samsung exynos clock bindings and DTS data are > good examples. Ah, I see. Would have been a great comment in the former RFC patch serie, sic ... Maybe a comment in the clock device-tree documentation would prevent others to do the same error ? Well, it will take me some time to transform the dts data into code, especially if I want to have some genericity to handle all PXA variants. I'll work on it in the next days/week. Cheers. -- Robert