From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbaBOXj2 (ORCPT ); Sat, 15 Feb 2014 18:39:28 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:35179 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719AbaBOXj0 (ORCPT ); Sat, 15 Feb 2014 18:39:26 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Linus Torvalds Cc: Al Viro , "Serge E. Hallyn" , Linux-Fsdevel , Kernel Mailing List , Andy Lutomirski , Rob Landley , Miklos Szeredi , Christoph Hellwig , Karel Zak , "J. Bruce Fields" References: <87a9kkax0j.fsf@xmission.com> <8761v7h2pt.fsf@tw-ebiederman.twitter.com> <87li281wx6.fsf_-_@xmission.com> <87ob28kqks.fsf_-_@xmission.com> <87bny8kqik.fsf_-_@xmission.com> <87a9ds55av.fsf@xmission.com> Date: Sat, 15 Feb 2014 15:39:19 -0800 In-Reply-To: <87a9ds55av.fsf@xmission.com> (Eric W. Biederman's message of "Sat, 15 Feb 2014 15:23:20 -0800") Message-ID: <87d2io3pzs.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-AID: U2FsdGVkX1/tUlpTqrJu6W9YO/M5zE0NjNw2LD117Vg= X-SA-Exim-Connect-IP: 98.207.154.105 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 3.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Linus Torvalds X-Spam-Relay-Country: Subject: Re: [PATCH 02/11] vfs: More precise tests in d_invalidate X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 14 Nov 2012 14:26:46 -0700) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ebiederm@xmission.com (Eric W. Biederman) writes: > But when shrink_dcache_parent and check_submounts_and_drop are > effectiely the same function I can't possibly see how you can argue how > the locking has changed or that I am trying to hide things. And in particular the only locking change that I can see at all is that d_walk takes read_seqbegin_or_lock before checking the if the d_subdirs list is empty, which is just an extra cache line read. Which in practical terms appears like I have removed unnecessary special cases in favor less code. Which I think if anything should perform better just because there is less code to run, and what is happening is less obfuscated. Eric