From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
To: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 2/3] netlink: Remove an unused pointer in netlink_skb_parms
Date: Wed, 20 Mar 2013 23:36:24 -0700 [thread overview]
Message-ID: <87d2ut1cpj.fsf@xmission.com> (raw)
In-Reply-To: <a8766c8b116b5e6fcaa932fe94f84a584554b98f.1363815201.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org> (Andy Lutomirski's message of "Wed, 20 Mar 2013 14:38:39 -0700")
net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(in_skb).ssk),
net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk),
net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk),
net/ipv4/udp_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk),
net/ipv4/udp_diag.c: sk_user_ns(NETLINK_CB(in_skb).ssk),
net/netfilter/nfnetlink_log.c: sk_user_ns(NETLINK_CB(skb).ssk));
net/netlink/af_netlink.c: NETLINK_CB(skb).ssk = ssk;
net/sched/cls_flow.c: sk_user_ns(NETLINK_CB(in_skb).ssk) != &init_user_ns)
I count 8 uses.
Eric
>
> diff --git a/include/linux/netlink.h b/include/linux/netlink.h
> index e0f746b..9ac1201 100644
> --- a/include/linux/netlink.h
> +++ b/include/linux/netlink.h
> @@ -19,7 +19,6 @@ struct netlink_skb_parms {
> struct scm_creds creds; /* Skb credentials */
> __u32 portid;
> __u32 dst_group;
> - struct sock *ssk;
> };
>
> #define NETLINK_CB(skb) (*(struct netlink_skb_parms*)&((skb)->cb))
next prev parent reply other threads:[~2013-03-21 6:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 21:38 [PATCH 0/3] Clean up and fix SCM_CREDENTIALS code Andy Lutomirski
[not found] ` <cover.1363815201.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
2013-03-20 21:38 ` [PATCH 1/3] net: Clean up " Andy Lutomirski
2013-03-21 2:15 ` James Morris
[not found] ` <3d7ffb6d9b73971f1a526fc490ef84ef7a33eecc.1363815201.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
2013-03-21 2:15 ` James Morris
2013-03-21 6:54 ` Eric W. Biederman
2013-03-21 6:54 ` Eric W. Biederman
[not found] ` <87k3p1z1iq.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-03-21 17:52 ` Andy Lutomirski
2013-03-20 21:38 ` [PATCH 2/3] netlink: Remove an unused pointer in netlink_skb_parms Andy Lutomirski
[not found] ` <a8766c8b116b5e6fcaa932fe94f84a584554b98f.1363815201.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
2013-03-21 6:36 ` Eric W. Biederman [this message]
[not found] ` <87d2ut1cpj.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-03-21 17:41 ` Andy Lutomirski
2013-03-20 21:38 ` [PATCH 3/3] net: Remove sock_iocb.scm Andy Lutomirski
2013-03-20 21:38 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2ut1cpj.fsf@xmission.com \
--to=ebiederm-as9lmozglivwk0htik3j/w@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.