From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOT2I-0004t5-II for qemu-devel@nongnu.org; Wed, 17 Oct 2012 08:47:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOT2C-00030N-Pa for qemu-devel@nongnu.org; Wed, 17 Oct 2012 08:47:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOT2C-00030H-HW for qemu-devel@nongnu.org; Wed, 17 Oct 2012 08:47:40 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HCldtA011397 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 08:47:39 -0400 From: Markus Armbruster References: <1349275025-5093-1-git-send-email-pbonzini@redhat.com> <1349275025-5093-2-git-send-email-pbonzini@redhat.com> <20121004131456.1741007c@doriath.home> <506DB64D.4030800@redhat.com> <20121004132141.6fbfffce@doriath.home> Date: Wed, 17 Oct 2012 14:47:37 +0200 In-Reply-To: <20121004132141.6fbfffce@doriath.home> (Luiz Capitulino's message of "Thu, 4 Oct 2012 13:21:41 -0300") Message-ID: <87d30h8due.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Paolo Bonzini , qemu-devel@nongnu.org Luiz Capitulino writes: > On Thu, 04 Oct 2012 18:16:13 +0200 > Paolo Bonzini wrote: > >> Il 04/10/2012 18:14, Luiz Capitulino ha scritto: >> >> > +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class, >> >> > + const char *fmt, ...) >> > >> > The function's name makes me expect that something else is done >> > with os_errno >> ^^^^ >> >> Why something "else"? :) > > What I meant is that, it's not clear from the function's name how os_errno > is used. Actually, it gives the impression you're storing errno, but I might > be biased :) > > But again, I don't have any better suggestions. A bit long for my taste, but here goes anyway: error_set_with_errno()