From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585Ab2EGXjn (ORCPT ); Mon, 7 May 2012 19:39:43 -0400 Received: from na3sys009aog108.obsmtp.com ([74.125.149.199]:56379 "EHLO na3sys009aog108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753340Ab2EGXjl convert rfc822-to-8bit (ORCPT ); Mon, 7 May 2012 19:39:41 -0400 From: Kevin Hilman To: "J\, KEERTHY" Cc: "AnilKumar\, Chimata" , "linux-omap\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" , "rjw\@sisk.pl" , "linux-kernel\@vger.kernel.org" , "linux-pm\@lists.linux-foundation.org" , "Pihet-XID\, Jean" Subject: Re: [PATCH V3 04/10] ARM: OMAP3: hwmod: rename the smartreflex entries Organization: Texas Instruments, Inc. References: <1335462041-4949-1-git-send-email-j-keerthy@ti.com> <1335462041-4949-5-git-send-email-j-keerthy@ti.com> <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> Date: Mon, 07 May 2012 16:39:53 -0700 In-Reply-To: (KEERTHY J.'s message of "Fri, 4 May 2012 15:41:34 +0530") Message-ID: <87d36fzhkm.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "J, KEERTHY" writes: > Hi AnilKumar, > > Thanks for reviewing. > > On Fri, May 4, 2012 at 2:00 PM, AnilKumar, Chimata wrote: >> On Thu, Apr 26, 2012 at 23:10:35, J, KEERTHY wrote: >>> From: Jean Pihet >>> >>> Change the name field value to better reflect the smartreflex >>> integration in the system. >>> >>> Signed-off-by: Jean Pihet >>> Signed-off-by: J Keerthy >>> --- >>>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    8 ++++---- >>>  arch/arm/mach-omap2/smartreflex.c          |    2 +- >>>  2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> index 144d118..15907b0 100644 >>> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> @@ -1324,7 +1324,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_mpu_irqs[] = { >>>  }; >>> >>>  static struct omap_hwmod omap34xx_sr1_hwmod = { >>> -     .name           = "sr1", >>> +     .name           = "smartreflex_mpu_iva", >>>       .class          = &omap34xx_smartreflex_hwmod_class, >>>       .main_clk       = "sr1_fck", >>>       .prcm           = { >>> @@ -1342,7 +1342,7 @@ static struct omap_hwmod omap34xx_sr1_hwmod = { >>>  }; >>> >>>  static struct omap_hwmod omap36xx_sr1_hwmod = { >>> -     .name           = "sr1", >>> +     .name           = "smartreflex_mpu_iva", >>>       .class          = &omap36xx_smartreflex_hwmod_class, >>>       .main_clk       = "sr1_fck", >>>       .prcm           = { >>> @@ -1369,7 +1369,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_core_irqs[] = { >>>  }; >>> >>>  static struct omap_hwmod omap34xx_sr2_hwmod = { >>> -     .name           = "sr2", >>> +     .name           = "smartreflex_core", >>>       .class          = &omap34xx_smartreflex_hwmod_class, >>>       .main_clk       = "sr2_fck", >>>       .prcm           = { >>> @@ -1387,7 +1387,7 @@ static struct omap_hwmod omap34xx_sr2_hwmod = { >>>  }; >>> >>>  static struct omap_hwmod omap36xx_sr2_hwmod = { >>> -     .name           = "sr2", >>> +     .name           = "smartreflex_core", >>>       .class          = &omap36xx_smartreflex_hwmod_class, >>>       .main_clk       = "sr2_fck", >>>       .prcm           = { >>> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c >>> index 2edd1e2..d859277 100644 >>> --- a/arch/arm/mach-omap2/smartreflex.c >>> +++ b/arch/arm/mach-omap2/smartreflex.c >>> @@ -183,7 +183,7 @@ static void sr_set_regfields(struct omap_sr *sr) >>>               sr->err_weight = OMAP3430_SR_ERRWEIGHT; >>>               sr->err_maxlimit = OMAP3430_SR_ERRMAXLIMIT; >>>               sr->accum_data = OMAP3430_SR_ACCUMDATA; >>> -             if (!(strcmp(sr->name, "sr1"))) { >>> +             if (!(strcmp(sr->name, "smartreflex_mpu_iva"))) { >> >> What if voltage rail is different for mpu and iva? I have seen some devices >> supports SmartReflex have different voltage rails for mpu and iva. >> > > I get the point. OMAP3 iva and mpu have a common rail. OMAP4 onwards > even we have different rails for mpu and iva. I will enhance the checks here. Rather than enhancing the checks, this SoC specific data should probably just be made part of the SoC specific hwmod dev_attr. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH V3 04/10] ARM: OMAP3: hwmod: rename the smartreflex entries Date: Mon, 07 May 2012 16:39:53 -0700 Message-ID: <87d36fzhkm.fsf@ti.com> References: <1335462041-4949-1-git-send-email-j-keerthy@ti.com> <1335462041-4949-5-git-send-email-j-keerthy@ti.com> <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: (KEERTHY J.'s message of "Fri, 4 May 2012 15:41:34 +0530") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "J, KEERTHY" Cc: "linux-kernel@vger.kernel.org" , "rjw@sisk.pl" , "AnilKumar, Chimata" , "linux-pm@lists.linux-foundation.org" , "linux-omap@vger.kernel.org" , "Pihet-XID, Jean" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-pm@vger.kernel.org IkosIEtFRVJUSFkiIDxqLWtlZXJ0aHlAdGkuY29tPiB3cml0ZXM6Cgo+IEhpIEFuaWxLdW1hciwK Pgo+IFRoYW5rcyBmb3IgcmV2aWV3aW5nLgo+Cj4gT24gRnJpLCBNYXkgNCwgMjAxMiBhdCAyOjAw IFBNLCBBbmlsS3VtYXIsIENoaW1hdGEgPGFuaWxrdW1hckB0aS5jb20+IHdyb3RlOgo+PiBPbiBU aHUsIEFwciAyNiwgMjAxMiBhdCAyMzoxMDozNSwgSiwgS0VFUlRIWSB3cm90ZToKPj4+IEZyb206 IEplYW4gUGloZXQgPGotcGloZXRAdGkuY29tPgo+Pj4KPj4+IENoYW5nZSB0aGUgbmFtZSBmaWVs ZCB2YWx1ZSB0byBiZXR0ZXIgcmVmbGVjdCB0aGUgc21hcnRyZWZsZXgKPj4+IGludGVncmF0aW9u IGluIHRoZSBzeXN0ZW0uCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogSmVhbiBQaWhldCA8ai1waWhl dEB0aS5jb20+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBKIEtlZXJ0aHkgPGota2VlcnRoeUB0aS5jb20+ Cj4+PiAtLS0KPj4+IMKgYXJjaC9hcm0vbWFjaC1vbWFwMi9vbWFwX2h3bW9kXzN4eHhfZGF0YS5j IHwgwqAgwqA4ICsrKystLS0tCj4+PiDCoGFyY2gvYXJtL21hY2gtb21hcDIvc21hcnRyZWZsZXgu YyDCoCDCoCDCoCDCoCDCoHwgwqAgwqAyICstCj4+PiDCoDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNl cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9t YWNoLW9tYXAyL29tYXBfaHdtb2RfM3h4eF9kYXRhLmMgYi9hcmNoL2FybS9tYWNoLW9tYXAyL29t YXBfaHdtb2RfM3h4eF9kYXRhLmMKPj4+IGluZGV4IDE0NGQxMTguLjE1OTA3YjAgMTAwNjQ0Cj4+ PiAtLS0gYS9hcmNoL2FybS9tYWNoLW9tYXAyL29tYXBfaHdtb2RfM3h4eF9kYXRhLmMKPj4+ICsr KyBiL2FyY2gvYXJtL21hY2gtb21hcDIvb21hcF9od21vZF8zeHh4X2RhdGEuYwo+Pj4gQEAgLTEz MjQsNyArMTMyNCw3IEBAIHN0YXRpYyBzdHJ1Y3Qgb21hcF9od21vZF9pcnFfaW5mbyBvbWFwM19z bWFydHJlZmxleF9tcHVfaXJxc1tdID0gewo+Pj4gwqB9Owo+Pj4KPj4+IMKgc3RhdGljIHN0cnVj dCBvbWFwX2h3bW9kIG9tYXAzNHh4X3NyMV9od21vZCA9IHsKPj4+IC0gwqAgwqAgLm5hbWUgwqAg wqAgwqAgwqAgwqAgPSAic3IxIiwKPj4+ICsgwqAgwqAgLm5hbWUgwqAgwqAgwqAgwqAgwqAgPSAi c21hcnRyZWZsZXhfbXB1X2l2YSIsCj4+PiDCoCDCoCDCoCAuY2xhc3MgwqAgwqAgwqAgwqAgwqA9 ICZvbWFwMzR4eF9zbWFydHJlZmxleF9od21vZF9jbGFzcywKPj4+IMKgIMKgIMKgIC5tYWluX2Ns ayDCoCDCoCDCoCA9ICJzcjFfZmNrIiwKPj4+IMKgIMKgIMKgIC5wcmNtIMKgIMKgIMKgIMKgIMKg ID0gewo+Pj4gQEAgLTEzNDIsNyArMTM0Miw3IEBAIHN0YXRpYyBzdHJ1Y3Qgb21hcF9od21vZCBv bWFwMzR4eF9zcjFfaHdtb2QgPSB7Cj4+PiDCoH07Cj4+Pgo+Pj4gwqBzdGF0aWMgc3RydWN0IG9t YXBfaHdtb2Qgb21hcDM2eHhfc3IxX2h3bW9kID0gewo+Pj4gLSDCoCDCoCAubmFtZSDCoCDCoCDC oCDCoCDCoCA9ICJzcjEiLAo+Pj4gKyDCoCDCoCAubmFtZSDCoCDCoCDCoCDCoCDCoCA9ICJzbWFy dHJlZmxleF9tcHVfaXZhIiwKPj4+IMKgIMKgIMKgIC5jbGFzcyDCoCDCoCDCoCDCoCDCoD0gJm9t YXAzNnh4X3NtYXJ0cmVmbGV4X2h3bW9kX2NsYXNzLAo+Pj4gwqAgwqAgwqAgLm1haW5fY2xrIMKg IMKgIMKgID0gInNyMV9mY2siLAo+Pj4gwqAgwqAgwqAgLnByY20gwqAgwqAgwqAgwqAgwqAgPSB7 Cj4+PiBAQCAtMTM2OSw3ICsxMzY5LDcgQEAgc3RhdGljIHN0cnVjdCBvbWFwX2h3bW9kX2lycV9p bmZvIG9tYXAzX3NtYXJ0cmVmbGV4X2NvcmVfaXJxc1tdID0gewo+Pj4gwqB9Owo+Pj4KPj4+IMKg c3RhdGljIHN0cnVjdCBvbWFwX2h3bW9kIG9tYXAzNHh4X3NyMl9od21vZCA9IHsKPj4+IC0gwqAg wqAgLm5hbWUgwqAgwqAgwqAgwqAgwqAgPSAic3IyIiwKPj4+ICsgwqAgwqAgLm5hbWUgwqAgwqAg wqAgwqAgwqAgPSAic21hcnRyZWZsZXhfY29yZSIsCj4+PiDCoCDCoCDCoCAuY2xhc3MgwqAgwqAg wqAgwqAgwqA9ICZvbWFwMzR4eF9zbWFydHJlZmxleF9od21vZF9jbGFzcywKPj4+IMKgIMKgIMKg IC5tYWluX2NsayDCoCDCoCDCoCA9ICJzcjJfZmNrIiwKPj4+IMKgIMKgIMKgIC5wcmNtIMKgIMKg IMKgIMKgIMKgID0gewo+Pj4gQEAgLTEzODcsNyArMTM4Nyw3IEBAIHN0YXRpYyBzdHJ1Y3Qgb21h cF9od21vZCBvbWFwMzR4eF9zcjJfaHdtb2QgPSB7Cj4+PiDCoH07Cj4+Pgo+Pj4gwqBzdGF0aWMg c3RydWN0IG9tYXBfaHdtb2Qgb21hcDM2eHhfc3IyX2h3bW9kID0gewo+Pj4gLSDCoCDCoCAubmFt ZSDCoCDCoCDCoCDCoCDCoCA9ICJzcjIiLAo+Pj4gKyDCoCDCoCAubmFtZSDCoCDCoCDCoCDCoCDC oCA9ICJzbWFydHJlZmxleF9jb3JlIiwKPj4+IMKgIMKgIMKgIC5jbGFzcyDCoCDCoCDCoCDCoCDC oD0gJm9tYXAzNnh4X3NtYXJ0cmVmbGV4X2h3bW9kX2NsYXNzLAo+Pj4gwqAgwqAgwqAgLm1haW5f Y2xrIMKgIMKgIMKgID0gInNyMl9mY2siLAo+Pj4gwqAgwqAgwqAgLnByY20gwqAgwqAgwqAgwqAg wqAgPSB7Cj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC1vbWFwMi9zbWFydHJlZmxleC5j IGIvYXJjaC9hcm0vbWFjaC1vbWFwMi9zbWFydHJlZmxleC5jCj4+PiBpbmRleCAyZWRkMWUyLi5k ODU5Mjc3IDEwMDY0NAo+Pj4gLS0tIGEvYXJjaC9hcm0vbWFjaC1vbWFwMi9zbWFydHJlZmxleC5j Cj4+PiArKysgYi9hcmNoL2FybS9tYWNoLW9tYXAyL3NtYXJ0cmVmbGV4LmMKPj4+IEBAIC0xODMs NyArMTgzLDcgQEAgc3RhdGljIHZvaWQgc3Jfc2V0X3JlZ2ZpZWxkcyhzdHJ1Y3Qgb21hcF9zciAq c3IpCj4+PiDCoCDCoCDCoCDCoCDCoCDCoCDCoCBzci0+ZXJyX3dlaWdodCA9IE9NQVAzNDMwX1NS X0VSUldFSUdIVDsKPj4+IMKgIMKgIMKgIMKgIMKgIMKgIMKgIHNyLT5lcnJfbWF4bGltaXQgPSBP TUFQMzQzMF9TUl9FUlJNQVhMSU1JVDsKPj4+IMKgIMKgIMKgIMKgIMKgIMKgIMKgIHNyLT5hY2N1 bV9kYXRhID0gT01BUDM0MzBfU1JfQUNDVU1EQVRBOwo+Pj4gLSDCoCDCoCDCoCDCoCDCoCDCoCBp ZiAoIShzdHJjbXAoc3ItPm5hbWUsICJzcjEiKSkpIHsKPj4+ICsgwqAgwqAgwqAgwqAgwqAgwqAg aWYgKCEoc3RyY21wKHNyLT5uYW1lLCAic21hcnRyZWZsZXhfbXB1X2l2YSIpKSkgewo+Pgo+PiBX aGF0IGlmIHZvbHRhZ2UgcmFpbCBpcyBkaWZmZXJlbnQgZm9yIG1wdSBhbmQgaXZhPyBJIGhhdmUg c2VlbiBzb21lIGRldmljZXMKPj4gc3VwcG9ydHMgU21hcnRSZWZsZXggaGF2ZSBkaWZmZXJlbnQg dm9sdGFnZSByYWlscyBmb3IgbXB1IGFuZCBpdmEuCj4+Cj4KPiBJIGdldCB0aGUgcG9pbnQuIE9N QVAzIGl2YSBhbmQgbXB1IGhhdmUgYSBjb21tb24gcmFpbC4gT01BUDQgb253YXJkcwo+IGV2ZW4g d2UgaGF2ZSBkaWZmZXJlbnQgcmFpbHMgZm9yIG1wdSBhbmQgaXZhLiBJIHdpbGwgZW5oYW5jZSB0 aGUgY2hlY2tzIGhlcmUuCgpSYXRoZXIgdGhhbiBlbmhhbmNpbmcgdGhlIGNoZWNrcywgdGhpcyBT b0Mgc3BlY2lmaWMgZGF0YSBzaG91bGQgcHJvYmFibHkKanVzdCBiZSBtYWRlIHBhcnQgb2YgdGhl IFNvQyBzcGVjaWZpYyBod21vZCBkZXZfYXR0ci4KCktldmluCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Mon, 07 May 2012 16:39:53 -0700 Subject: [PATCH V3 04/10] ARM: OMAP3: hwmod: rename the smartreflex entries In-Reply-To: (KEERTHY J.'s message of "Fri, 4 May 2012 15:41:34 +0530") References: <1335462041-4949-1-git-send-email-j-keerthy@ti.com> <1335462041-4949-5-git-send-email-j-keerthy@ti.com> <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> Message-ID: <87d36fzhkm.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org "J, KEERTHY" writes: > Hi AnilKumar, > > Thanks for reviewing. > > On Fri, May 4, 2012 at 2:00 PM, AnilKumar, Chimata wrote: >> On Thu, Apr 26, 2012 at 23:10:35, J, KEERTHY wrote: >>> From: Jean Pihet >>> >>> Change the name field value to better reflect the smartreflex >>> integration in the system. >>> >>> Signed-off-by: Jean Pihet >>> Signed-off-by: J Keerthy >>> --- >>> ?arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | ? ?8 ++++---- >>> ?arch/arm/mach-omap2/smartreflex.c ? ? ? ? ?| ? ?2 +- >>> ?2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> index 144d118..15907b0 100644 >>> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> @@ -1324,7 +1324,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_mpu_irqs[] = { >>> ?}; >>> >>> ?static struct omap_hwmod omap34xx_sr1_hwmod = { >>> - ? ? .name ? ? ? ? ? = "sr1", >>> + ? ? .name ? ? ? ? ? = "smartreflex_mpu_iva", >>> ? ? ? .class ? ? ? ? ?= &omap34xx_smartreflex_hwmod_class, >>> ? ? ? .main_clk ? ? ? = "sr1_fck", >>> ? ? ? .prcm ? ? ? ? ? = { >>> @@ -1342,7 +1342,7 @@ static struct omap_hwmod omap34xx_sr1_hwmod = { >>> ?}; >>> >>> ?static struct omap_hwmod omap36xx_sr1_hwmod = { >>> - ? ? .name ? ? ? ? ? = "sr1", >>> + ? ? .name ? ? ? ? ? = "smartreflex_mpu_iva", >>> ? ? ? .class ? ? ? ? ?= &omap36xx_smartreflex_hwmod_class, >>> ? ? ? .main_clk ? ? ? = "sr1_fck", >>> ? ? ? .prcm ? ? ? ? ? = { >>> @@ -1369,7 +1369,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_core_irqs[] = { >>> ?}; >>> >>> ?static struct omap_hwmod omap34xx_sr2_hwmod = { >>> - ? ? .name ? ? ? ? ? = "sr2", >>> + ? ? .name ? ? ? ? ? = "smartreflex_core", >>> ? ? ? .class ? ? ? ? ?= &omap34xx_smartreflex_hwmod_class, >>> ? ? ? .main_clk ? ? ? = "sr2_fck", >>> ? ? ? .prcm ? ? ? ? ? = { >>> @@ -1387,7 +1387,7 @@ static struct omap_hwmod omap34xx_sr2_hwmod = { >>> ?}; >>> >>> ?static struct omap_hwmod omap36xx_sr2_hwmod = { >>> - ? ? .name ? ? ? ? ? = "sr2", >>> + ? ? .name ? ? ? ? ? = "smartreflex_core", >>> ? ? ? .class ? ? ? ? ?= &omap36xx_smartreflex_hwmod_class, >>> ? ? ? .main_clk ? ? ? = "sr2_fck", >>> ? ? ? .prcm ? ? ? ? ? = { >>> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c >>> index 2edd1e2..d859277 100644 >>> --- a/arch/arm/mach-omap2/smartreflex.c >>> +++ b/arch/arm/mach-omap2/smartreflex.c >>> @@ -183,7 +183,7 @@ static void sr_set_regfields(struct omap_sr *sr) >>> ? ? ? ? ? ? ? sr->err_weight = OMAP3430_SR_ERRWEIGHT; >>> ? ? ? ? ? ? ? sr->err_maxlimit = OMAP3430_SR_ERRMAXLIMIT; >>> ? ? ? ? ? ? ? sr->accum_data = OMAP3430_SR_ACCUMDATA; >>> - ? ? ? ? ? ? if (!(strcmp(sr->name, "sr1"))) { >>> + ? ? ? ? ? ? if (!(strcmp(sr->name, "smartreflex_mpu_iva"))) { >> >> What if voltage rail is different for mpu and iva? I have seen some devices >> supports SmartReflex have different voltage rails for mpu and iva. >> > > I get the point. OMAP3 iva and mpu have a common rail. OMAP4 onwards > even we have different rails for mpu and iva. I will enhance the checks here. Rather than enhancing the checks, this SoC specific data should probably just be made part of the SoC specific hwmod dev_attr. Kevin