From mboxrd@z Thu Jan 1 00:00:00 1970 From: kuninori.morimoto.gx@renesas.com Subject: Re: ALSA become "Segmentation fault" on current linus tree Date: Tue, 05 Jul 2011 15:07:28 +0900 Message-ID: <87d3hpfefz.wl%kuninori.morimoto.gx@renesas.com> References: <87k4bxfjue.wl%kuninori.morimoto.gx@renesas.com> <87ei25fewa.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-iy0-f179.google.com (mail-iy0-f179.google.com [209.85.210.179]) by alsa0.perex.cz (Postfix) with ESMTP id 0128B245C8 for ; Tue, 5 Jul 2011 08:07:32 +0200 (CEST) Received: by iyn35 with SMTP id 35so5499753iyn.38 for ; Mon, 04 Jul 2011 23:07:32 -0700 (PDT) In-Reply-To: <87ei25fewa.wl%kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai , Mark Brown , Liam Girdwood Cc: Linux-ALSA , Kuninori Morimoto List-Id: alsa-devel@alsa-project.org Dear Takashi, Liam, Mark > Thanks for your reply > > > Hm, this should have been fixed by the later commit: > > commit 2b39535b9e54888649923beaab443af212b6c0fd > > Author: Jarkko Nikula > > Date: Fri May 20 15:47:40 2011 +0300 > > > > ASoC: core: Don't set "(null)" as a driver name > > > > Could you check whether the segfault occurs at this point? > > It's possible that another bug was introduced after it, of course. > > Hmm... > segfault still happen on this commit. Is this become hint ? my kernel boot log is -------------- ... fsi-pcm-audio sh_fsi2: clocks managed by runtime pm ak4642-codec 0-0013: AK4642 Audio Codec 0.0.1 asoc: ak4642-hifi <-> fsia-dai mapping ok sh-mobile-hdmi sh-mobile-hdmi: SH Mobile HDMI Audio Codec asoc: sh_mobile_hdmi-hifi <-> fsib-dai mapping ok ALSA device list: #0: FSI2A (AK4643) #1: FSI2B (SH MOBILE HDMI) -------------- I don't know why, but the segfault didn't happen if I applied below patch ------------------- diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index bb7cd58..e84bf6d 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1929,8 +1929,8 @@ static void snd_soc_instantiate_card(struct snd_soc_card * "%s", card->name); snprintf(card->snd_card->longname, sizeof(card->snd_card->longname), "%s", card->long_name ? card->long_name : card->name); - snprintf(card->snd_card->driver, sizeof(card->snd_card->driver), - "%s", card->driver_name ? card->driver_name : card->name); +// snprintf(card->snd_card->driver, sizeof(card->snd_card->driver), +// "%s", card->driver_name ? card->driver_name : card->name); if (card->late_probe) { ret = card->late_probe(card); ------------------- Best regards --- Kuninori Morimoto