From: Archit Taneja <architt@codeaurora.org>
To: John Stultz <john.stultz@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] drm/bridge: adv7511: Properly update EDID when no EDID was found
Date: Thu, 7 Sep 2017 11:01:47 +0530 [thread overview]
Message-ID: <87e608f4-b700-4937-6689-9717102a2f8c@codeaurora.org> (raw)
In-Reply-To: <CALAqxLVpjynY-ogdPpVw1gsqPpiootok4z=eYWwqWWw5DbAUwg@mail.gmail.com>
On 09/05/2017 10:14 PM, John Stultz wrote:
> On Tue, Sep 5, 2017 at 5:10 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>> Currently adv7511_get_modes() bails out early when no EDID could be
>> retrieved. This leaves the previous EDID in place, which is typically not
>> the intended behavior and might confuse applications. Instead the EDID
>> should be cleared when no EDID could be retrieved.
>>
>> All functions that are called after the EDID check handle the case where
>> the EDID is NULL just fine and exhibit the expected behavior, so just drop
>> the check.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>
> No objections from me. Ran these on my HiKey board ontop of Linus's
> HEAD, and everything seemed ok.
>
> So for the whole patchset:
> Tested-by: John Stultz <john.stultz@linaro.org>
The set looks good to me too. I'll queue it to drm-misc-next in a few days.
Thanks,
Archit
>
> thanks
> -john
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-09-07 5:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 12:10 [PATCH 1/4] drm/bridge: adv7511: Properly update EDID when no EDID was found Lars-Peter Clausen
2017-09-05 12:10 ` [PATCH 2/4] drm/bridge: adv7511: Remove private copy of the EDID Lars-Peter Clausen
2017-09-05 12:10 ` [PATCH 3/4] drm/bridge: adv7511: Enable connector polling when no interrupt is specified Lars-Peter Clausen
2017-09-05 12:10 ` [PATCH 4/4] drm/bridge: adv7511: Constify HDMI CODEC platform data Lars-Peter Clausen
2017-09-05 16:44 ` [PATCH 1/4] drm/bridge: adv7511: Properly update EDID when no EDID was found John Stultz
2017-09-07 5:31 ` Archit Taneja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87e608f4-b700-4937-6689-9717102a2f8c@codeaurora.org \
--to=architt@codeaurora.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=lars@metafoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.