From: <Amy.Shih@advantech.com.tw>
To: <she90122@gmail.com>
Cc: <amy.shih@advantech.com.tw>, <oakley.ding@advantech.com.tw>,
<jia.sui@advantech.com.cn>, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>, <linux-hwmon@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [v2 5/9] hwmon: (nct7904) Fix incorrect register bit mapping of temperature alarm.
Date: Mon, 17 Jun 2019 08:12:30 +0000 [thread overview]
Message-ID: <87e748a5f2e7d8e6ef69fa5acb177cb0a1474cb2.1560756733.git.amy.shih@advantech.com.tw> (raw)
In-Reply-To: <928e46508bbe1ebc0763c3d2403a5aebe95af552.1560756733.git.amy.shih@advantech.com.tw>
From: "amy.shih" <amy.shih@advantech.com.tw>
In function nct7904_read_temp, the bit to shift for register
SMI_STS1_REG should be bit 1 & 3 & 5 &7 for TEMP_CH1~4.
Signed-off-by: amy.shih <amy.shih@advantech.com.tw>
---
Changes in v2:
- Fix incorrect register bit mapping of temperature alarm.
drivers/hwmon/nct7904.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
index 402c1bb2a99f..95348eebe8e4 100644
--- a/drivers/hwmon/nct7904.c
+++ b/drivers/hwmon/nct7904.c
@@ -356,7 +356,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
SMI_STS1_REG);
if (ret < 0)
return ret;
- *val = (ret >> (channel & 0x07)) & 1;
+ *val = (ret >> (((channel * 2) + 1) & 0x07)) & 1;
} else {
if ((channel - 5) < 4) {
ret = nct7904_read_reg(data, BANK_0,
--
2.17.1
next prev parent reply other threads:[~2019-06-17 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 8:08 [v2 1/9] hwmon: (nct7904) Add error handling in probe function Amy.Shih
2019-06-17 8:10 ` [v2 2/9] hwmon: (nct7904) Changes comments " Amy.Shih
2019-06-17 8:11 ` [v2 3/9] hwmon: (nct7904) Add extra sysfs support for fan, voltage and temperature Amy.Shih
2019-06-17 8:11 ` [v2 4/9] hwmon: (nct7904) Fix incorrect register setting for the high value high limit of voltage Amy.Shih
2019-06-17 8:12 ` Amy.Shih [this message]
2019-06-17 8:14 ` [v2 6/9] hwmon: (nct7904) Fix wrong return code in function nct7904_write_fan Amy.Shih
2019-06-17 8:15 ` [v2 7/9] hwmon: (nct7904) Delete wrong comment in function nct7904_write_in Amy.Shih
2019-06-17 8:16 ` [v2 8/9] hwmon: (nct7904) Fix wrong attribute names for temperature Amy.Shih
2019-06-17 8:20 ` Amy.Shih
2019-06-17 8:22 ` [v2 9/9] hwmon: (nct7904) Fix wrong registers setting " Amy.Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87e748a5f2e7d8e6ef69fa5acb177cb0a1474cb2.1560756733.git.amy.shih@advantech.com.tw \
--to=amy.shih@advantech.com.tw \
--cc=jdelvare@suse.com \
--cc=jia.sui@advantech.com.cn \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oakley.ding@advantech.com.tw \
--cc=she90122@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.