From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 875E5C4345F for ; Wed, 24 Apr 2024 07:48:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzXMH-00028p-Ma; Wed, 24 Apr 2024 03:48:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzXMG-00028X-RH for qemu-devel@nongnu.org; Wed, 24 Apr 2024 03:48:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzXME-0001EW-HI for qemu-devel@nongnu.org; Wed, 24 Apr 2024 03:48:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713944878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kUpy5at5Thg7QVdKDZVN120+azrVQPJiCHoT3CGUSpg=; b=EUnV4ifIUtXTWIwl6H7ozp9r934U6rh3VQxYeI+Mwp143cS4rXgB8t5ZDsYadK2dJFPCIK 3AsWomcsZTPqFtl8UYmb0YVZHD57R0oJia1n7dSJj27v1l36NzvkxdbutDPaQbWYoY6ich syuKux+y5ApACVdjkH8NpGQbmqiiVOg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-S62NRE5-PE2S2rKIONwXzQ-1; Wed, 24 Apr 2024 03:44:24 -0400 X-MC-Unique: S62NRE5-PE2S2rKIONwXzQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 24EA6812C58; Wed, 24 Apr 2024 07:44:23 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.247]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD9252166B31; Wed, 24 Apr 2024 07:44:22 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id ECEC921E66C8; Wed, 24 Apr 2024 09:44:21 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Artyom Tarasenko , Chris Wulff , "Edgar E. Iglesias" , Marek Vasut , Max Filippov , "Dr . David Alan Gilbert" , Jiaxun Yang , Nicholas Piggin , Paolo Bonzini , Daniel Henrique Barboza , Yoshinori Sato , Richard Henderson , qemu-ppc@nongnu.org, Laurent Vivier , Mark Cave-Ayland Subject: Re: [PATCH-for-9.1 16/21] target/sparc: Replace qemu_printf() by monitor_printf() in monitor In-Reply-To: <20240321154838.95771-17-philmd@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Thu, 21 Mar 2024 16:48:32 +0100") References: <20240321154838.95771-1-philmd@linaro.org> <20240321154838.95771-17-philmd@linaro.org> Date: Wed, 24 Apr 2024 09:44:21 +0200 Message-ID: <87edav433e.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.67, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > Replace qemu_printf() by monitor_printf() in monitor.c. > Rename dump_mmu() as sparc_dump_mmu(). > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Same "why?" and "suggest to mention passing current monitor" as for PATCH 05. In addition: > --- > target/sparc/cpu.h | 2 +- > target/sparc/ldst_helper.c | 18 +++---- > target/sparc/mmu_helper.c | 102 ++++++++++++++++++------------------- > target/sparc/monitor.c | 2 +- > 4 files changed, 62 insertions(+), 62 deletions(-) > > diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h > index f3cdd17c62..55589c8ae4 100644 > --- a/target/sparc/cpu.h > +++ b/target/sparc/cpu.h > @@ -601,7 +601,7 @@ bool sparc_cpu_tlb_fill(CPUState *cs, vaddr address, = int size, > MMUAccessType access_type, int mmu_idx, > bool probe, uintptr_t retaddr); > target_ulong mmu_probe(CPUSPARCState *env, target_ulong address, int mmu= lev); > -void dump_mmu(CPUSPARCState *env); > +void sparc_dump_mmu(Monitor *mon, CPUSPARCState *env); >=20=20 > #if !defined(TARGET_SPARC64) && !defined(CONFIG_USER_ONLY) > int sparc_cpu_memory_rw_debug(CPUState *cpu, vaddr addr, > diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c > index 064390d1d4..44f8b2bb7a 100644 > --- a/target/sparc/ldst_helper.c > +++ b/target/sparc/ldst_helper.c > @@ -195,7 +195,7 @@ static void demap_tlb(SparcTLBEntry *tlb, target_ulon= g demap_addr, > replace_tlb_entry(&tlb[i], 0, 0, env1); > #ifdef DEBUG_MMU > DPRINTF_MMU("%s demap invalidated entry [%02u]\n", strmmu, i= ); > - dump_mmu(env1); > + sparc_dump_mmu(env1); You add a parameter below. I don't think this compiles :) Several more instances follow. > #endif > } > } [...] With that fixed Reviewed-by: Markus Armbruster