From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B378FC77B7A for ; Tue, 13 Jun 2023 08:18:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239031AbjFMISb (ORCPT ); Tue, 13 Jun 2023 04:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234523AbjFMISa (ORCPT ); Tue, 13 Jun 2023 04:18:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C2A2EA for ; Tue, 13 Jun 2023 01:18:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9CE336109A for ; Tue, 13 Jun 2023 08:18:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46EC6C433D2; Tue, 13 Jun 2023 08:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686644309; bh=2CT0RsKHdy9H78RC79+0zcuBYFt+2jfocKa7673XWVs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=l6kSonhl+du/a9J/VsYEER8jwFuZDaZDwm3Y2JJ4YAvPGTrDrmrI83k3C/UlcIoqi mOJZMtgVQeeD+a6Xwntb5knTOyqLpunKBVtJZpgrS5onld1h4wWnRQYwZs/WL7ViXt cNZlG3b9RQ3CEePaZmmGKg2WkAi5Z9+ERDW31eqjGn5sSs3GvBpzak3dxaZfzFRv+U KM6e/lyfTdO2L+9g+DF6FdPQ/cGzKAsRmZkrgUAxkRlo2rciVWFbhRigF+XuRRDaFI uWbBH70hK6SNP3Azq3KktMoxJRfiPXC2SzaT/k5Ula6i8vLta4Uf78qbQPLyobWyXB cnNRM4KeOQ4Zg== From: Kalle Valo To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org Subject: Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused References: <20230601105215.27013-1-dmantipov@yandex.ru> Date: Tue, 13 Jun 2023 11:18:25 +0300 In-Reply-To: <20230601105215.27013-1-dmantipov@yandex.ru> (Dmitry Antipov's message of "Thu, 1 Jun 2023 13:52:15 +0300") Message-ID: <87edmfepwu.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov writes: > According to Ping-Ke Shih, it may be unsafe to remove BB register reads > even if we don't interested in their values. OTOH such a reads may confuse > compilers (when the most strictness warning options are enabled) and/or > static analysis tools. So it may be helpful to convert related calls of > 'rtl_get_bbreg()' to 'void' and mark such a cases with special comment > just to make them easier to find and maybe even fix in the future. > > This is generally inspired by 6c75eab0417b9e5b05a18dbfc373e27a8ef876d8. > > Suggested-by: Ping-Ke Shih > Signed-off-by: Dmitry Antipov "wifi:" missing from the title, see the wiki link below for more info. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches