From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6952ECAAD8 for ; Tue, 20 Sep 2022 14:33:04 +0000 (UTC) Received: from localhost ([::1]:56004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaeJ5-0001LC-7N for qemu-devel@archiver.kernel.org; Tue, 20 Sep 2022 10:33:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oabYn-0000E2-C1 for qemu-devel@nongnu.org; Tue, 20 Sep 2022 07:37:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oabYe-0001VR-3o for qemu-devel@nongnu.org; Tue, 20 Sep 2022 07:37:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663673815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q9Kiy75k/GjyNcX5/jFVpAejSl+0Eo6vMfAUPlGa7+Q=; b=YNLOgLJ3y3TbmFBmF/gdP8Xdk0KoaQW5bsjzmRvPxMazs49OX9f2kORQLMFm3TGm3lWE9I lBA5EHIL0pZGHZ/WuwHvh7ZZD7Ppd//XHlb1ZuorrcFGI8xputyIjC7xbSz2QUYAe/QrR6 Wq2UIEWvNI+PUMAp8yxRupBruk+mwBY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-nyyOMpweMKOJOc5LnI28Bw-1; Tue, 20 Sep 2022 07:36:52 -0400 X-MC-Unique: nyyOMpweMKOJOc5LnI28Bw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C1DF3810D23; Tue, 20 Sep 2022 11:36:50 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF591112131E; Tue, 20 Sep 2022 11:36:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A0E0D21E6900; Tue, 20 Sep 2022 13:36:47 +0200 (CEST) From: Markus Armbruster To: Alistair Francis , Bin Meng , Palmer Dabbelt Cc: Bernhard Beschow , "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Christian Borntraeger , =?utf-8?Q?C=C3=A9dri?= =?utf-8?Q?c?= Le Goater , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?utf-8?Q?Herv=C3=A9?= Poussineau , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> Date: Tue, 20 Sep 2022 13:36:47 +0200 In-Reply-To: (Alistair Francis's message of "Tue, 20 Sep 2022 09:31:10 +1000") Message-ID: <87edw6xoog.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Alistair Francis writes: > On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: >> >> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to >> inherit from TYPE_MACHINE. This is an inconsistency which can cause >> undefined behavior such as memory corruption. >> >> Change SiFiveEState to inherit from MachineState since it is registered >> as a machine. >> >> Signed-off-by: Bernhard Beschow > > Reviewed-by: Alistair Francis To the SiFive maintainers: since this is a bug fix, let's merge it right away.