From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: avoid uninit memory read in ath9k_htc_rx_msg()
Date: Tue, 16 Aug 2022 15:58:18 +0200 [thread overview]
Message-ID: <87edxgwarp.fsf@toke.dk> (raw)
In-Reply-To: <e0bcd6d4-4029-4ab3-0405-054d26262f64@I-love.SAKURA.ne.jp>
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> writes:
> On 2022/07/30 21:13, Tetsuo Handa wrote:
>> We have two choices. One is to workaround by adding __GFP_ZERO so that
>> ath9k_htc_rx_msg() sees 0 if pkt_len is invalid. The other is to let
>> ath9k_htc_rx_msg() validate pkt_len before accessing.
>
> Which choice do we want to go?
I prefer the explicit length checks as you do in your patch. Could you
please resend with an updated commit message making it explicit that
this is the choice this patch is going with?
-Toke
next prev parent reply other threads:[~2022-08-16 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 16:27 KMSAN: uninit-value in ath9k_htc_rx_msg syzbot
2020-08-13 3:32 ` syzbot
[not found] ` <a142d63c-7810-40ff-9c24-7160c63bafebn@googlegroups.com>
2022-08-24 13:30 ` Alexander Potapenko
2022-08-25 14:34 ` Tetsuo Handa
2022-08-25 15:09 ` Alexander Potapenko
2022-08-25 15:55 ` Toke Høiland-Jørgensen
2022-08-29 5:36 ` Kalle Valo
2022-08-26 1:35 ` Tetsuo Handa
2022-08-26 8:38 ` Alexander Potapenko
2022-08-28 10:44 ` Phillip Potter
2022-07-30 12:13 ` [PATCH] ath9k: avoid uninit memory read in ath9k_htc_rx_msg() Tetsuo Handa
2022-07-30 13:36 ` Tetsuo Handa
2022-08-16 9:52 ` Tetsuo Handa
2022-08-16 13:58 ` Toke Høiland-Jørgensen [this message]
2022-08-16 14:46 ` [PATCH v2] " Tetsuo Handa
2022-08-16 16:38 ` Toke Høiland-Jørgensen
2022-08-30 12:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edxgwarp.fsf@toke.dk \
--to=toke@toke.dk \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.