From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use drm_dbg for rpm logging
Date: Wed, 11 May 2022 21:16:33 -0700 [thread overview]
Message-ID: <87ee0z75cu.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220511130455.22028-1-anshuman.gupta@intel.com>
On Wed, 11 May 2022 06:04:54 -0700, Anshuman Gupta wrote:
>
> RPM suspend/resume also supported on gfx platforms which doesn't have
> kms support and even on platforms without any connected display panel.
> There is no good reason to log rpm suspend/resume debug message with
> drm_dbg_kms() therefore changing it to drm_dbg().
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index 90b0ce5051af..ed6028fd442d 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -1549,7 +1549,7 @@ static int intel_runtime_suspend(struct device *kdev)
> if (drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_RUNTIME_PM(dev_priv)))
> return -ENODEV;
>
> - drm_dbg_kms(&dev_priv->drm, "Suspending device\n");
> + drm_dbg(&dev_priv->drm, "Suspending device\n");
>
> disable_rpm_wakeref_asserts(rpm);
>
> @@ -1625,7 +1625,7 @@ static int intel_runtime_suspend(struct device *kdev)
> if (!IS_VALLEYVIEW(dev_priv) && !IS_CHERRYVIEW(dev_priv))
> intel_hpd_poll_enable(dev_priv);
>
> - drm_dbg_kms(&dev_priv->drm, "Device suspended\n");
> + drm_dbg(&dev_priv->drm, "Device suspended\n");
> return 0;
> }
>
> @@ -1639,7 +1639,7 @@ static int intel_runtime_resume(struct device *kdev)
> if (drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_RUNTIME_PM(dev_priv)))
> return -ENODEV;
>
> - drm_dbg_kms(&dev_priv->drm, "Resuming device\n");
> + drm_dbg(&dev_priv->drm, "Resuming device\n");
>
> drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm->wakeref_count));
> disable_rpm_wakeref_asserts(rpm);
> @@ -1683,7 +1683,7 @@ static int intel_runtime_resume(struct device *kdev)
> drm_err(&dev_priv->drm,
> "Runtime resume failed, disabling it (%d)\n", ret);
> else
> - drm_dbg_kms(&dev_priv->drm, "Device resumed\n");
> + drm_dbg(&dev_priv->drm, "Device resumed\n");
>
> return ret;
> }
> --
> 2.26.2
>
next prev parent reply other threads:[~2022-05-12 4:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:04 [Intel-gfx] [PATCH] drm/i915: Use drm_dbg for rpm logging Anshuman Gupta
2022-05-11 15:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-05-11 20:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-05-12 4:16 ` Dixit, Ashutosh [this message]
2022-05-16 11:56 ` [Intel-gfx] [PATCH] " Gupta, Anshuman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee0z75cu.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.