From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFB6C433EF for ; Tue, 30 Nov 2021 12:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230420AbhK3Mso (ORCPT ); Tue, 30 Nov 2021 07:48:44 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:40752 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbhK3Msf (ORCPT ); Tue, 30 Nov 2021 07:48:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 30848B818B1; Tue, 30 Nov 2021 12:45:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0DBFC53FC1; Tue, 30 Nov 2021 12:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638276313; bh=ie6jGMCQkD1j8a29bDYEYEewpWAyFPXNvL9ShIZZXEw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ed4jNze52Kz9LERDwMESSwaUoaCZaARAsXdhFsXPDTSjzXFKdFbBzu8mO/MFA3V5D cW+u7AF4ob1AyVYwcme8NpV7O8YBenpCvcYJxVrf7ZjhW76r1aj3KzD0jL7Gig7c5f 2h5nH3NcBzpQNmN29eiKJeOHlWoIE1lVx59Rjri+G+YKatY1VAcm5HYbx249JDIeWP /e7ChdhqyyDR8mzrAQRHfL+aEBPiHujU0G/kuuw7WepC5ppKeO+nVpNBfdl/+uN408 /HG+RhYD2hbbJ5qvqQBo4lmud68QcCGzhwzOfZMlzHaaa77/DwB1t4PfM5Ey1l7y0G qC9HMzxtqwstA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ms2VT-008sOU-Nf; Tue, 30 Nov 2021 12:45:11 +0000 Date: Tue, 30 Nov 2021 12:45:11 +0000 Message-ID: <87ee6xn76w.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Pali =?UTF-8?B?Um9ow6Fy?= , Alyssa Rosenzweig , Mark Kettenis , Luca Ceresoli , kernel-team@android.com, Arnd Bergmann Subject: Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes In-Reply-To: <20211130121237.GB3355@lpieralisi> References: <20211123180636.80558-1-maz@kernel.org> <20211130115632.GA3355@lpieralisi> <20211130121237.GB3355@lpieralisi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, bhelgaas@google.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, pali@kernel.org, alyssa@rosenzweig.io, mark.kettenis@xs4all.nl, luca@lucaceresoli.net, kernel-team@android.com, arnd@arndb.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Arnd, On Tue, 30 Nov 2021 12:12:37 +0000, Lorenzo Pieralisi wrote: > > On Tue, Nov 30, 2021 at 11:59:32AM +0000, Marc Zyngier wrote: > > Hi Lorenzo, Bjorn, > > > > On 2021-11-30 11:56, Lorenzo Pieralisi wrote: > > > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote: > > > > Apologies for the rapid fire (I tend to be much more conservative when > > > > resending series), but given that this series has a direct impact on > > > > other projects (such as u-boot), I'm trying to converge as quickly as > > > > possible. > > > > > > > > This series aims at fixing a number of issues for the recently merged > > > > Apple PCIe driver, all revolving around the mishandling of #PERST: > > > > > > > > - we didn't properly drive #PERST, and we didn't follow the specified > > > > timings > > > > > > > > - the DT had the wrong polarity, which has impacts on the driver > > > > itself > > > > > > > > Hopefully, this should address all the issues reported so far. > > > > > > > > * From v2: > > > > - Fixed DT > > > > - Fixed #PERST polarity in the driver > > > > - Collected Pali's ack on patch #1 > > > > > > > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org > > > > > > > > Marc Zyngier (3): > > > > PCI: apple: Follow the PCIe specifications when resetting the port > > > > arm64: dts: apple: t8103: Fix PCIe #PERST polarity > > > > PCI: apple: Fix #PERST polarity > > > > > > > > arch/arm64/boot/dts/apple/t8103.dtsi | 7 ++++--- > > > > drivers/pci/controller/pcie-apple.c | 12 +++++++++++- > > > > 2 files changed, 15 insertions(+), 4 deletions(-) > > > > > > Hi Bjorn, > > > > > > this series is v5.16-rcX material for PCI fixes, can you pick patches > > > 1,3 > > > up please ? > > > > Do you mind picking patch #2 as well? Or shall I route it somewhere else? > > We were told that we should not pick up dts changes, they would normally > go via the ARM SOC team, not sure whether the fixes policy is different > though but I suspect that's not the case. OK. Doesn't really help with keeping these two commit close together, but hey, if that can't be helped... Arnd, do you mind picking up patch #2 as a 5.16 fix? Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26546C433F5 for ; Tue, 30 Nov 2021 12:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W04ySOKfiHYfn162LAX7S6oXNz3R4vHp3oHqo44MPx0=; b=D2mDuJpxcxcs2m uGRTj4zEUi3WW5MGZv6LL40J4e+VNUn5iHw2Sy5XeJFWDd/hi7dnXafYlLf9GOfj19PO+ieTbwO2K OBjOGJTZj0FCKxw88PLzrR9ayFvm01cdOCjNo48+HR7iwVufla2dVe7RDXMs4eJI8M4dBduFJOPrn YEX6ixPKF7HCVcsn/eNsYEvvLkDwU/M5/t0ChEeeDM9MzXZAQWdNTOfrffmigLyaYez4aJ4FWh91C LA80iz07oh2tcZet6RGB24Q5ji96myZ90M7PQpLJw+6o9UqwfHgxypjze54ZYdM3jL6k2ergeitVs /C5CSGyg4W+3bSFTvVlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms2Vc-005AWK-OT; Tue, 30 Nov 2021 12:45:20 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms2VY-005AVa-Af for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 12:45:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 00289B819D3; Tue, 30 Nov 2021 12:45:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0DBFC53FC1; Tue, 30 Nov 2021 12:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638276313; bh=ie6jGMCQkD1j8a29bDYEYEewpWAyFPXNvL9ShIZZXEw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ed4jNze52Kz9LERDwMESSwaUoaCZaARAsXdhFsXPDTSjzXFKdFbBzu8mO/MFA3V5D cW+u7AF4ob1AyVYwcme8NpV7O8YBenpCvcYJxVrf7ZjhW76r1aj3KzD0jL7Gig7c5f 2h5nH3NcBzpQNmN29eiKJeOHlWoIE1lVx59Rjri+G+YKatY1VAcm5HYbx249JDIeWP /e7ChdhqyyDR8mzrAQRHfL+aEBPiHujU0G/kuuw7WepC5ppKeO+nVpNBfdl/+uN408 /HG+RhYD2hbbJ5qvqQBo4lmud68QcCGzhwzOfZMlzHaaa77/DwB1t4PfM5Ey1l7y0G qC9HMzxtqwstA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ms2VT-008sOU-Nf; Tue, 30 Nov 2021 12:45:11 +0000 Date: Tue, 30 Nov 2021 12:45:11 +0000 Message-ID: <87ee6xn76w.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Pali =?UTF-8?B?Um9ow6Fy?= , Alyssa Rosenzweig , Mark Kettenis , Luca Ceresoli , kernel-team@android.com, Arnd Bergmann Subject: Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes In-Reply-To: <20211130121237.GB3355@lpieralisi> References: <20211123180636.80558-1-maz@kernel.org> <20211130115632.GA3355@lpieralisi> <20211130121237.GB3355@lpieralisi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, bhelgaas@google.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, pali@kernel.org, alyssa@rosenzweig.io, mark.kettenis@xs4all.nl, luca@lucaceresoli.net, kernel-team@android.com, arnd@arndb.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_044516_675494_B7F8FCC9 X-CRM114-Status: GOOD ( 31.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Arnd, On Tue, 30 Nov 2021 12:12:37 +0000, Lorenzo Pieralisi wrote: > > On Tue, Nov 30, 2021 at 11:59:32AM +0000, Marc Zyngier wrote: > > Hi Lorenzo, Bjorn, > > > > On 2021-11-30 11:56, Lorenzo Pieralisi wrote: > > > On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote: > > > > Apologies for the rapid fire (I tend to be much more conservative when > > > > resending series), but given that this series has a direct impact on > > > > other projects (such as u-boot), I'm trying to converge as quickly as > > > > possible. > > > > > > > > This series aims at fixing a number of issues for the recently merged > > > > Apple PCIe driver, all revolving around the mishandling of #PERST: > > > > > > > > - we didn't properly drive #PERST, and we didn't follow the specified > > > > timings > > > > > > > > - the DT had the wrong polarity, which has impacts on the driver > > > > itself > > > > > > > > Hopefully, this should address all the issues reported so far. > > > > > > > > * From v2: > > > > - Fixed DT > > > > - Fixed #PERST polarity in the driver > > > > - Collected Pali's ack on patch #1 > > > > > > > > [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org > > > > > > > > Marc Zyngier (3): > > > > PCI: apple: Follow the PCIe specifications when resetting the port > > > > arm64: dts: apple: t8103: Fix PCIe #PERST polarity > > > > PCI: apple: Fix #PERST polarity > > > > > > > > arch/arm64/boot/dts/apple/t8103.dtsi | 7 ++++--- > > > > drivers/pci/controller/pcie-apple.c | 12 +++++++++++- > > > > 2 files changed, 15 insertions(+), 4 deletions(-) > > > > > > Hi Bjorn, > > > > > > this series is v5.16-rcX material for PCI fixes, can you pick patches > > > 1,3 > > > up please ? > > > > Do you mind picking patch #2 as well? Or shall I route it somewhere else? > > We were told that we should not pick up dts changes, they would normally > go via the ARM SOC team, not sure whether the fixes policy is different > though but I suspect that's not the case. OK. Doesn't really help with keeping these two commit close together, but hey, if that can't be helped... Arnd, do you mind picking up patch #2 as a 5.16 fix? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel