[Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"

[Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"

[Fabrice Fontaine]

This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
will never be triggered. Moreover, libressl provides a pkg-config file.

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libshout/libshout.mk | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/package/libshout/libshout.mk b/package/libshout/libshout.mk
index 57d26390c5..4afb762de6 100644
--- a/package/libshout/libshout.mk
+++ b/package/libshout/libshout.mk
@@ -33,9 +33,6 @@ endif
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBSHOUT_CONF_OPTS += --with-openssl
 LIBSHOUT_DEPENDENCIES += openssl
-else ifeq ($(BR2_PACKAGE_LIBRESSL),y)
-LIBSHOUT_CONF_OPTS += --with-openssl=$(STAGING_DIR)/lib
-LIBSHOUT_DEPENDENCIES += libressl
 else
 LIBSHOUT_CONF_OPTS += --without-openssl
 endif
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"

[Thomas Petazzoni]

On Wed, 18 Aug 2021 00:15:30 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
> libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
> conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
> will never be triggered. Moreover, libressl provides a pkg-config file.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libshout/libshout.mk | 3 ---
>  1 file changed, 3 deletions(-)

I've applied to master, because you're right, what
46b8fb7500ecca65a79507318fd3052208559c09 has added is a no-op, because
BR2_PACKAGE_LIBRESSL cannot be 'y' without BR2_PACKAGE_OPENSSL also
being 'y'.

However, could you look at the autobuilder issue that
46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
what is the proper fix for it ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"

[Fabrice Fontaine]

Le jeu. 19 août 2021 à 22:51, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Wed, 18 Aug 2021 00:15:30 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
> > libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
> > conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
> > will never be triggered. Moreover, libressl provides a pkg-config file.
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/libshout/libshout.mk | 3 ---
> >  1 file changed, 3 deletions(-)
>
> I've applied to master, because you're right, what
> 46b8fb7500ecca65a79507318fd3052208559c09 has added is a no-op, because
> BR2_PACKAGE_LIBRESSL cannot be 'y' without BR2_PACKAGE_OPENSSL also
> being 'y'.
>
> However, could you look at the autobuilder issue that
> 46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
> what is the proper fix for it ?
The autobuilder link given in the commit message returns 404.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"

[Yann E. MORIN]

Fabrice, All,

On 2021-08-19 22:57 +0200, Fabrice Fontaine spake thusly:
> Le jeu. 19 août 2021 à 22:51, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> a écrit :
> >
> > On Wed, 18 Aug 2021 00:15:30 +0200
> > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> >
> > > This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
> > > libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
> > > conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
> > > will never be triggered. Moreover, libressl provides a pkg-config file.
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > > ---
> > >  package/libshout/libshout.mk | 3 ---
> > >  1 file changed, 3 deletions(-)
> >
> > I've applied to master, because you're right, what
> > 46b8fb7500ecca65a79507318fd3052208559c09 has added is a no-op, because
> > BR2_PACKAGE_LIBRESSL cannot be 'y' without BR2_PACKAGE_OPENSSL also
> > being 'y'.
> >
> > However, could you look at the autobuilder issue that
> > 46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
> > what is the proper fix for it ?
> The autobuilder link given in the commit message returns 404.

Ah, that's from before we lost the DB in an HDD crash...

Regards,
Yann E. MORIN.

> > Best regards,
> >
> > Thomas
> > --
> > Thomas Petazzoni, CTO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> Best Regards,
> 
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"

[Thomas Petazzoni]

On Thu, 19 Aug 2021 22:57:08 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > However, could you look at the autobuilder issue that
> > 46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
> > what is the proper fix for it ?  
> The autobuilder link given in the commit message returns 404.

Aah, but it is a very old commit and build failure from 2017. Indeed,
we have lost such old build results. But back then, I believe openssl
and libressl were not "combined" as a virtual package, so the two
options were really mutually exclusive.

I assume you did a build of libshout with libressl, and noted that it
was now correct thanks to libressl providing .pc files. Correct?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"

[Fabrice Fontaine]

Le jeu. 19 août 2021 à 23:12, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Thu, 19 Aug 2021 22:57:08 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > > However, could you look at the autobuilder issue that
> > > 46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
> > > what is the proper fix for it ?
> > The autobuilder link given in the commit message returns 404.
>
> Aah, but it is a very old commit and build failure from 2017. Indeed,
> we have lost such old build results. But back then, I believe openssl
> and libressl were not "combined" as a virtual package, so the two
> options were really mutually exclusive.
>
> I assume you did a build of libshout with libressl, and noted that it
> was now correct thanks to libressl providing .pc files. Correct?
Yes, it builds fine because libressl provides openssl.pc but it wasn't
a surprise as I basically removed dead code.
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
 > libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
 > conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
 > will never be triggered. Moreover, libressl provides a pkg-config file.

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot