From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F283BC4338F for ; Tue, 24 Aug 2021 04:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDF8A611EF for ; Tue, 24 Aug 2021 04:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbhHXEoY (ORCPT ); Tue, 24 Aug 2021 00:44:24 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:1719 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229568AbhHXEoX (ORCPT ); Tue, 24 Aug 2021 00:44:23 -0400 Date: 24 Aug 2021 13:43:38 +0900 X-IronPort-AV: E=Sophos;i="5.84,346,1620658800"; d="scan'208";a="91544910" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 24 Aug 2021 13:43:38 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 3AEEE400C43B; Tue, 24 Aug 2021 13:43:38 +0900 (JST) Message-ID: <87eeajmozp.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: kernel test robot Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Re: sound/soc/generic/simple-card.c:259:17: warning: Value stored to 'dev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] In-Reply-To: <202108241108.EJSE2QL8-lkp@intel.com> References: <202108241108.EJSE2QL8-lkp@intel.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > >> sound/soc/generic/simple-card.c:259:17: warning: Value stored to 'dev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] > struct device *dev = simple_priv_to_dev(priv); > ^~~ > sound/soc/generic/simple-card.c:259:17: note: Value stored to 'dev' during its initialization is never read > struct device *dev = simple_priv_to_dev(priv); > ^~~ (snip) > e59289cda8dec0 Kuninori Morimoto 2019-03-20 253 static int simple_dai_link_of(struct asoc_simple_priv *priv, > d947cdfd4be29c Kuninori Morimoto 2018-12-20 254 struct device_node *np, > d947cdfd4be29c Kuninori Morimoto 2018-12-20 255 struct device_node *codec, > 17029e494edc68 Kuninori Morimoto 2018-12-20 256 struct link_info *li, > d947cdfd4be29c Kuninori Morimoto 2018-12-20 257 bool is_top) > 6a91a17bd7b92b Jean-Francois Moine 2014-03-20 258 { > f531913f01a072 Kuninori Morimoto 2014-09-09 @259 struct device *dev = simple_priv_to_dev(priv); > 17029e494edc68 Kuninori Morimoto 2018-12-20 260 struct snd_soc_dai_link *dai_link = simple_priv_to_link(priv, li->link); > 5bb5ac71e3f4f8 Kuninori Morimoto 2021-04-14 261 struct snd_soc_dai_link_component *cpus = asoc_link_to_cpu(dai_link, 0); > 5bb5ac71e3f4f8 Kuninori Morimoto 2021-04-14 262 struct snd_soc_dai_link_component *codecs = asoc_link_to_codec(dai_link, 0); > 5bb5ac71e3f4f8 Kuninori Morimoto 2021-04-14 263 struct snd_soc_dai_link_component *platforms = asoc_link_to_platform(dai_link, 0); > 1b5721b24306c2 Kuninori Morimoto 2014-10-27 264 struct device_node *cpu = NULL; > d947cdfd4be29c Kuninori Morimoto 2018-12-20 265 struct device_node *node = NULL; > e0ae225b7e96e5 Jun Nie 2015-04-29 266 struct device_node *plat = NULL; > 6ad76b573bb63e Kuninori Morimoto 2021-05-11 267 char dai_name[64]; > b3ca11ff59bc58 Jyri Sarha 2014-03-24 268 char prop[128]; > b3ca11ff59bc58 Jyri Sarha 2014-03-24 269 char *prefix = ""; > 25c4a9b614f101 Mark Brown 2021-04-23 270 int ret, single_cpu = 0; > 6a91a17bd7b92b Jean-Francois Moine 2014-03-20 271 > d947cdfd4be29c Kuninori Morimoto 2018-12-20 272 cpu = np; > d947cdfd4be29c Kuninori Morimoto 2018-12-20 273 node = of_get_parent(np); > 17029e494edc68 Kuninori Morimoto 2018-12-20 274 > 17029e494edc68 Kuninori Morimoto 2018-12-20 275 dev_dbg(dev, "link_of (%pOF)\n", node); Ahh..., "dev" at 259 is used only at 275 dev_dbg(dev, ...), and this warning is for non DEBUG case. I don't like below, but is this the only solution ? +#ifdef DEBUG struct device *dev = simple_priv_to_dev(priv); +#endif Maybe samething happen at audio-graph-card.c :: graph_dai_link_of(), too. Thank you for your help !! Best regards --- Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7861148620325294232==" MIME-Version: 1.0 From: Kuninori Morimoto To: kbuild-all@lists.01.org Subject: Re: sound/soc/generic/simple-card.c:259:17: warning: Value stored to 'dev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] Date: Tue, 24 Aug 2021 13:43:38 +0900 Message-ID: <87eeajmozp.wl-kuninori.morimoto.gx@renesas.com> In-Reply-To: <202108241108.EJSE2QL8-lkp@intel.com> List-Id: --===============7861148620325294232== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi > >> sound/soc/generic/simple-card.c:259:17: warning: Value stored to 'dev'= during its initialization is never read [clang-analyzer-deadcode.DeadStore= s] > struct device *dev =3D simple_priv_to_dev(priv); > ^~~ > sound/soc/generic/simple-card.c:259:17: note: Value stored to 'dev' du= ring its initialization is never read > struct device *dev =3D simple_priv_to_dev(priv); > ^~~ (snip) > e59289cda8dec0 Kuninori Morimoto 2019-03-20 253 static int simple_dai= _link_of(struct asoc_simple_priv *priv, > d947cdfd4be29c Kuninori Morimoto 2018-12-20 254 struct devic= e_node *np, > d947cdfd4be29c Kuninori Morimoto 2018-12-20 255 struct devic= e_node *codec, > 17029e494edc68 Kuninori Morimoto 2018-12-20 256 struct link_= info *li, > d947cdfd4be29c Kuninori Morimoto 2018-12-20 257 bool is_top) > 6a91a17bd7b92b Jean-Francois Moine 2014-03-20 258 { > f531913f01a072 Kuninori Morimoto 2014-09-09 @259 struct device *dev = =3D simple_priv_to_dev(priv); > 17029e494edc68 Kuninori Morimoto 2018-12-20 260 struct snd_soc_dai_l= ink *dai_link =3D simple_priv_to_link(priv, li->link); > 5bb5ac71e3f4f8 Kuninori Morimoto 2021-04-14 261 struct snd_soc_dai_l= ink_component *cpus =3D asoc_link_to_cpu(dai_link, 0); > 5bb5ac71e3f4f8 Kuninori Morimoto 2021-04-14 262 struct snd_soc_dai_l= ink_component *codecs =3D asoc_link_to_codec(dai_link, 0); > 5bb5ac71e3f4f8 Kuninori Morimoto 2021-04-14 263 struct snd_soc_dai_l= ink_component *platforms =3D asoc_link_to_platform(dai_link, 0); > 1b5721b24306c2 Kuninori Morimoto 2014-10-27 264 struct device_node *= cpu =3D NULL; > d947cdfd4be29c Kuninori Morimoto 2018-12-20 265 struct device_node *= node =3D NULL; > e0ae225b7e96e5 Jun Nie 2015-04-29 266 struct device_node *= plat =3D NULL; > 6ad76b573bb63e Kuninori Morimoto 2021-05-11 267 char dai_name[64]; > b3ca11ff59bc58 Jyri Sarha 2014-03-24 268 char prop[128]; > b3ca11ff59bc58 Jyri Sarha 2014-03-24 269 char *prefix =3D ""; > 25c4a9b614f101 Mark Brown 2021-04-23 270 int ret, single_cpu = =3D 0; > 6a91a17bd7b92b Jean-Francois Moine 2014-03-20 271 = > d947cdfd4be29c Kuninori Morimoto 2018-12-20 272 cpu =3D np; > d947cdfd4be29c Kuninori Morimoto 2018-12-20 273 node =3D of_get_pare= nt(np); > 17029e494edc68 Kuninori Morimoto 2018-12-20 274 = > 17029e494edc68 Kuninori Morimoto 2018-12-20 275 dev_dbg(dev, "link_o= f (%pOF)\n", node); Ahh..., "dev" at 259 is used only at 275 dev_dbg(dev, ...), and this warning is for non DEBUG case. I don't like below, but is this the only solution ? +#ifdef DEBUG struct device *dev =3D simple_priv_to_dev(priv); +#endif Maybe samething happen at audio-graph-card.c :: graph_dai_link_of(), too. Thank you for your help !! Best regards --- Kuninori Morimoto --===============7861148620325294232==--