From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2EFC49361 for ; Thu, 17 Jun 2021 14:20:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 015CC613A9 for ; Thu, 17 Jun 2021 14:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232021AbhFQOWh (ORCPT ); Thu, 17 Jun 2021 10:22:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:44958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231666AbhFQOWg (ORCPT ); Thu, 17 Jun 2021 10:22:36 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8279C6135C; Thu, 17 Jun 2021 14:20:28 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ltssc-008C7g-Jn; Thu, 17 Jun 2021 15:20:26 +0100 Date: Thu, 17 Jun 2021 15:20:26 +0100 Message-ID: <87eed0d13p.wl-maz@kernel.org> From: Marc Zyngier To: Will Deacon Cc: Yanan Wang , Quentin Perret , Alexandru Elisei , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , wanghaibin.wang@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v7 1/4] KVM: arm64: Introduce two cache maintenance callbacks In-Reply-To: <20210617123837.GA24457@willie-the-truck> References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-2-wangyanan55@huawei.com> <20210617123837.GA24457@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: will@kernel.org, wangyanan55@huawei.com, qperret@google.com, alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, gshan@redhat.com, wanghaibin.wang@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Jun 2021 13:38:37 +0100, Will Deacon wrote: > > On Thu, Jun 17, 2021 at 06:58:21PM +0800, Yanan Wang wrote: > > To prepare for performing CMOs for guest stage-2 in the fault handlers > > in pgtable.c, here introduce two cache maintenance callbacks in struct > > kvm_pgtable_mm_ops. We also adjust the comment alignment for the > > existing part but make no real content change at all. > > > > Signed-off-by: Yanan Wang > > --- > > arch/arm64/include/asm/kvm_pgtable.h | 42 +++++++++++++++++----------- > > 1 file changed, 25 insertions(+), 17 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > > index c3674c47d48c..b6ce34aa44bb 100644 > > --- a/arch/arm64/include/asm/kvm_pgtable.h > > +++ b/arch/arm64/include/asm/kvm_pgtable.h > > @@ -27,23 +27,29 @@ typedef u64 kvm_pte_t; > > > > /** > > * struct kvm_pgtable_mm_ops - Memory management callbacks. > > - * @zalloc_page: Allocate a single zeroed memory page. The @arg parameter > > - * can be used by the walker to pass a memcache. The > > - * initial refcount of the page is 1. > > - * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. The > > - * @size parameter is in bytes, and is rounded-up to the > > - * next page boundary. The resulting allocation is > > - * physically contiguous. > > - * @free_pages_exact: Free an exact number of memory pages previously > > - * allocated by zalloc_pages_exact. > > - * @get_page: Increment the refcount on a page. > > - * @put_page: Decrement the refcount on a page. When the refcount > > - * reaches 0 the page is automatically freed. > > - * @page_count: Return the refcount of a page. > > - * @phys_to_virt: Convert a physical address into a virtual address mapped > > - * in the current context. > > - * @virt_to_phys: Convert a virtual address mapped in the current context > > - * into a physical address. > > + * @zalloc_page: Allocate a single zeroed memory page. > > + * The @arg parameter can be used by the walker > > + * to pass a memcache. The initial refcount of > > + * the page is 1. > > + * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. > > + * The @size parameter is in bytes, and is rounded > > + * up to the next page boundary. The resulting > > + * allocation is physically contiguous. > > + * @free_pages_exact: Free an exact number of memory pages previously > > + * allocated by zalloc_pages_exact. > > + * @get_page: Increment the refcount on a page. > > + * @put_page: Decrement the refcount on a page. When the > > + * refcount reaches 0 the page is automatically > > + * freed. > > + * @page_count: Return the refcount of a page. > > + * @phys_to_virt: Convert a physical address into a virtual address > > + * mapped in the current context. > > + * @virt_to_phys: Convert a virtual address mapped in the current > > + * context into a physical address. > > + * @clean_invalidate_dcache: Clean and invalidate the data cache for the > > + * specified memory address range. > > This should probably be explicit about whether this to the PoU/PoC/PoP. Indeed. I can fix that locally if there is nothing else that requires adjusting. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254F3C2B9F4 for ; Thu, 17 Jun 2021 14:20:34 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 8F4E8613CE for ; Thu, 17 Jun 2021 14:20:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F4E8613CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 196B14B08F; Thu, 17 Jun 2021 10:20:33 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3XUjjUprzG7g; Thu, 17 Jun 2021 10:20:31 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E0BC44B097; Thu, 17 Jun 2021 10:20:31 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C7D804B08E for ; Thu, 17 Jun 2021 10:20:30 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Llr+z41cgtJf for ; Thu, 17 Jun 2021 10:20:29 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 8C0154AEF8 for ; Thu, 17 Jun 2021 10:20:29 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8279C6135C; Thu, 17 Jun 2021 14:20:28 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ltssc-008C7g-Jn; Thu, 17 Jun 2021 15:20:26 +0100 Date: Thu, 17 Jun 2021 15:20:26 +0100 Message-ID: <87eed0d13p.wl-maz@kernel.org> From: Marc Zyngier To: Will Deacon Subject: Re: [PATCH v7 1/4] KVM: arm64: Introduce two cache maintenance callbacks In-Reply-To: <20210617123837.GA24457@willie-the-truck> References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-2-wangyanan55@huawei.com> <20210617123837.GA24457@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: will@kernel.org, wangyanan55@huawei.com, qperret@google.com, alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, gshan@redhat.com, wanghaibin.wang@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, 17 Jun 2021 13:38:37 +0100, Will Deacon wrote: > > On Thu, Jun 17, 2021 at 06:58:21PM +0800, Yanan Wang wrote: > > To prepare for performing CMOs for guest stage-2 in the fault handlers > > in pgtable.c, here introduce two cache maintenance callbacks in struct > > kvm_pgtable_mm_ops. We also adjust the comment alignment for the > > existing part but make no real content change at all. > > > > Signed-off-by: Yanan Wang > > --- > > arch/arm64/include/asm/kvm_pgtable.h | 42 +++++++++++++++++----------- > > 1 file changed, 25 insertions(+), 17 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > > index c3674c47d48c..b6ce34aa44bb 100644 > > --- a/arch/arm64/include/asm/kvm_pgtable.h > > +++ b/arch/arm64/include/asm/kvm_pgtable.h > > @@ -27,23 +27,29 @@ typedef u64 kvm_pte_t; > > > > /** > > * struct kvm_pgtable_mm_ops - Memory management callbacks. > > - * @zalloc_page: Allocate a single zeroed memory page. The @arg parameter > > - * can be used by the walker to pass a memcache. The > > - * initial refcount of the page is 1. > > - * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. The > > - * @size parameter is in bytes, and is rounded-up to the > > - * next page boundary. The resulting allocation is > > - * physically contiguous. > > - * @free_pages_exact: Free an exact number of memory pages previously > > - * allocated by zalloc_pages_exact. > > - * @get_page: Increment the refcount on a page. > > - * @put_page: Decrement the refcount on a page. When the refcount > > - * reaches 0 the page is automatically freed. > > - * @page_count: Return the refcount of a page. > > - * @phys_to_virt: Convert a physical address into a virtual address mapped > > - * in the current context. > > - * @virt_to_phys: Convert a virtual address mapped in the current context > > - * into a physical address. > > + * @zalloc_page: Allocate a single zeroed memory page. > > + * The @arg parameter can be used by the walker > > + * to pass a memcache. The initial refcount of > > + * the page is 1. > > + * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. > > + * The @size parameter is in bytes, and is rounded > > + * up to the next page boundary. The resulting > > + * allocation is physically contiguous. > > + * @free_pages_exact: Free an exact number of memory pages previously > > + * allocated by zalloc_pages_exact. > > + * @get_page: Increment the refcount on a page. > > + * @put_page: Decrement the refcount on a page. When the > > + * refcount reaches 0 the page is automatically > > + * freed. > > + * @page_count: Return the refcount of a page. > > + * @phys_to_virt: Convert a physical address into a virtual address > > + * mapped in the current context. > > + * @virt_to_phys: Convert a virtual address mapped in the current > > + * context into a physical address. > > + * @clean_invalidate_dcache: Clean and invalidate the data cache for the > > + * specified memory address range. > > This should probably be explicit about whether this to the PoU/PoC/PoP. Indeed. I can fix that locally if there is nothing else that requires adjusting. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C511C49EA2 for ; Thu, 17 Jun 2021 14:22:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07D47613B9 for ; Thu, 17 Jun 2021 14:22:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07D47613B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9cMErrQNXUEIclY21KG03X/rEc/Vq98syMaCZnW/bG0=; b=QY+O7DKuyBm2rC M85gMW4YDDtqLBvHdsEFNoSsG9Jteggd6qrSR6SA7EFiIl1MfnorFkmnemBftShJNiUwAJg2RmAEN KWOGG0kp4/611HzzpIo7UdjA4mQgdwgkbClZM0935u8VMXzfHhoflex+wF38ArgAcTBulbp2FsQBw 5mbsgmhoj7ylAanak+jgyZoceYohJ3hwfkIp4rSdAUTsxKLrQ7xLB+o3euyg86QSK0XEeHZS8aWSY NKSmX85JNVc1S6SB833knEHvS8SzVWbKxEUfaKHuN1GXP4IAnFudgp9uNzs3h4dGfKra1B0hE8fmG aHpdL7TMDt29C5p9uUeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltssi-00AfSw-QM; Thu, 17 Jun 2021 14:20:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltsse-00AfRl-RZ for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 14:20:30 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8279C6135C; Thu, 17 Jun 2021 14:20:28 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ltssc-008C7g-Jn; Thu, 17 Jun 2021 15:20:26 +0100 Date: Thu, 17 Jun 2021 15:20:26 +0100 Message-ID: <87eed0d13p.wl-maz@kernel.org> From: Marc Zyngier To: Will Deacon Cc: Yanan Wang , Quentin Perret , Alexandru Elisei , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , wanghaibin.wang@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v7 1/4] KVM: arm64: Introduce two cache maintenance callbacks In-Reply-To: <20210617123837.GA24457@willie-the-truck> References: <20210617105824.31752-1-wangyanan55@huawei.com> <20210617105824.31752-2-wangyanan55@huawei.com> <20210617123837.GA24457@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: will@kernel.org, wangyanan55@huawei.com, qperret@google.com, alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, gshan@redhat.com, wanghaibin.wang@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_072028_965619_9EA7220D X-CRM114-Status: GOOD ( 30.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Jun 2021 13:38:37 +0100, Will Deacon wrote: > > On Thu, Jun 17, 2021 at 06:58:21PM +0800, Yanan Wang wrote: > > To prepare for performing CMOs for guest stage-2 in the fault handlers > > in pgtable.c, here introduce two cache maintenance callbacks in struct > > kvm_pgtable_mm_ops. We also adjust the comment alignment for the > > existing part but make no real content change at all. > > > > Signed-off-by: Yanan Wang > > --- > > arch/arm64/include/asm/kvm_pgtable.h | 42 +++++++++++++++++----------- > > 1 file changed, 25 insertions(+), 17 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > > index c3674c47d48c..b6ce34aa44bb 100644 > > --- a/arch/arm64/include/asm/kvm_pgtable.h > > +++ b/arch/arm64/include/asm/kvm_pgtable.h > > @@ -27,23 +27,29 @@ typedef u64 kvm_pte_t; > > > > /** > > * struct kvm_pgtable_mm_ops - Memory management callbacks. > > - * @zalloc_page: Allocate a single zeroed memory page. The @arg parameter > > - * can be used by the walker to pass a memcache. The > > - * initial refcount of the page is 1. > > - * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. The > > - * @size parameter is in bytes, and is rounded-up to the > > - * next page boundary. The resulting allocation is > > - * physically contiguous. > > - * @free_pages_exact: Free an exact number of memory pages previously > > - * allocated by zalloc_pages_exact. > > - * @get_page: Increment the refcount on a page. > > - * @put_page: Decrement the refcount on a page. When the refcount > > - * reaches 0 the page is automatically freed. > > - * @page_count: Return the refcount of a page. > > - * @phys_to_virt: Convert a physical address into a virtual address mapped > > - * in the current context. > > - * @virt_to_phys: Convert a virtual address mapped in the current context > > - * into a physical address. > > + * @zalloc_page: Allocate a single zeroed memory page. > > + * The @arg parameter can be used by the walker > > + * to pass a memcache. The initial refcount of > > + * the page is 1. > > + * @zalloc_pages_exact: Allocate an exact number of zeroed memory pages. > > + * The @size parameter is in bytes, and is rounded > > + * up to the next page boundary. The resulting > > + * allocation is physically contiguous. > > + * @free_pages_exact: Free an exact number of memory pages previously > > + * allocated by zalloc_pages_exact. > > + * @get_page: Increment the refcount on a page. > > + * @put_page: Decrement the refcount on a page. When the > > + * refcount reaches 0 the page is automatically > > + * freed. > > + * @page_count: Return the refcount of a page. > > + * @phys_to_virt: Convert a physical address into a virtual address > > + * mapped in the current context. > > + * @virt_to_phys: Convert a virtual address mapped in the current > > + * context into a physical address. > > + * @clean_invalidate_dcache: Clean and invalidate the data cache for the > > + * specified memory address range. > > This should probably be explicit about whether this to the PoU/PoC/PoP. Indeed. I can fix that locally if there is nothing else that requires adjusting. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel