From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CDDC433ED for ; Sun, 25 Apr 2021 07:29:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7720613CB for ; Sun, 25 Apr 2021 07:29:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7720613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laZCT-0005j2-RH for qemu-devel@archiver.kernel.org; Sun, 25 Apr 2021 03:29:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laZBN-0005GK-Tw for qemu-devel@nongnu.org; Sun, 25 Apr 2021 03:27:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laZBM-0005ed-CC for qemu-devel@nongnu.org; Sun, 25 Apr 2021 03:27:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619335675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=esoJoFnSnOXlSS8ueJ9VCplvC3fIpS3fZGMzu8WF9dU=; b=MOyVccw6d5xqS4wxie+dTPKwA1nJxzj+K59j4CDdLwDEaNzfAxk8kFRFVe8BIgBxV76KCv DNs3ccBXWIruBA5SnyH58nj45atObQ0TlH1iuXNm27O+0IY4fyrrYk4sPzKCfIh3SQ252y /OJ7sfvq3q1v0bh5dbNUwOyFTYzNVec= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27-PJPtDxGHPOSOpPNdD1At1Q-1; Sun, 25 Apr 2021 03:27:53 -0400 X-MC-Unique: PJPtDxGHPOSOpPNdD1At1Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F72B100670B; Sun, 25 Apr 2021 07:27:52 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FA57687DA; Sun, 25 Apr 2021 07:27:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B80F1113525D; Sun, 25 Apr 2021 09:27:50 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH 07/22] qapi/parser: assert object keys are strings References: <20210422030720.3685766-1-jsnow@redhat.com> <20210422030720.3685766-8-jsnow@redhat.com> Date: Sun, 25 Apr 2021 09:27:50 +0200 In-Reply-To: <20210422030720.3685766-8-jsnow@redhat.com> (John Snow's message of "Wed, 21 Apr 2021 23:07:05 -0400") Message-ID: <87eeey962x.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , qemu-devel@nongnu.org, Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > The single quote token implies the value is a string. Assert this to be > the case. > > Signed-off-by: John Snow > --- > scripts/qapi/parser.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py > index 6b443b1247e..8d1fe0ddda5 100644 > --- a/scripts/qapi/parser.py > +++ b/scripts/qapi/parser.py > @@ -246,6 +246,8 @@ def get_members(self): > raise QAPIParseError(self, "expected string or '}'") > while True: > key = self.val > + assert isinstance(key, str) # Guaranteed by tok == "'" > + > self.accept() > if self.tok != ':': > raise QAPIParseError(self, "expected ':'") The assertion is correct, but I wonder why mypy needs it. Can you help?