All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH] genirq/irqaction: Move dev_id and percpu_dev_id in a union
Date: Tue, 20 Apr 2021 10:08:38 +0100	[thread overview]
Message-ID: <87eef5qq5l.wl-maz@kernel.org> (raw)
In-Reply-To: <87y2dfqhtd.ffs@nanos.tec.linutronix.de>

On Mon, 19 Apr 2021 00:44:14 +0100,
Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> On Sat, Apr 10 2021 at 13:00, Marc Zyngier wrote:
> > dev_id and percpu_dev_id are mutually exclusive in struct irqaction,
> > as they conceptually represent the same thing, only in a per-cpu
> > fashion.
> >
> > Move them into an anonymous union, saving a few bytes on the way.
> 
> The reason why they are not in an anomymous union is that any misuse of
> interfaces will result in an instantaneous explosion while with your
> variant it will cause hard to diagnose side effects.
> 
> I rather waste the extra 4/8 bytes unless there is a compelling reason
> not to do so.

Fair enough. I just happened to spot it while doing some vaguely
related rework (turning the irqaction.irq field into an irqdesc).

Happy to leave it as is.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

      reply	other threads:[~2021-04-20  9:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 12:00 [PATCH] genirq/irqaction: Move dev_id and percpu_dev_id in a union Marc Zyngier
2021-04-18 23:44 ` Thomas Gleixner
2021-04-20  9:08   ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eef5qq5l.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.