From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 356D0C433B4 for ; Fri, 2 Apr 2021 20:41:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 061286117A for ; Fri, 2 Apr 2021 20:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbhDBUlu convert rfc822-to-8bit (ORCPT ); Fri, 2 Apr 2021 16:41:50 -0400 Received: from mslow1.mail.gandi.net ([217.70.178.240]:37289 "EHLO mslow1.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234856AbhDBUls (ORCPT ); Fri, 2 Apr 2021 16:41:48 -0400 X-Greylist: delayed 1454 seconds by postgrey-1.27 at vger.kernel.org; Fri, 02 Apr 2021 16:41:48 EDT Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 28287C067E for ; Fri, 2 Apr 2021 20:16:23 +0000 (UTC) X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 23715C0002; Fri, 2 Apr 2021 20:15:57 +0000 (UTC) From: Gregory CLEMENT To: Marek =?utf-8?Q?Beh=C3=BAn?= Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , Rui Salvaterra , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, Andrew Lunn , stable@vger.kernel.org Subject: Re: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin In-Reply-To: <20210220231144.32325-1-kabel@kernel.org> References: <20210220231144.32325-1-kabel@kernel.org> Date: Fri, 02 Apr 2021 22:15:57 +0200 Message-ID: <87eefscuiq.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Marek, > Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin > of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. > > Without this the pin is by default in LED[2] mode, and the Marvell PHY > driver configures LED[2] into "On - Link, Blink - Activity" mode. > > This fixes the issue where the pca9538 GPIO/interrupt controller (which > can't mask interrupts in HW) received too many interrupts and after a > time started ignoring the interrupt with error message: > IRQ 71: nobody cared > > There is a work in progress to have the Marvell PHY driver support > parsing PHY LED nodes from OF and registering the LEDs as Linux LED > class devices. Once this is done the PHY driver can also automatically > set the pin into INTn mode if it does not find LED[2] in OF. > > Until then, though, we fix this via `marvell,reg-init` DT property. > > Signed-off-by: Marek Behún > Reported-by: Rui Salvaterra > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") > Cc: Uwe Kleine-König > Cc: linux-arm-kernel@lists.infradead.org > Cc: Andrew Lunn > Cc: Gregory CLEMENT > Cc: Applied on mvebu/fixes Thanks, Gregory > > --- > > This patch fixes bug introduced with the commit that added Turris > Omnia's DTS (26ca8b52d6e1), but will not apply cleanly because there is > commit 8ee4a5f4f40d which changed node name and node compatible > property and this commit did not go into stable. > > So either commit 8ee4a5f4f40d has also to go into stable before this, or > this patch has to be fixed a little in order to apply to 4.14+. > > Please let me know how should I handle this. > > --- > arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts > index 646a06420c77..b0f3fd8e1429 100644 > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts > @@ -389,6 +389,7 @@ &mdio { > phy1: ethernet-phy@1 { > compatible = "ethernet-phy-ieee802.3-c22"; > reg = <1>; > + marvell,reg-init = <3 18 0 0x4985>; > > /* irq is connected to &pcawan pin 7 */ > }; > -- > 2.26.2 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6AE1C433B4 for ; Fri, 2 Apr 2021 20:17:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 664526112E for ; Fri, 2 Apr 2021 20:17:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 664526112E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MLf9t5GjlauvP98ecQJPpqeRvGd5AKLNO5d5rlgLwP4=; b=W9wEn1foo1c4BTndTenXKrqGB oKf/NgHdJ4CXSw8PSWk7SILHGP/XE8JyqtVLxF1KCcvPTJevTJYRY6Qt69FlyNFbmLORbb50ZlOZP S3yy+5yYnYiS3v0smJSnjTh6r3bW53uk9t7cW7rrWvaeqmYYJuXkDkvu8odrXFwbDkDNcgBKV/v32 2FLgtJBDedqp2ps1OdfdIsmfjYxTQuWO9a9c+emut2uEi02g843oPrEGud8hrphwC3RIea43+3ZAK /4+/GCHwrMeERfyUVsap76l1sUuvyOtacrlU4po3h/lR0sC0jtQLj+9d90kP3thsSUSDmJae1vd9e NEoEqLqVw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSQDA-00Dmn0-P4; Fri, 02 Apr 2021 20:16:08 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSQD4-00Dmm8-AV for linux-arm-kernel@lists.infradead.org; Fri, 02 Apr 2021 20:16:04 +0000 X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 23715C0002; Fri, 2 Apr 2021 20:15:57 +0000 (UTC) From: Gregory CLEMENT To: Marek =?utf-8?Q?Beh=C3=BAn?= Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , Rui Salvaterra , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, Andrew Lunn , stable@vger.kernel.org Subject: Re: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin In-Reply-To: <20210220231144.32325-1-kabel@kernel.org> References: <20210220231144.32325-1-kabel@kernel.org> Date: Fri, 02 Apr 2021 22:15:57 +0200 Message-ID: <87eefscuiq.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_211602_563786_1D7376AB X-CRM114-Status: GOOD ( 23.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyZWssCgo+IFVzZSB0aGUgYG1hcnZlbGwscmVnLWluaXRgIERUIHByb3BlcnR5IHRvIGNv bmZpZ3VyZSB0aGUgTEVEWzJdL0lOVG4gcGluCj4gb2YgdGhlIE1hcnZlbGwgODhFMTUxNCBldGhl cm5ldCBQSFkgb24gVHVycmlzIE9tbmlhIGludG8gaW50ZXJydXB0IG1vZGUuCj4KPiBXaXRob3V0 IHRoaXMgdGhlIHBpbiBpcyBieSBkZWZhdWx0IGluIExFRFsyXSBtb2RlLCBhbmQgdGhlIE1hcnZl bGwgUEhZCj4gZHJpdmVyIGNvbmZpZ3VyZXMgTEVEWzJdIGludG8gIk9uIC0gTGluaywgQmxpbmsg LSBBY3Rpdml0eSIgbW9kZS4KPgo+IFRoaXMgZml4ZXMgdGhlIGlzc3VlIHdoZXJlIHRoZSBwY2E5 NTM4IEdQSU8vaW50ZXJydXB0IGNvbnRyb2xsZXIgKHdoaWNoCj4gY2FuJ3QgbWFzayBpbnRlcnJ1 cHRzIGluIEhXKSByZWNlaXZlZCB0b28gbWFueSBpbnRlcnJ1cHRzIGFuZCBhZnRlciBhCj4gdGlt ZSBzdGFydGVkIGlnbm9yaW5nIHRoZSBpbnRlcnJ1cHQgd2l0aCBlcnJvciBtZXNzYWdlOgo+ICAg SVJRIDcxOiBub2JvZHkgY2FyZWQKPgo+IFRoZXJlIGlzIGEgd29yayBpbiBwcm9ncmVzcyB0byBo YXZlIHRoZSBNYXJ2ZWxsIFBIWSBkcml2ZXIgc3VwcG9ydAo+IHBhcnNpbmcgUEhZIExFRCBub2Rl cyBmcm9tIE9GIGFuZCByZWdpc3RlcmluZyB0aGUgTEVEcyBhcyBMaW51eCBMRUQKPiBjbGFzcyBk ZXZpY2VzLiBPbmNlIHRoaXMgaXMgZG9uZSB0aGUgUEhZIGRyaXZlciBjYW4gYWxzbyBhdXRvbWF0 aWNhbGx5Cj4gc2V0IHRoZSBwaW4gaW50byBJTlRuIG1vZGUgaWYgaXQgZG9lcyBub3QgZmluZCBM RURbMl0gaW4gT0YuCj4KPiBVbnRpbCB0aGVuLCB0aG91Z2gsIHdlIGZpeCB0aGlzIHZpYSBgbWFy dmVsbCxyZWctaW5pdGAgRFQgcHJvcGVydHkuCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYXJlayBCZWjD um4gPGthYmVsQGtlcm5lbC5vcmc+Cj4gUmVwb3J0ZWQtYnk6IFJ1aSBTYWx2YXRlcnJhIDxyc2Fs dmF0ZXJyYUBnbWFpbC5jb20+Cj4gRml4ZXM6IDI2Y2E4YjUyZDZlMSAoIkFSTTogZHRzOiBhZGQg c3VwcG9ydCBmb3IgVHVycmlzIE9tbmlhIikKPiBDYzogVXdlIEtsZWluZS1Lw7ZuaWcgPHV3ZUBr bGVpbmUta29lbmlnLm9yZz4KPiBDYzogbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCj4gQ2M6IEFuZHJldyBMdW5uIDxhbmRyZXdAbHVubi5jaD4KPiBDYzogR3JlZ29yeSBDTEVN RU5UIDxncmVnb3J5LmNsZW1lbnRAYm9vdGxpbi5jb20+Cj4gQ2M6IDxzdGFibGVAdmdlci5rZXJu ZWwub3JnPgoKCkFwcGxpZWQgb24gbXZlYnUvZml4ZXMKClRoYW5rcywKCkdyZWdvcnkKCj4KPiAt LS0KPgo+IFRoaXMgcGF0Y2ggZml4ZXMgYnVnIGludHJvZHVjZWQgd2l0aCB0aGUgY29tbWl0IHRo YXQgYWRkZWQgVHVycmlzCj4gT21uaWEncyBEVFMgKDI2Y2E4YjUyZDZlMSksIGJ1dCB3aWxsIG5v dCBhcHBseSBjbGVhbmx5IGJlY2F1c2UgdGhlcmUgaXMKPiBjb21taXQgOGVlNGE1ZjRmNDBkIHdo aWNoIGNoYW5nZWQgbm9kZSBuYW1lIGFuZCBub2RlIGNvbXBhdGlibGUKPiBwcm9wZXJ0eSBhbmQg dGhpcyBjb21taXQgZGlkIG5vdCBnbyBpbnRvIHN0YWJsZS4KPgo+IFNvIGVpdGhlciBjb21taXQg OGVlNGE1ZjRmNDBkIGhhcyBhbHNvIHRvIGdvIGludG8gc3RhYmxlIGJlZm9yZSB0aGlzLCBvcgo+ IHRoaXMgcGF0Y2ggaGFzIHRvIGJlIGZpeGVkIGEgbGl0dGxlIGluIG9yZGVyIHRvIGFwcGx5IHRv IDQuMTQrLgo+Cj4gUGxlYXNlIGxldCBtZSBrbm93IGhvdyBzaG91bGQgSSBoYW5kbGUgdGhpcy4K Pgo+IC0tLQo+ICBhcmNoL2FybS9ib290L2R0cy9hcm1hZGEtMzg1LXR1cnJpcy1vbW5pYS5kdHMg fCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4KPiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm0vYm9vdC9kdHMvYXJtYWRhLTM4NS10dXJyaXMtb21uaWEuZHRzIGIvYXJjaC9hcm0v Ym9vdC9kdHMvYXJtYWRhLTM4NS10dXJyaXMtb21uaWEuZHRzCj4gaW5kZXggNjQ2YTA2NDIwYzc3 Li5iMGYzZmQ4ZTE0MjkgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvYXJtYWRhLTM4 NS10dXJyaXMtb21uaWEuZHRzCj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvYXJtYWRhLTM4NS10 dXJyaXMtb21uaWEuZHRzCj4gQEAgLTM4OSw2ICszODksNyBAQCAmbWRpbyB7Cj4gIAlwaHkxOiBl dGhlcm5ldC1waHlAMSB7Cj4gIAkJY29tcGF0aWJsZSA9ICJldGhlcm5ldC1waHktaWVlZTgwMi4z LWMyMiI7Cj4gIAkJcmVnID0gPDE+Owo+ICsJCW1hcnZlbGwscmVnLWluaXQgPSA8MyAxOCAwIDB4 NDk4NT47Cj4gIAo+ICAJCS8qIGlycSBpcyBjb25uZWN0ZWQgdG8gJnBjYXdhbiBwaW4gNyAqLwo+ ICAJfTsKPiAtLSAKPiAyLjI2LjIKPgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbgpFbWJl ZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGluLmNvbQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=