From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D32DC433E0 for ; Mon, 11 Jan 2021 19:09:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C254E22AED for ; Mon, 11 Jan 2021 19:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390847AbhAKTJm (ORCPT ); Mon, 11 Jan 2021 14:09:42 -0500 Received: from mga03.intel.com ([134.134.136.65]:32692 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387783AbhAKTJl (ORCPT ); Mon, 11 Jan 2021 14:09:41 -0500 IronPort-SDR: YaTAsiO8gtI0hx4whvW/7A8ujJhGTBN/4ccsulz9+ngJUTXFh55zZLJ5ueLMYQTca3jW0njgVp QgLO3zhP40Kw== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="178014374" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="178014374" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 11:09:00 -0800 IronPort-SDR: x8OKXI5OZ6oXbRp5kghbmzTVfHgMf41WuozxTfXnORmeWBmzptdRz7p3ipEc1UQR4ZnnrT2eiR Ec/TvW8G+ZWw== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="352713907" Received: from libresli-mobl1.ger.corp.intel.com (HELO localhost) ([10.213.207.39]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 11:08:51 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org Cc: thaytan@noraisin.net, Vasily Khoruzhick , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , Imre Deak , Chris Wilson , Dave Airlie , Sean Paul , Lucas De Marchi , Uma Shankar , Manasi Navare , Gwan-gyeong Mun , Ankit Nautiyal , Wambui Karuga , =?utf-8?Q?Jos=C3=A9?= Roberto de Souza , Pankaj Bharadiya , Lee Shawn C , Anshuman Gupta , "open list\:DRM DRIVERS" , open list Subject: Re: [PATCH v5 4/4] drm/dp: Revert "drm/dp: Introduce EDID-based quirks" In-Reply-To: <87h7nnwauw.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210107225207.28091-1-lyude@redhat.com> <20210107225207.28091-5-lyude@redhat.com> <87h7nnwauw.fsf@intel.com> Date: Mon, 11 Jan 2021 21:08:48 +0200 Message-ID: <87eeirwatb.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jan 2021, Jani Nikula wrote: > On Thu, 07 Jan 2021, Lyude Paul wrote: >> This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally >> these quirks were added because of the issues with using the eDP >> backlight interfaces on certain laptop panels, which made it impossible >> to properly probe for DPCD backlight support without having a whitelist >> for panels that we know have working VESA backlight control interfaces >> over DPCD. As well, it should be noted it was impossible to use the >> normal sink OUI for recognizing these panels as none of them actually >> filled out their OUIs, hence needing to resort to checking EDIDs. >> >> At the time we weren't really sure why certain panels had issues with >> DPCD backlight controls, but we eventually figured out that there was a >> second interface that these problematic laptop panels actually did work >> with and advertise properly: Intel's proprietary backlight interface for >> HDR panels. So far the testing we've done hasn't brought any panels to >> light that advertise this interface and don't support it properly, which >> means we finally have a real solution to this problem. >> >> As a result, we now have no need for the force DPCD backlight quirk, and >> furthermore this also removes the need for any kind of EDID quirk >> checking in DRM. So, let's just revert it for now since we were the only >> driver using this. >> >> v3: >> * Rebase >> v2: >> * Fix indenting error picked up by checkpatch in >> intel_edp_init_connector() >> >> Signed-off-by: Lyude Paul >> Acked-by: Jani Nikula > > Still stands. PS. You'll still need drm or drm-misc maintainer ack if you want to merge this through drm-intel-next. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8194DC433E0 for ; Mon, 11 Jan 2021 19:09:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3443422A84 for ; Mon, 11 Jan 2021 19:09:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3443422A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BCEC89DD3; Mon, 11 Jan 2021 19:09:02 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id D62D889DE3; Mon, 11 Jan 2021 19:09:00 +0000 (UTC) IronPort-SDR: yYRJr41oVV70Eu9lzJiBeP5Z61JCcmlM7IqNxMvd+RLP4Fh1hOhToGBxpmyjjPD3RRHAgItqsV 8w+cgegXaGdQ== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="157697944" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="157697944" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 11:09:00 -0800 IronPort-SDR: x8OKXI5OZ6oXbRp5kghbmzTVfHgMf41WuozxTfXnORmeWBmzptdRz7p3ipEc1UQR4ZnnrT2eiR Ec/TvW8G+ZWw== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="352713907" Received: from libresli-mobl1.ger.corp.intel.com (HELO localhost) ([10.213.207.39]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 11:08:51 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v5 4/4] drm/dp: Revert "drm/dp: Introduce EDID-based quirks" In-Reply-To: <87h7nnwauw.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210107225207.28091-1-lyude@redhat.com> <20210107225207.28091-5-lyude@redhat.com> <87h7nnwauw.fsf@intel.com> Date: Mon, 11 Jan 2021 21:08:48 +0200 Message-ID: <87eeirwatb.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , =?utf-8?Q?Jos=C3=A9?= Roberto de Souza , Chris Wilson , Vasily Khoruzhick , Uma Shankar , Anshuman Gupta , Dave Airlie , Ankit Nautiyal , Wambui Karuga , Thomas Zimmermann , Lucas De Marchi , Gwan-gyeong Mun , Sean Paul , "open list:DRM DRIVERS" , Rodrigo Vivi , thaytan@noraisin.net, Pankaj Bharadiya , open list , Manasi Navare , Lee Shawn C Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 11 Jan 2021, Jani Nikula wrote: > On Thu, 07 Jan 2021, Lyude Paul wrote: >> This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally >> these quirks were added because of the issues with using the eDP >> backlight interfaces on certain laptop panels, which made it impossible >> to properly probe for DPCD backlight support without having a whitelist >> for panels that we know have working VESA backlight control interfaces >> over DPCD. As well, it should be noted it was impossible to use the >> normal sink OUI for recognizing these panels as none of them actually >> filled out their OUIs, hence needing to resort to checking EDIDs. >> >> At the time we weren't really sure why certain panels had issues with >> DPCD backlight controls, but we eventually figured out that there was a >> second interface that these problematic laptop panels actually did work >> with and advertise properly: Intel's proprietary backlight interface for >> HDR panels. So far the testing we've done hasn't brought any panels to >> light that advertise this interface and don't support it properly, which >> means we finally have a real solution to this problem. >> >> As a result, we now have no need for the force DPCD backlight quirk, and >> furthermore this also removes the need for any kind of EDID quirk >> checking in DRM. So, let's just revert it for now since we were the only >> driver using this. >> >> v3: >> * Rebase >> v2: >> * Fix indenting error picked up by checkpatch in >> intel_edp_init_connector() >> >> Signed-off-by: Lyude Paul >> Acked-by: Jani Nikula > > Still stands. PS. You'll still need drm or drm-misc maintainer ack if you want to merge this through drm-intel-next. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5609BC433DB for ; Mon, 11 Jan 2021 19:09:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0371522A84 for ; Mon, 11 Jan 2021 19:09:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0371522A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6AB0689DE6; Mon, 11 Jan 2021 19:09:01 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id D62D889DE3; Mon, 11 Jan 2021 19:09:00 +0000 (UTC) IronPort-SDR: yYRJr41oVV70Eu9lzJiBeP5Z61JCcmlM7IqNxMvd+RLP4Fh1hOhToGBxpmyjjPD3RRHAgItqsV 8w+cgegXaGdQ== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="157697944" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="157697944" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 11:09:00 -0800 IronPort-SDR: x8OKXI5OZ6oXbRp5kghbmzTVfHgMf41WuozxTfXnORmeWBmzptdRz7p3ipEc1UQR4ZnnrT2eiR Ec/TvW8G+ZWw== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="352713907" Received: from libresli-mobl1.ger.corp.intel.com (HELO localhost) ([10.213.207.39]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 11:08:51 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org In-Reply-To: <87h7nnwauw.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210107225207.28091-1-lyude@redhat.com> <20210107225207.28091-5-lyude@redhat.com> <87h7nnwauw.fsf@intel.com> Date: Mon, 11 Jan 2021 21:08:48 +0200 Message-ID: <87eeirwatb.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v5 4/4] drm/dp: Revert "drm/dp: Introduce EDID-based quirks" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Chris Wilson , Vasily Khoruzhick , Dave Airlie , Wambui Karuga , Thomas Zimmermann , Lucas De Marchi , Maxime Ripard , Sean Paul , "open list:DRM DRIVERS" , open list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 11 Jan 2021, Jani Nikula wrote: > On Thu, 07 Jan 2021, Lyude Paul wrote: >> This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally >> these quirks were added because of the issues with using the eDP >> backlight interfaces on certain laptop panels, which made it impossible >> to properly probe for DPCD backlight support without having a whitelist >> for panels that we know have working VESA backlight control interfaces >> over DPCD. As well, it should be noted it was impossible to use the >> normal sink OUI for recognizing these panels as none of them actually >> filled out their OUIs, hence needing to resort to checking EDIDs. >> >> At the time we weren't really sure why certain panels had issues with >> DPCD backlight controls, but we eventually figured out that there was a >> second interface that these problematic laptop panels actually did work >> with and advertise properly: Intel's proprietary backlight interface for >> HDR panels. So far the testing we've done hasn't brought any panels to >> light that advertise this interface and don't support it properly, which >> means we finally have a real solution to this problem. >> >> As a result, we now have no need for the force DPCD backlight quirk, and >> furthermore this also removes the need for any kind of EDID quirk >> checking in DRM. So, let's just revert it for now since we were the only >> driver using this. >> >> v3: >> * Rebase >> v2: >> * Fix indenting error picked up by checkpatch in >> intel_edp_init_connector() >> >> Signed-off-by: Lyude Paul >> Acked-by: Jani Nikula > > Still stands. PS. You'll still need drm or drm-misc maintainer ack if you want to merge this through drm-intel-next. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx